From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBEEDC54E64 for ; Mon, 25 Mar 2024 12:40:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C4F56B008A; Mon, 25 Mar 2024 08:40:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 574B66B008C; Mon, 25 Mar 2024 08:40:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43D1F6B0092; Mon, 25 Mar 2024 08:40:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 330736B008A for ; Mon, 25 Mar 2024 08:40:11 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EE349406F5 for ; Mon, 25 Mar 2024 12:40:10 +0000 (UTC) X-FDA: 81935518980.17.7D03A8E Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf04.hostedemail.com (Postfix) with ESMTP id F32FB40021 for ; Mon, 25 Mar 2024 12:40:08 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NetsZLoI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711370409; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XB45BiVabHfmUkxlJuWWQAmoKjnTiH/0tlm2fLhu3cg=; b=KZb0CrkSLL+F976XZ4R+DSaaPc8Qjx1/oOD90NoC8nnHKWLALI0pLILd4yr4x3FT5R140b 2lP0gII3Cd9vft5cGhSkAZjSKDwn7sFyWlsN/qsH2wuZTGhadiUh1kxyUHmliELPxddTyX 6lOVG8YmlLkJ5wsGdCu3zlGvnZ0enyE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NetsZLoI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.178 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711370409; a=rsa-sha256; cv=none; b=yFzvgkejzpaCeEhf6i050DzG/G/K/Eo0miGMsylzqfBtGF3fOi9+NRdHRnU0FwHTKVHiHP 3lR2PRBRhNP+veDMQ1EPfxauJWdMce2zdtVVv+ys23uS+V9IC/auhp1FT7U22O9XO2A7Lp Xgl/YVxw2+AC6gwnvEcLpYA/9XLvYRE= Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6e6ee9e3cffso2877689b3a.1 for ; Mon, 25 Mar 2024 05:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711370408; x=1711975208; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XB45BiVabHfmUkxlJuWWQAmoKjnTiH/0tlm2fLhu3cg=; b=NetsZLoIgdYsEEkhD8pND5u0WYmBxLPjlSFpnfyPmRn0UUxGEdWGUHLphbOt+5aOnS /5pvN548j4XK2UDNpJ/DkK+yVwvyzB47t5Zb6qbEsdpnROoYHIIN1tnakWotjr1S6dqb hPgzQCesXd1HO+0JlMfZNA4uM1WOZBTERNid1DGODoP2MSuC1gHCjFbcdHqQ6sXMDAgC KhqhxsLAzsG/OEBBWYt0gmnTDZFhzK8SchbDzBvTlU3Tm1fSVUPuVTbCqlryFv1OrufR xKZ36TxYtzK29ukOrre++Ey+bwBEbtfXmwdHWtVNFm+LQvQrmsLHUpdBolc9CuTF/um6 e/+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711370408; x=1711975208; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XB45BiVabHfmUkxlJuWWQAmoKjnTiH/0tlm2fLhu3cg=; b=j3eCfDfV581gvweA6mAwy6TiEYu2NzrxmJatKio+KjJtesxLTbMf0DiifsOoszQNkv R6ly5eprGY34XStZhA0OgGdc6LqAhgP/uDLSZ97/wl5QTK8rn6ZdI/7Xl0kQEKJheM7p AgIm9F6caqwk3YVupc8C+zmHwtd13M8G7AVWCzci9XRuutqmaeIZswnygSB/2pX/uoey YcDwIVNW07w+P1knPHzHt9AS6c/pQR4JL3snzKK9cZ1atYqZDoraGTNpwVNongf0p7kT 1kEvzPvKaroWXqixRhNEFveToUBAYDfZ1z8NUWC2rNFboxMk0SS11RudfBO37MShs4xv Ijlw== X-Forwarded-Encrypted: i=1; AJvYcCUiscW9YGkHGyDaOiGCQqwBGnN0R/FcVSjvfc5g5U7SvqjvPIMoHF9mWdftLMEFzF29cOSukz1fdLoG+iV5j6kdGR8= X-Gm-Message-State: AOJu0YzyI7+1IxOWMeq3b+FU6GkB3+i6NJkYjoD+bsqEc4EonBJjzKeQ sprcnm51xui+P19pJQ7A48IAHILSzeOVbfJ8ZFHfwdeFPmE9d+rJTVpbzApA X-Google-Smtp-Source: AGHT+IFHWYllbJcf/ZdUOUZMtQeFd025rrAYdRDS/0Bn7CQz5YVRd3TYearEEFInBA4aieBgpoF+rQ== X-Received: by 2002:a05:6a00:1ad3:b0:6ea:ad5e:54fa with SMTP id f19-20020a056a001ad300b006eaad5e54famr3073383pfv.13.1711370407804; Mon, 25 Mar 2024 05:40:07 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.20]) by smtp.gmail.com with ESMTPSA id v65-20020a626144000000b006ea944bb4a8sm4194274pfb.59.2024.03.25.05.40.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Mar 2024 05:40:07 -0700 (PDT) Message-ID: Date: Mon, 25 Mar 2024 20:40:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/14] mm/ksm: use folio_set_stable_node in try_to_merge_one_page Content-Language: en-US To: Matthew Wilcox , alexs@kernel.org Cc: Andrea Arcangeli , Izik Eidus , david@redhat.com, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Chris Wright References: <20240322083703.232364-1-alexs@kernel.org> <20240322083703.232364-14-alexs@kernel.org> From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F32FB40021 X-Stat-Signature: 53xi3mbrdzu74mifxbzzd8a1e9ndqi6f X-HE-Tag: 1711370408-372568 X-HE-Meta: U2FsdGVkX1+DuEt1JHiqvGyZrNp1VhfNat2i4D+zGvlXrZTsK5qfAgyFilXipLbCIJ9P6b3rDiDwc9M//n2JIzbpm4dNaWZgZNXFE73X5d5XrVV2i+9QdpL+AoGrP6zJdOBJ9sP50LNp3ejE5E48lEoesp2j1FW3WaEASCIy/CaURW9Xr+rcJiNlrNPbc0opSn3/eiVpfRbYO2rL7ujf7bfG0Ri7iinaKghliyncsHxKVgphtBlN8dreV6z7Frxu67Qn/j98tTjZ6iV3mox/anJj0DjoveEdjunhsqYe19lL7fDcuegUclneJNAm/ftE0WYSvXx0pwWASf22Ovi1gtzMUpYoV1OTpWZMx6cJ4FRZRQGM6rhwbMNippb8K2Y7QyOiwwmexqylpwu4gd7VZY1llFfvHOw2bw21uZ/StH6uI+Pj8lkyXUQhsy5C7rn3m3tZhuG4XEGvPWCsqO2nrGvDTHeP+7KJQWDsQb/fZgQcbl+VOd/YoclfEHFml4+nzs5kucNG9tLvLGnvkWM33th20GAX8tTLEKq5eMY6a5xrEWqWBGhrrJsSfPxFuAY5RunM+J84BsnQ8VL5QuI/v6vjM6biyMLceVeH3Q71NzEWfP36Xi/49tfgd8pRW+F7NAB4O0XHptK72jC38ZCC486eYppkHCZCypffFWuhPYagbvvViUVWhi74ppHw96dPbkv7lSbsJpiXo76SROAHpHpIozxCGaupuF3Etd3EjFlI3M6DxiDlLQFLCZ6teujEWbPJ44ocO47kuGX6y8SKxkloApFzmXAvweyNlK6JYeQvF5HExuJFvhK+1kphUJ1TDTGUeimFlCTn/RkgbZM0JHtd/X47AH1oWGG8mTsJcc7Gyz49APZuTXNQUrx8VRcpdZMLnCUJRigA+JK607ZmjQGuabNDn0SRfx+kY4CdiqKStqVToD9O4j+EOvRgY4xYeE/XJ503GTe+GuXSBpn RYMmENMr k4nH7m+3p2RMEP2SqzCtDNb7mNMnjQoDFAXTBTiHXiWU/CpyNc1vI0t9pF0Cmc+ZVnKHbZFyRSjU2Bly3C09IWNQyYOYiBdVrObjqyULRD4lqrbcP/TDLrbVRlv/FGJAB574D72Bdv9AaQx76J6ALrcm+QHODBRZHWTveq1seCvxPcHcpKINTkSWGz8wo9aL9ntaOT0jeAvQIkSLtayy/Gk7mdjxMviIvTEJ1QIXBMfzCFYkWYvxkFnYoHQ3uLQ+g/KpI67lvsE52CmdCzyPfEAogFChwuoetuxu5dNxrD4ANihgfQOrTsQEdEwuGwnBEOvYnpHcLnP5v94QQDoSxEh0QXj508LKCyfxhti2tFTUz5LptjZt0ron7aOO80aZnxyNenmV1DXeT8F3sK4Kpv7v0TS7Js+b82tKjEiesPPdMoG7k4dTPIuV8S4cChnJvG2knplVdjNiDnHWE4YJo4qbATL2KQmb0srCHkkW4OImdeh8WMHYhNuZ7lJmSBPxZ2dwB/fZKl9unRRab3gp5Jdy4OroAmi5wLdexGpsCFnN13hnUekTnRlw6aXurO0dgXCWpNt2v8EEyRMneDpdRE+JV7pq7Bw6KJchFtlpNZ8OF8enM0nprng/vrYNvV1HV26qoRiizfjJF1UzOZjvr4O16c21lQWzwJozbWYKRvlBKJPuStlNYrvbJEgpDXM3etAO+dX9azQmH/iKdJmBSgNsAjG3jR0xUN0NDumj/QbM/Bw0Lnc7H8YAMA5C2g+bboQ6AGuPQFE4mevi08SqJrcv8EQP27iwutwA4KVmvIu4QDx8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/23/24 11:38 AM, Matthew Wilcox wrote: > On Fri, Mar 22, 2024 at 04:37:00PM +0800, alexs@kernel.org wrote: >> From: "Alex Shi (tencent)" >> >> Only single page could be reached where we set stable node after write >> protect, so use folio converted func to replace page's. >> >> Signed-off-by: Alex Shi (tencent) >> Cc: Izik Eidus >> Cc: Matthew Wilcox >> Cc: Andrea Arcangeli >> Cc: Hugh Dickins >> Cc: Chris Wright >> --- >> mm/ksm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/ksm.c b/mm/ksm.c >> index 15a78a9bab59..d7c4cc4a0cc1 100644 >> --- a/mm/ksm.c >> +++ b/mm/ksm.c >> @@ -1518,7 +1518,7 @@ static int try_to_merge_one_page(struct vm_area_struct *vma, >> * PageAnon+anon_vma to PageKsm+NULL stable_node: >> * stable_tree_insert() will update stable_node. >> */ >> - set_page_stable_node(page, NULL); >> + folio_set_stable_node(page_folio(page), NULL); >> mark_page_accessed(page); > > I'd rather you did a conversion of try_to_merge_one_page() instead of > just this. It'll be a fun one because you'll have to recalculate the > folio after calling split_huge_page(). Hi Willy, Definitely right, the merge series funcs need more careful changes. :) I'd like to left them for late changes. Thanks