From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00C36C7EE2E for ; Tue, 30 May 2023 08:32:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7755A6B0072; Tue, 30 May 2023 04:32:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 725A2280001; Tue, 30 May 2023 04:32:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EDF2900002; Tue, 30 May 2023 04:32:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4CB1A6B0072 for ; Tue, 30 May 2023 04:32:08 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 07B9D120172 for ; Tue, 30 May 2023 08:32:08 +0000 (UTC) X-FDA: 80846253936.26.A009E99 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf12.hostedemail.com (Postfix) with ESMTP id C32D64001A for ; Tue, 30 May 2023 08:32:05 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kCJhCCej; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=EQMZKhqc; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685435525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sJ3r+Zcx1F1VI+OHNvs6PGvIA3W5WTyjuv6T40x7/nU=; b=EszlB260UCQkgN4oYcnvsUBRp/sCWjmNMSB1QkH4IJk+fBKU6ouLEH2TJ1/g8uFp16OXxN Lda532+80BUURf8WjtpHiRq3fB9xmUgvfkMQxopwJ5XAtwJyHkosGMa95sqkKbMABWrraS kwmD9VENP0Trd99eIub+De4aQIhhiC0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685435526; a=rsa-sha256; cv=none; b=5xKLwE8KkHArxBP3veDwXzzWl673h6X/COqWnG1R0L0VOPzWu7cQN6bQCDS4edG+qqPuWX PKhbS5WowXZEOQ12ulwWdJn9rQU2ZAYDnZ26914hkYTqDZKVHSJpSfIW+7d3VKP7+1Jb8r Cv1oE1z9FPCbMHxjASWcKz1KpfQ+quk= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=kCJhCCej; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=EQMZKhqc; spf=pass (imf12.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 620B21FD68; Tue, 30 May 2023 08:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1685435524; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sJ3r+Zcx1F1VI+OHNvs6PGvIA3W5WTyjuv6T40x7/nU=; b=kCJhCCejAz8NUs7P6KKXTDUcHPzLK+fGX9DRmATol1HakU3DvPYj2goWEQ8VlvrgkY0gMm k95ROY0vV7pY2umzpBKfQ+75vRTSy5HpgDek6ORBZE9OBSQ147FsOer6NuRABJE53aKpWg CHsyKfB90nkcp8RIlrsWpEOXYQu0f2U= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1685435524; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sJ3r+Zcx1F1VI+OHNvs6PGvIA3W5WTyjuv6T40x7/nU=; b=EQMZKhqc567sVwXgTpNUk6s6PURSTUqUkFc7OEfgKv6tg22lt50mxI4CayfMWAcAsEymTH hMfqXCux25tlY8Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4A02513597; Tue, 30 May 2023 08:32:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id AZhrEYS0dWSfLwAAMHmgww (envelope-from ); Tue, 30 May 2023 08:32:04 +0000 Message-ID: Date: Tue, 30 May 2023 10:32:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 6/6] mm: compaction: skip fast freepages isolation if enough freepages are isolated Content-Language: en-US To: Baolin Wang , akpm@linux-foundation.org Cc: mgorman@techsingularity.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C32D64001A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: zp6ahx7ehc3psde6inbo61eyhthroc5f X-HE-Tag: 1685435525-327741 X-HE-Meta: U2FsdGVkX18ey9pKKM0JapKpcFzF9R2GsI0H4dIQo4otxKziot48vsw/MORXyUUe4txqHkgit68GYjD6oQTMDZOMZOl7QwQErxNK+brhnpIf/WAh3z1xVAElGm8W7UMDxTokRGfrITurAsnwcZAVkXegi+gmc+FyCxqXdH7Y9t5Ul3KmoSbhRhVTHGWl4aXzqHHxL82bmRkNQ99WfxAfHjUNVvjQPMAIGaD9+frpHHjKq4HfNpw6mexxx0AL801WgvPBOVCkhg90t+lEgk2l0Rc0u6Cd4xhfs+9ZwuRnIwkv+N43zcQ+1wI2oakJB6JqM3CwYulBMGlHRdWWQ61CDn6AKCtW/dTrPUuceEWI8MxkxSVO2Kzv2GyP5w6kCzGj5fYTarZmzWJ9RxYuWvBNuddj1/GJEvBiSCIs1leYHnqgkkocgSGrxvK80diHClsUB7HhUpvBCRDsCzegGuUTcKqZYDOeu9tcrknObNW4knOdqI6tMALt+HXM5Hk9Xyseo1Rd5aTDO/2iHZH2Sz+plM+Gfuy65YQTaTmNuLuSOfBoFYG7vLAoH0CBC73f++U7aJVAMwIgEQA+jvvsWe0G8YoFdqVdpLNtTPndoidt9raUcjzJeL+PO1qITTNrKypUBz6rhqUVEiD6piUZm4K81LvoHUEnWg+vzdl++jBxFzc5XK97sLCD1YO6JgXKXrHgecbNPMQeM+odDSAH/mY7A80+iySf6r4Kpan2Dvv9L12E1DBtzRMBCKSa5AYMs+aVMmG1OyZFLiWcXDkM/9WVQw7NhVQb58Z3xjMvqxZRVOe+PGwVtkDIqujjCGI6YaWNCFWhpQFIYUToiXNDF6edr3ONVz7WGAIejoxBLTOXTREf5E6tluE7CwhTqgqqs7dYsPE/+v4kB+555wqsdCFAntGvveeKAFjEp2bntNT7HTThMNTEU5eklmR0YkJwC4aSZcRJw6fsx4U1wGUvSeD XSDM/EH2 p+nDPs6yEQjAMmOkovzM8zLTYtAtl5U/GkJAoAXyvdNl0OztyuAKela3g54OC8aFVPo/ZzB+wuduNFDyhKkFluO/6S5zp6mA1K6kMP6qL+/cpM1UtQrv5vqa38CncQB6abSNMYczT+zFOr8Qkq2muQsVv28+oMmjK9VnNGTTrxysOLhlVYdTle3f2G2srQbYCMNEXZywlJ0rqk28XlftYi0VUEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/25/23 14:54, Baolin Wang wrote: > I've observed that fast isolation often isolates more pages than > cc->migratepages, and the excess freepages will be released back to the > buddy system. So skip fast freepages isolation if enough freepages are > isolated to save some CPU cycles. > > Signed-off-by: Baolin Wang Acked-by: Vlastimil Babka > --- > mm/compaction.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mm/compaction.c b/mm/compaction.c > index eccec84dae82..3ade4c095ed2 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1550,6 +1550,10 @@ static void fast_isolate_freepages(struct compact_control *cc) > > spin_unlock_irqrestore(&cc->zone->lock, flags); > > + /* Skip fast search if enough freepages isolated */ > + if (cc->nr_freepages >= cc->nr_migratepages) > + break; > + > /* > * Smaller scan on next order so the total scan is related > * to freelist_scan_limit.