From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4DC7C36002 for ; Mon, 24 Mar 2025 08:39:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CFE2280002; Mon, 24 Mar 2025 04:39:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3558C280001; Mon, 24 Mar 2025 04:39:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F90A280002; Mon, 24 Mar 2025 04:39:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 00F1A280001 for ; Mon, 24 Mar 2025 04:39:00 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3C17E1CD14A for ; Mon, 24 Mar 2025 08:39:02 +0000 (UTC) X-FDA: 83255794524.02.1F46E24 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf18.hostedemail.com (Postfix) with ESMTP id 4162B1C0006 for ; Mon, 24 Mar 2025 08:39:00 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742805540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HBG2SFimC367ri+OK5yqfITjdNOx6Z+4gkaFl607Uhg=; b=CcbUqDKKJX6OSXVSm7HIQSkEvM+62Q5Ea0P5xqB9UrLhALenhjEX4tNbQFguDPCwNs19+b Vr8RGcJi2+QZsS4WHnLRjngEbMPqqQDM+62qUNi68R6ebhlRHvB+p2BVcKy0MkEIAUrxpe 1Gw/oT6SwzW1Roym6iDVwA3xFohgveI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742805540; a=rsa-sha256; cv=none; b=bFQcPGwf4V7A/CDsGwA4fEbydr70bWsJiZS19EN25hem9CeWIpdxHYG3oimBzUjiPNdhXs eBuny4mngCOeRD0KkBhN+JCzsWJqysdvNtw5vDwm/kipxLdKbwLLL6UHMMpFd8T0ouYpV/ Mc78YE1QRhpfQjnzjF894oHoXXUNwBk= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6A3C51A2D; Mon, 24 Mar 2025 01:39:05 -0700 (PDT) Received: from [10.57.41.67] (unknown [10.57.41.67]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 53A833F58B; Mon, 24 Mar 2025 01:38:53 -0700 (PDT) Message-ID: Date: Mon, 24 Mar 2025 09:37:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 02/11] mm: Call ctor/dtor for kernel PTEs To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Albert Ou , Andreas Larsson , Andrew Morton , Catalin Marinas , Dave Hansen , "David S. Miller" , Geert Uytterhoeven , Linus Walleij , Madhavan Srinivasan , Mark Rutland , Matthew Wilcox , Michael Ellerman , "Mike Rapoport (IBM)" , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , Qi Zheng , Ryan Roberts , Will Deacon , Yang Shi , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-openrisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org References: <20250317141700.3701581-1-kevin.brodsky@arm.com> <20250317141700.3701581-3-kevin.brodsky@arm.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: <20250317141700.3701581-3-kevin.brodsky@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4162B1C0006 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: nsikhsxzf9j1rzspyozffnnxwnoya13j X-HE-Tag: 1742805540-49611 X-HE-Meta: U2FsdGVkX19wUhtxt9h0zH6nj134j1tmw9F5pfEELtX4KKxYOBBn90avtrKVI0HHO7jCkgcUrroGR10rHSHNqpQ1WYR9JzmQkhwPy5xyggyfOQWzRH5CdyLs2HONDssSvDM3eA+NWL9ejT6dWFhXkwCvexe8zMz2xwTH7WUkI+tuBhj12dlOgjeuNL1N+SWxbIwhGBk4KZBhG02HvUmeu7F/1MlIFAWvdnnpB/7JNYZWl09VAjqaonV+NpE5lgn7RlelNHDmpnQO5aiKY9ioYtTrGDBsqVfw5M9hQvUxiNU/LLW227o0r2LVbgu4I9wwjFBAR7MHI4PAcZxdbB/vgfDSBXOfLbXd0Dqd5ASvJM8w+9BxjZJO8jtS92SbRddWLiEQAt+O0N7XqyXdkVgxMCDOo1hV0io7vgrj2RZgqU7chm2OEMW9UBbnzEHGmRqOqUl9K73qkj584ulPLcVl/LDOlUQBr+Dy/sUbSa74odYb/z24ttKmuGjZ/KzL2YPqzyBmznEO1rPkJawRl0CkR+7R+TZOdk8WOggIWJSIvVhfnatPD16Q9wZLPkAUdow9NdIwkp4Dss0lvou/IomPDAw71xdFaJkVAmfIXW4Thm2omVOfdY+xzB38h2quCHM1Fju3G8SQEjOIE8exUJfUwzvrTYMVavUhlEfGkdnimZPa7qIq8yiyzstVl3aqrBIp0hrhDi1kPDikKnYRsJAPGqFI9Buke8fboL5Ziy2mvksXnzfSwJ3007G4zPSd9F0RqZ+TApJOPDDFYnS2JGVkB9W/lwaZPSodNK/U0cCPqfL/w+K50ZoobFSLcRQ0cjDtU7NKuDoY6SFlWao/Ze95uZiwivV+q7KkEi7TCufHSWh5W6Hzv3X9Rkn6EFZTJooln284+kiaJFZvFkrjjhHFSmM08NVr/zf83tJfIpv82B++x6YPZRAX8clGGKVTLXRtW9aWi1vlljcw6WjUMHl XE3p7h/n lReqnr6soHCGbtmETeKH5r6/iQ7Qn02origEtf7bhzcco+VKkP2rG6uKFptNOrlOI8bw+VbO+zFrdO3JlRrHoPPpRPu+shahmLMX9VfcAhm6qF4VCG3qzs69LNO4kHpNnklKoiYLG7XrYICyU3ZYOzcD4WkQmT7giQFXgH4n3EWwgCCryWRtwqto0S3GqmTTixMwy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17/03/2025 15:16, Kevin Brodsky wrote: > diff --git a/include/asm-generic/pgalloc.h b/include/asm-generic/pgalloc.h > index e164ca66f0f6..3c8ec3bfea44 100644 > --- a/include/asm-generic/pgalloc.h > +++ b/include/asm-generic/pgalloc.h > @@ -23,6 +23,11 @@ static inline pte_t *__pte_alloc_one_kernel_noprof(struct mm_struct *mm) > > if (!ptdesc) > return NULL; > + if (!pagetable_pte_ctor(mm, ptdesc)) { As reported by the CI [1], this can cause trouble on x86 because dtor calls are missing in pud_free_pmd_page() and pmd_free_pte_page(). Will fix in the next version. - Kevin [1] https://lore.kernel.org/oe-lkp/202503211612.e11bd73f-lkp@intel.com/