From: Mark Brown <broonie@kernel.org>
To: Chunyu Hu <chuhu@redhat.com>
Cc: akpm@linux-foundation.org, david@kernel.org, shuah@kernel.org,
linux-mm@kvack.org, ljs@kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
vbabka@suse.cz, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com,
npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
baohua@kernel.org, lance.yang@linux.dev,
"Thomas Weißschuh" <linux@weissschuh.net>,
"Willy Tarreau" <w@1wt.eu>
Subject: Re: [PATCH v7 4/7] selftests: ksft_exit_fail_perror: support printf style arguments
Date: Wed, 1 Apr 2026 12:03:09 +0100 [thread overview]
Message-ID: <efbad6c5-8d5e-4774-8d0a-d455e6e2c182@sirena.org.uk> (raw)
In-Reply-To: <20260330151503.670415-5-chuhu@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]
On Mon, Mar 30, 2026 at 11:15:00PM +0800, Chunyu Hu wrote:
> The ksft_exit_fail_perror function previously only accepted a single string
> argument, which limited its flexibility for providing specific context to
> failure messages.
> This change updates ksft_exit_fail_perror to support variable arguments,
> similar to ksft_exit_fail_msg. Adding the __printf(1, 2) attribute enables
> compile-time checking for format string correctness.
This is causing build regressions on the arm64 selftests:
/arm64/fp/za-fork-asm.o -o /build/stage/build-work/kselftest/arm64/fp/za-fork
In file included from za-fork.c:12:
../../kselftest.h: In function ‘ksft_exit_fail_perror’:
../../kselftest.h:427:13: error: implicit declaration of function ‘vasprintf’; d
id you mean ‘vsprintf’? [-Wimplicit-function-declaration]
427 | if (vasprintf(&buf, msg, args) == -1) {
| ^~~~~~~~~
| vsprintf
This is because za-fork uses nolibc which does not implement
vasprintf().
I need to look at why this managed to pass the build testing I do in
-next...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-04-01 11:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 15:14 [PATCH v7 0/7] selftests/mm: skip several tests when thp is not available Chunyu Hu
2026-03-30 15:14 ` [PATCH v7 1/7] selftests/mm/guard-regions: skip collapse test when thp not enabled Chunyu Hu
2026-03-30 15:14 ` [PATCH v7 2/7] selftests/mm: soft-dirty: skip two tests when thp is not available Chunyu Hu
2026-03-30 15:14 ` [PATCH v7 3/7] selftests/mm: move write_file helper to vm_util Chunyu Hu
2026-03-30 15:15 ` [PATCH v7 4/7] selftests: ksft_exit_fail_perror: support printf style arguments Chunyu Hu
2026-03-31 10:31 ` Chunyu Hu
2026-03-31 19:09 ` Andrew Morton
2026-04-01 13:32 ` Chunyu Hu
2026-04-01 11:03 ` Mark Brown [this message]
2026-04-01 12:08 ` Thomas Weißschuh
2026-04-02 1:16 ` Chunyu Hu
2026-04-01 13:46 ` Chunyu Hu
[not found] ` <20260401143831.31f40405758f78d7955ff6db@linux-foundation.org>
2026-04-02 1:13 ` Chunyu Hu
2026-03-30 15:15 ` [PATCH v7 5/7] selftests/mm/vm_util: robust write_file() Chunyu Hu
2026-03-30 15:15 ` [PATCH v7 6/7] selftests/mm: split_huge_page_test: skip the test when thp is not available Chunyu Hu
2026-03-30 15:15 ` [PATCH v7 7/7] selftests/mm: transhuge_stress: skip the test when thp " Chunyu Hu
2026-03-30 19:25 ` [PATCH v7 0/7] selftests/mm: skip several tests when thp is " Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efbad6c5-8d5e-4774-8d0a-d455e6e2c182@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=chuhu@redhat.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@weissschuh.net \
--cc=ljs@kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=w@1wt.eu \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox