From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 991CFC8303A for ; Tue, 1 Jul 2025 12:50:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FCC96B008C; Tue, 1 Jul 2025 08:50:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D4436B00AA; Tue, 1 Jul 2025 08:50:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C2F86B00AD; Tue, 1 Jul 2025 08:50:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1C9E66B00AA for ; Tue, 1 Jul 2025 08:50:05 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B45821A042B for ; Tue, 1 Jul 2025 12:50:04 +0000 (UTC) X-FDA: 83615678328.20.AF18CE5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id AADE310000A for ; Tue, 1 Jul 2025 12:50:01 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=E9SKn8HF; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751374202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=C+eeNIGph/RfboTkvhQ0KJF1oXksncRWcmuBP7S2QrE=; b=BzDS+X7uhNIhvBNJoRqd/ZscSy4s6d3mSTiTbZ/an/1IuFy5vVmZdz4/ZEkDa6EJbXU+UP ABadp+Yq3Q4cRZw0CtE4SvPsz0zLhNiWiCqHwz8FNXT/sRQvgGMBsc6YNRIMBOGRHj+Kbz +/5B7t6dizpzgrKe27ZDBjSvYcLZ/Vg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=E9SKn8HF; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751374202; a=rsa-sha256; cv=none; b=bTn5zrHCZRSZ7RVA5LWHC3Bw+U4wvnjgY8/wcOHBTP3S1kl0ww6EMSA0HtoHO/GvEEEwxF zvxgBV2ngDcIWaxeh7OAS1eaLqAkdmp+e7WA7CusB3yWP+bOtjc4nzGs0u8AYsxk7oDt4I /XDyZlShWOwB3aCxwyGrLYjTh5TsF6o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751374201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=C+eeNIGph/RfboTkvhQ0KJF1oXksncRWcmuBP7S2QrE=; b=E9SKn8HFJdW6acDbo7ztxerRis0nhTS2+4wr76kMG2/9NEEGTN2eJKJ58+Lli0fPfMzWmj RwBzJB8r57jWNcRXLCj0/yaVBsQWWqQox6ROyhgYqkL8hLq9vICjVGIy4SiU/QtS9j3uSK qZBwP4iDy3jRAZdjgfAiUgt6G8PAKtk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-226-wOUsWVlmMaKALqyBTu7rbg-1; Tue, 01 Jul 2025 08:49:58 -0400 X-MC-Unique: wOUsWVlmMaKALqyBTu7rbg-1 X-Mimecast-MFC-AGG-ID: wOUsWVlmMaKALqyBTu7rbg_1751374197 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4f858bc5eso2394210f8f.0 for ; Tue, 01 Jul 2025 05:49:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751374197; x=1751978997; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=C+eeNIGph/RfboTkvhQ0KJF1oXksncRWcmuBP7S2QrE=; b=QdhKVAH4Kg/xX60LK5B496Tl5ea1tVwxKVdiliw+Eu3vjZhP/sttULOEjyvjIjWZWH bABgCvzX5kSLkWI0cxK/gZFr0lTYGxyQdLUyJirPVxwNSScN9JRJE9RGMcvIzAkjIeeX cULZT1qKBa4VnpXTgowBmdMhk3pPq2iI/TRpcVUwA7b7lvSZm81s7FYeSoTBNIy7KsWu XjlZ7JkOoXe1MJz+boZCCymR6VyL72s9daMXiMGfQvpO5ftCb/yKJ0VveNj+DIGX9E8T db3IxPdWo9c1snG7UdNhRgKZYCvQYU+js9UabUwS/C40huIHFkIBankwfTWaLLyabsly svLg== X-Forwarded-Encrypted: i=1; AJvYcCVX4rp0KSQ50eOzAQswt0PrRHQimfyx0fHmIueqoaIPervUKWZ5hSOVOl4lzHNIkfCo3sgde5cYNQ==@kvack.org X-Gm-Message-State: AOJu0YzZxTEJZaiiZT+68xu5QPoixCWMdGABiwQqxC02RPS2XJ/3aqXP x7VnkAKKsMoFo5k9SDxg0gtYi3JPM9yiPWCF6ND8xftLmTlSKaYDbDFp+JvpA5LKvvhbvxGHOlB cgCf/gTEDqi6ikoyNzl4vAtRTY9hh4la+4RaXjxDzNDmDor4ri6jW X-Gm-Gg: ASbGncvgSwdlG24KZs86A5P/QigUCHrwbyksoy9X9kT2RdyYfSFS5aYNbwnzNeRmPh3 NPXHOBAwyZi+Hokrm8WRh3/gTnby3feq7ihOL1Jw+1qhXGJsjXmLttw3Krgy/CCY/2TFYhP3GWZ 45Pd+r42NxJrR4kaaZtAGBvkacDS+9E5JLLJgBAuFAllooXnZyLF4n/D4q7YVDNAgn3peIMn/Dh HxDpooaTDejX3zIf/gcL4xEh84o663o+1e54tIT/Vh7VuH+MrG7WU+grCBVQgg1ojdf8rmS4Fin P8s51ki9+pF3KVNCB9Ek+QC1BspS4tK6zRGKQgPlFCgbBwlslUp7EuUZw+gkRU2l/km8OayBhoM 4Fi9xGXMlpOTuplsD+xD3Ng9MmK4JLQm4Ra8MwONjZVTyNOknjQ== X-Received: by 2002:adf:979c:0:b0:3a6:e6c3:6d95 with SMTP id ffacd0b85a97d-3a8fe5b1b18mr10836931f8f.41.1751374196721; Tue, 01 Jul 2025 05:49:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAxFPpLtFvUGf5RCxIdMcSORQzf+JZ0BcoaG83ZHXzVCGagtBTeeRvpO+7s2vJcmdXsJSXFQ== X-Received: by 2002:adf:979c:0:b0:3a6:e6c3:6d95 with SMTP id ffacd0b85a97d-3a8fe5b1b18mr10836894f8f.41.1751374196190; Tue, 01 Jul 2025 05:49:56 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a88c7facf9sm13066611f8f.22.2025.07.01.05.49.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 05:49:55 -0700 (PDT) Message-ID: Date: Tue, 1 Jul 2025 14:49:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 20/29] mm: convert "movable" flag in page->mapping to a page flag To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-21-david@redhat.com> <0150bc5a-1275-4205-8d85-82364ecabbda@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <0150bc5a-1275-4205-8d85-82364ecabbda@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2VRlLQGc6JmMepslbdNEz2yTBrgRzttmXYrM84sIusA_1751374197 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AADE310000A X-Stat-Signature: fd6zxebt16jikweymzh8ix6f6a37ax97 X-HE-Tag: 1751374201-685215 X-HE-Meta: U2FsdGVkX1/j8abYzH1qH1EYsB9gzUctfSHwNr5GY9aZjeKssyqnBiRe3jCPrCDSGRGskas+paYPJLVY4w6vTCItBcZpu2SOPcIKcfHGejxORWfB4wapUXB1O5guKsmSaE4qZV4FwyUuqLmunQdk7jC89EoDvDg+gUtVlI69wFTM4vwCSiUaW7+kzgVNH3BQn5mslajc8buEMzjEz2BhKMXBSZOQ0htgvRd3MBdgo+/mE16fSmreZpRZ8Dd+g5OVGmCCIzYA/G+1/l1WUpYX6AM8WXsFuR0+GvZzxbcfDDrpJw5JzDNCilBAgNiA/FiocuEIJDarKkc5FwyTU3NDlFfdLMMm++ujmI4DyqJwQYfdFeCYhxlzuQdDgJZjXJwAUy7n05h11wg14k2j/ildTPBu84SduwjrYd4EDR/7dPfeuMiOI9zh889DXfajXnZVirMf/LCSlpHIGErSXAxXCXmP7kgYIipmsbrla4n4vexLJNKB88VJTojNE3Nq2cvrqAmlMsmZdIaPmPeJpn3GoN1/oVKboN0jx4QVJoV9Uyb8tdrEI1yeRYkepPyY+00RhO5sRmfsUCBSRHJ7pskCLyQk+be8dIyvOw1p1EyitxJKFUnlZZg8X+dC+4ohgIxtx7qfSn+NJHzcGWOoCTqBkkHxCAvcu3nYoDjHOeiGLL2jp5lZq1OlYRlkP3Od24/9iTx29HbFUyohWzHkpSAieV4FAy89P9GOItTNgplM85PzmRS1NB3alPdzPJMCNBS95MJwxe8WQ17qAafE9dRQMm8O/9tbrbvSW68nKyoDxLrWHTrEaO8HoGunzenmLkklfx94XnDe9hYbcIuckMuW7jIjQihe9r9xTi3BQmxaZx82DBWvHsYC+sEUscuwiAYsKYOqMxzLl4w4DuMgPsn2alDnuABpy0hkJyGl46S3bbOlkMyp/hXIXvxF2h6HyiMM85f8oR/IDdkebf3E+S/ bR0K/sw6 CsVDxz3TYh9x96TGiaoS7BMCru5Tzi0ZlbCePe7CO7NT5T0IMaGvHAXVJ3Y4zRuRmZhdmmA9qLZhcwdRxPVnAYlCYhEIPTeIH2FJnonnEVyFvjqr3sn7ObBvSL3NfY8zX9n4VGE5x2Xm6GiTYz41K2PeO8DOCYRp4G24oK/CToSENwsc6ZbH2pvtpTBw0oF/5weLbFnHVmHB9k4rHc/gbaRQYjMAJF9OBNvrBzcO0xA5GNW3Ix8zApaLpj5jtnb91sqK9q1hHFgMgD0WdOfS+aglOXr68CfdTmdb/3QTyvaiS9Z8qwZWjxf9sI+sueZC9MzbL8IOjocdcAgQqrem74GstHzAoW84G0acRZqvZ3qFbD8as8HNHw9Y7uYiz9d4V4mIKE0JZkrHHqC3eT3BasyVL8B8QTeOJ2VTOqQ75RKpuiElts/rPQ+1gtsHgjjglamy3L9GA3q2LHqKig1YY/lw2dMRQoZvhCc9KT/pPqI0sP23udBQke5+pE34x6Bpau+ntH0KcTa5oteMSI4sJS0rbTMAhwgbPqd08Tey8+EuaWNDG0oeDsWC37IU9ShwE1hwv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.07.25 14:44, Lorenzo Stoakes wrote: > On Mon, Jun 30, 2025 at 03:00:01PM +0200, David Hildenbrand wrote: >> Instead, let's use a page flag. As the page flag can result in >> false-positives, glue it to the page types for which we >> support/implement movable_ops page migration. >> >> The flag reused by PageMovableOps() might be sued by other pages, so > > I assume 'used' not 'sued' :P :) > >> warning in case it is set in page_has_movable_ops() might result in >> false-positive warnings. > > Worth mentioning that it's PG_uptodate. Also probably worth putting a proviso > here that we're safe to use it for movable ops pages because it's used to track > file system state. Will do. > >> >> Reviewed-by: Zi Yan >> Signed-off-by: David Hildenbrand > > Seems reasonable though, so: > > Reviewed-by: Lorenzo Stoakes Thanks! -- Cheers, David / dhildenb