From: Nitin Gupta <nitin.m.gupta@oracle.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-mm@kvack.org, steven.sistare@oracle.com,
"Andrew Morton" <akpm@linux-foundation.org>,
"Ingo Molnar" <mingo@kernel.org>, "Mel Gorman" <mgorman@suse.de>,
"Nadav Amit" <namit@vmware.com>,
"Minchan Kim" <minchan@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Vegard Nossum" <vegard.nossum@oracle.com>,
"Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com>,
"Michal Hocko" <mhocko@suse.com>,
"David Rientjes" <rientjes@google.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"SeongJae Park" <sj38.park@gmail.com>, "Shaohua Li" <shli@fb.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Mike Rapoport" <rppt@linux.vnet.ibm.com>,
"Anshuman Khandual" <khandual@linux.vnet.ibm.com>,
"Rik van Riel" <riel@redhat.com>,
"Ross Zwisler" <ross.zwisler@linux.intel.com>,
"Jan Kara" <jack@suse.cz>, "Dave Jiang" <dave.jiang@intel.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Matthew Wilcox" <willy@linux.intel.com>,
"Hugh Dickins" <hughd@google.com>,
"Tobin C Harding" <me@tobin.cc>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: Reduce memory bloat with THP
Date: Fri, 15 Dec 2017 23:21:46 -0800 [thread overview]
Message-ID: <efad97ec-b28d-ef84-75ee-02ac0d3378f1@oracle.com> (raw)
In-Reply-To: <20171215100151.b7j66q7sg2wsrex3@node.shutemov.name>
On 12/15/17 2:01 AM, Kirill A. Shutemov wrote:
> On Thu, Dec 14, 2017 at 05:28:52PM -0800, Nitin Gupta wrote:
>> diff --git a/mm/madvise.c b/mm/madvise.c
>> index 751e97a..b2ec07b 100644
>> --- a/mm/madvise.c
>> +++ b/mm/madvise.c
>> @@ -508,6 +508,7 @@ static long madvise_dontneed_single_vma(struct vm_area_struct *vma,
>> unsigned long start, unsigned long end)
>> {
>> zap_page_range(vma, start, end - start);
>> + vma->space_efficient = true;
>> return 0;
>> }
>>
>
> And this modifies vma without down_write(mmap_sem).
>
I thought this function was always called with mmmap_sem write locked.
I will check again.
- Nitin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-12-16 7:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 1:28 Nitin Gupta
2017-12-15 5:55 ` Anshuman Khandual
2017-12-16 7:18 ` Nitin Gupta
2017-12-15 10:00 ` Kirill A. Shutemov
2017-12-16 7:04 ` Nitin Gupta
2017-12-18 13:53 ` Peter Zijlstra
2017-12-15 10:01 ` Kirill A. Shutemov
2017-12-16 7:21 ` Nitin Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efad97ec-b28d-ef84-75ee-02ac0d3378f1@oracle.com \
--to=nitin.m.gupta@oracle.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.levin@verizon.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dave.jiang@intel.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=me@tobin.cc \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=mingo@kernel.org \
--cc=namit@vmware.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=ross.zwisler@linux.intel.com \
--cc=rppt@linux.vnet.ibm.com \
--cc=shli@fb.com \
--cc=sj38.park@gmail.com \
--cc=steven.sistare@oracle.com \
--cc=vbabka@suse.cz \
--cc=vegard.nossum@oracle.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox