From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECFCECD37B0 for ; Mon, 18 Sep 2023 07:13:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B8BC6B0256; Mon, 18 Sep 2023 03:13:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8688C6B0257; Mon, 18 Sep 2023 03:13:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 757526B0258; Mon, 18 Sep 2023 03:13:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 698E76B0256 for ; Mon, 18 Sep 2023 03:13:15 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2E756140AEA for ; Mon, 18 Sep 2023 07:13:15 +0000 (UTC) X-FDA: 81248851950.07.EB777A5 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf28.hostedemail.com (Postfix) with ESMTP id 872E1C0015 for ; Mon, 18 Sep 2023 07:13:12 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695021193; a=rsa-sha256; cv=none; b=m6gFl39wf34LP800kM1OYHEBYGpndqdVTK0s4me9/JRgVDQXqu9zLNI2H8pfvJWIhxq0RK 6E8fFb9St97NOOHeh+QqbKroVX6X9tSb+JvNEnq12+06EpscWdIBxYe5RRfas2egQgCiYG 8y6MfsaaosrpKf3AVFN7134qBRLDsow= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf28.hostedemail.com: domain of ruanjinjie@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=ruanjinjie@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695021193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RaVv7/p3dVdB2RaMs8fdeJ/iURSJ7ehP5ULdLlSzb9k=; b=H1bQzKuKgCqY5HpdF1EJJ6AbkTeceHfbHyb7hjR/qyhcPEHiLwj3hlYMV2mdLiriHqp6ot 3nZgQF8lWAUm306ux5rQTg8pi1VmI+Td+vFnoxEoj3zluugF/oiVlb7UkVWOLRC+yv3rWH p/xt+QaSEwywtJ6Yq4GogOeVFQf18wc= Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Rpwrz18XpzNndR; Mon, 18 Sep 2023 15:09:23 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 18 Sep 2023 15:13:08 +0800 Message-ID: Date: Mon, 18 Sep 2023 15:13:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH RESEND 1/2] mm/damon/core-test: Fix memory leak in damon_new_region() Content-Language: en-US To: SeongJae Park CC: , , , , , , , References: <20230918053320.61408-1-sj@kernel.org> From: Ruan Jinjie In-Reply-To: <20230918053320.61408-1-sj@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 872E1C0015 X-Stat-Signature: jopwte6wxnrusncwwwa3kj3bxn15kir7 X-Rspam-User: X-HE-Tag: 1695021192-167877 X-HE-Meta: U2FsdGVkX19pZftK4sNdPaD/qC6qv8sD4b/7041GtjKvhkmmEwN5uGuV/+vya4ls2o2/pS+dQjAvLQjxh7EFbpskr7IzPC+WdsNtay/E5X5JV0dG+PgJWfFjO5lMMJrobobR3SpbGnXQLOGQkOAUD8MB4/bI+bF95viVKWPQuwGRL9CpgK0v+dD/XHDTHqa58rsre/tsfE9A7O4v3Qy7Xk40k9boM/hM58xLove9lSdjdDFuKU82ykD0yaMHDAdR+Qfkf/lfqgpyp3vAstvO2kXLfhqA6Ee4KRvFcY2zpIffBCZ2f9IS8dEJxLweaRh6yGLnQkGQD1b7r+sCQGXLy+EXJWlCsPmbhgP9ZzjpuMdK+BY7eUCWqaQdvrxzPAQ8lPQyn+XWRwuWiM2AoSMyuK9IZ/tkz8T6KGBdwdlzVnu7t/X+T/YTyHUfGghQBXptd6hRMKUgxWWj7CMZYRqWUfKxwRi87DOIVPPNm6hkj7aRFgX13PDZiDoZVC2gMQ9kROgT4A41WxOBMczCv+6XP5i+Dd71+ZSju9DVnPD9xDmVRilGjiiZuZyfYG5sAR7lFFg84prPYZZlgO0NdHT5MgPNN1P1u+jVxiGVF4bXxVb0LAMvmxtPPDvhXH4ybBLt/YugfDePPAHynOf848tapAcA1pAdwXIHiUl86SJl1vBoemS11npVdt2VBkbbtIhDxWjzdyoijIJR0RB4YX/IwKAaMt0fzYbzge60AMXBMRGdIvcTS2utRyqCINA9ZihPEbFQ19/4kqSHNLeOIh8A+itzG7mmZq6LHpSUfaoZglG8+oi8UyYnXj0qyPhA5J2DHuB3Uywgkaz+TAsP04hhohYdwZ6Bb8LG0GxGr9wRanu135jAMytuel/Wjo9JYBDXWTaLslwohL+/JZe9dKMUeAph/Ye5rbnsJ998Al3DLWBAd2c6zsy21944epzj++6renFkTtHJGioGnELiKEp YMd2D6jk 4o4n+S6eH1agESwghuW9w5iUxHuQfLldPnmcMjiPpHTBFTJB7cwEYJzQcX6I6vv0eMt2R3Gbk9PiuUxYTOZWoGdIoAj4HwbHkFrFkZzxflWLpU/u+Cm7X0R1S3RR8xif7l8rA0CWm5PE/mHDszviMRVurtAJa5hkHI86sh3kRMCQVkDib5RwfdutQ9pN1sBvKR+MPxJREdKUlck4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/9/18 13:33, SeongJae Park wrote: > Hi Jinjie, > > > Thank you for this patchset! > > On Mon, 18 Sep 2023 13:10:43 +0800 Jinjie Ruan wrote: > >> The damon_region which is allocated by kmem_cache_alloc() in >> damon_new_region() in damon_test_regions() and >> damon_test_update_monitoring_result() are not freed and it causes below >> memory leak. So use damon_free_region() to free it. >> >> unreferenced object 0xffff2b49c3edc000 (size 56): >> comm "kunit_try_catch", pid 338, jiffies 4294895280 (age 557.084s) >> hex dump (first 32 bytes): >> 01 00 00 00 00 00 00 00 02 00 00 00 00 00 00 00 ................ >> 00 00 00 00 00 00 00 00 00 00 00 00 49 2b ff ff ............I+.. >> backtrace: >> [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368 >> [<00000000b528f67c>] kmem_cache_alloc+0x168/0x284 >> [<000000008603f022>] damon_new_region+0x28/0x54 >> [<00000000a3b8c64e>] damon_test_regions+0x38/0x270 >> [<00000000559c4801>] kunit_try_run_case+0x50/0xac >> [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c >> [<000000003c3e9211>] kthread+0x124/0x130 >> [<0000000028f85bdd>] ret_from_fork+0x10/0x20 >> unreferenced object 0xffff2b49c5b20000 (size 56): >> comm "kunit_try_catch", pid 354, jiffies 4294895304 (age 556.988s) >> hex dump (first 32 bytes): >> 03 00 00 00 00 00 00 00 07 00 00 00 00 00 00 00 ................ >> 00 00 00 00 00 00 00 00 96 00 00 00 49 2b ff ff ............I+.. >> backtrace: >> [<0000000088e71769>] slab_post_alloc_hook+0xb8/0x368 >> [<00000000b528f67c>] kmem_cache_alloc+0x168/0x284 >> [<000000008603f022>] damon_new_region+0x28/0x54 >> [<00000000ca019f80>] damon_test_update_monitoring_result+0x18/0x34 >> [<00000000559c4801>] kunit_try_run_case+0x50/0xac >> [<000000003932ed49>] kunit_generic_run_threadfn_adapter+0x20/0x2c >> [<000000003c3e9211>] kthread+0x124/0x130 >> [<0000000028f85bdd>] ret_from_fork+0x10/0x20 > > Nice finding! Could you please share just a brief more detail about above cool > output, e.g., just the name of the tool you used, so that others can learn it > from your awesome commit message? > >> >> Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests") >> Fixes: f4c978b6594b ("mm/damon/core-test: add a test for damon_update_monitoring_results()") >> Signed-off-by: Jinjie Ruan >> --- >> mm/damon/core-test.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h >> index 6cc8b245586d..255f8c925c00 100644 >> --- a/mm/damon/core-test.h >> +++ b/mm/damon/core-test.h >> @@ -34,6 +34,7 @@ static void damon_test_regions(struct kunit *test) >> KUNIT_EXPECT_EQ(test, 0u, damon_nr_regions(t)); >> >> damon_free_target(t); >> + damon_free_region(r); > > There is damon_destroy_region() function, which simply calls damon_del_region() > and damon_free_region(). Unless there is needs to access the region before > removing from the region, doing memory return together via the function is > recommended. > > And this test code calls damon_del_region() just beofre above > KUNIT_EXPECT_EQ(). Hence, I think replacing the damon_del_region() call with > damon_destroy_region() rather than calling damon_free_region() may be simpler > and shorter. Could you please do so? Sure. Thank you very much! > >> } >> >> static unsigned int nr_damon_targets(struct damon_ctx *ctx) >> @@ -316,6 +317,8 @@ static void damon_test_update_monitoring_result(struct kunit *test) >> damon_update_monitoring_result(r, &old_attrs, &new_attrs); >> KUNIT_EXPECT_EQ(test, r->nr_accesses, 150); >> KUNIT_EXPECT_EQ(test, r->age, 20); >> + >> + damon_free_region(r); > > This looks nice. Thank you for fixing this! > >> } >> >> static void damon_test_set_attrs(struct kunit *test) >> -- >> 2.34.1 >> > > Thanks, > SJ