From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EC3CC3DA42 for ; Wed, 10 Jul 2024 18:30:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 328206B0093; Wed, 10 Jul 2024 14:30:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D8846B0099; Wed, 10 Jul 2024 14:30:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 152316B009A; Wed, 10 Jul 2024 14:30:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E95E76B0093 for ; Wed, 10 Jul 2024 14:30:21 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 876D41201F2 for ; Wed, 10 Jul 2024 18:30:21 +0000 (UTC) X-FDA: 82324683042.23.F9EC010 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 4778C14002E for ; Wed, 10 Jul 2024 18:30:18 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OaHGAjFc; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720636187; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c/PZTGvWi1sY7TqVXDdMDOZplwNBIymfOsECaOJy86Y=; b=y+wJgIPcIIG/fCUtHG8WKR2imSKCic7GSCY4P4vMQZsg4Iz4A8K4megs79lSL/l5qxPEwH yDKLXnzjlithvEXKS2saIMCshSpNEcvwYIspUrUKyp4OJ36PptZTb8K/yeVbiT+dliSEjG OWKZIq+pUZn6wzheC+As28PnYcooO6M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720636187; a=rsa-sha256; cv=none; b=zVdHKC9g9IyLZL2X9KtFtqyBe5S977z/TjpsGY9ZtEeLsi6VHNpVCizc3z2be6HQWatrwv MZ4NZG8xhsigHJzcU+dKLnskdJT0N39ONK9euWNGwCOnDqj5jhwWOlYbo3JQHRPoeBMp+7 gJbHStkyTHXNGEe8ajpmWdM7f5UP7Xg= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OaHGAjFc; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720636217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=c/PZTGvWi1sY7TqVXDdMDOZplwNBIymfOsECaOJy86Y=; b=OaHGAjFcQ+7xjdcGuwguhIPQIFxjat+KuQ8v87AMGnkx2TyyR51skZ8usaFo7VPzbQm78D bC9vQ0Tzkrezj1KSXiIoxAKfhZYrWvpfLi7HD4QILaHpqHcxUftruynv0x2Mc5mVyf/EC/ OBecSV2nwgls5EEG+JGUM5QkvDCa9tc= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-KmW7vpqcP3-EovDE5JDHOw-1; Wed, 10 Jul 2024 14:30:15 -0400 X-MC-Unique: KmW7vpqcP3-EovDE5JDHOw-1 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-2c96cb48a8bso87887a91.1 for ; Wed, 10 Jul 2024 11:30:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720636214; x=1721241014; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=c/PZTGvWi1sY7TqVXDdMDOZplwNBIymfOsECaOJy86Y=; b=oNIGbSwqmcVexe/7l1B4L5M2jWiKBjnLaKLpJXjajxYbiD/mBY4AqXOFfR8iSoKxiM hYP8msljyDKCY9VzH10tOnqLXtcxm21hQEtfNZwRNU73ekbxMvz5kDNQVa7kxueZr7gH 3bJV+ZMmJsbWMTqtPJjmJByce/YPcquSvT1W0Og3/UjvT1GXd+Rv3bWFzCEY3QVkz1Dj zqqFiveMS7Tb6wvg8wX6//A+sfj2bQuKidpeQgdD1AMZyw+EGhqlT7fsh/zLMq84RiWP TWtwaWUc8L+CgyVT4ypS5kzGQGWYJYD0DeuhyxS4zZFtaNOih8Af1UmhESjwG2ZAgt3G 03qQ== X-Forwarded-Encrypted: i=1; AJvYcCUOAINHiTprJDO1G8T0aGP5mjB2bSkPzUd12woh57ejSsaXMMQLGk/tC80o2j5fEgt7tfRvYUfr5ZcPI/8OHBy/VVI= X-Gm-Message-State: AOJu0YzfcQDQ7AOXV7RhwO5fQo12Ywra/AuquITr6sxfhSumK/XQXkcP WglDPW8etMcsD5ptl+jQzVjSzNSf8nzfknoKfnpOlH5QKnHScV+64xd5Br76YSUIjUP0zHbIwF5 aSZ/cNRWcr5q9DICO8WC9Gc6T/Cg2pKkkAz5RdSm6+95fAFPg X-Received: by 2002:a17:90b:3a8a:b0:2c9:77d7:261c with SMTP id 98e67ed59e1d1-2ca35d5c8e7mr4972573a91.44.1720636213949; Wed, 10 Jul 2024 11:30:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGv3Dp71Ge6Ve++BKdXkUWp9zl+fE17KjUG7zmrHp6K85mGf3BI+DaCAyASlMPORQ2z/i+DEw== X-Received: by 2002:a17:90b:3a8a:b0:2c9:77d7:261c with SMTP id 98e67ed59e1d1-2ca35d5c8e7mr4972561a91.44.1720636213556; Wed, 10 Jul 2024 11:30:13 -0700 (PDT) Received: from [10.35.209.243] ([208.115.86.77]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c99a95197asm12291010a91.16.2024.07.10.11.30.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jul 2024 11:30:13 -0700 (PDT) Message-ID: Date: Wed, 10 Jul 2024 20:30:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: shmem: Rename mTHP shmem counters To: Ryan Roberts , Andrew Morton , Hugh Dickins , Jonathan Corbet , Barry Song , Baolin Wang , Lance Yang , Matthew Wilcox , Zi Yan , Daniel Gomez Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240710095503.3193901-1-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240710095503.3193901-1-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4778C14002E X-Stat-Signature: 16gwmp7uw986axa6biuredg84rqawkju X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1720636218-421082 X-HE-Meta: U2FsdGVkX1/Zr5J3QBc/pNbyLYgV9Xaf8/C6ZPQ1hYwtb88ZU9Svkl2w+jPnZac7zr4Hk6sDCYtUVVmTgx+HxX4fltfb45sAUPnNDykXIB0eNKv/rWQpMGOgOI9CK8AnDC6ufwZlEEjlwX4QV6pOmL9O0IG4VDgCt2jbnXdAkiHA6JymJr4qoSJGMcHjxsW3ENRrLXlj8puqQO7QN4rxFaNCRqCB6Q3LCif1ujv1pvlpP2c8m9o1Gyeme8KjkuvWbJGSEz6OiuVls+T3ytCuhg3dsv9LsllVzYmqjhdvxRDay+rsN8MQGoQpKfCrqTPKFZZTGFK4rp7RnbE392LxJgBaoEGzDjRIjykID4Drob0CibDj5jbd5PKSBvB0TpHFH6J13/jnQSyW95DW4s2YYca7cK0ypG0jEdLPjZ5BkQbvPB7KEzeTOVg9dr1plVZ1kvTVLhs6kIHeS41AwOqln+BA4zHkAvyudLmWASZhd2V9Nb0MX0NzgJHEAztkH9fT+wAPo2HPqh2hHpM4RYYdx85glfC0jzZTquskGKnoxlTe3gToyAa1Mkp/6X7HZlPTo17XJE2ziFC/cnU5XejCV0vv3hH3FeR0qpmeD+RrJZfRH2Pg1sc5yG3gFy5HKRlQLYBy0E4vKoq+AuXhX55+n4HaTecBtSnPvCLA4ZWyCo+0FiIdMLmaK14LkGZFDXLg3C65qEAmcjxbZloBSO3yjqRaSmmGtHwmC2sZben9yz3HVbbqtm7KH3HmqwqsWRhuCjC21kajCShd/aEgUuWahuRR0q4mjy3aRklUkXKRd2OgqlF3FoQW4ZXjLIVkv0NWaVQ4g2V1aCZ3BWhxG9FLGv/VqzW5nK2kJ2EKNmcX8olRuK6njeH8jeo8cQev3uHeuHyE8IpSFmIEDUneY4Q+CZBAd+cSMXu8qHexFS/olyAlAlXHh72eaAXeRCFvEjICcfkb2pJuxo08MchlVYw 6icpinJr vvvqlvCPKfIIMcYb+WDDDrDXKtayIBCrOzUeEgmOEL9LCMV91YJgbxhNW7fWpQ1zmpjwC6FbuG9+qwjDDcmN/baK7I1M+UdCvLGT5xQVEmBgpFmAHvN+YJ+fUMAU+oj1lD0YkS+UIqOlSm2mXKmj3D0xDkuqViFJC79/UAr3rdxW10n2Lpc6EDSv2/RBZElPXAcn71J9XTYM99m3Urns03f18ej+sq5mTYZFcD5eWSrhqoREao1tXJdTBuKLZ4EGfQH7U89mnW2sXMrvh7Z+6ZsKK1plPALS4aex0uQn0ol/aSsSUIvRnt0oh8Pq4+j3yLytFLVBA0lL5Eq3xVLQd6EyMJsVKEcIKgx+2PdU7Cbnz7G/WYT2wUL4jSPrPqCcBage+fxYn7C+IMHNRjnqdr8rs2jyhkIwA+DJDmvPJwlmkOenGytoLmqlLbTcHySgefpGL84AWTAjn8MvV3OZr/67iZ1bZ2UrccSP+4W12bRGq8cHYe7SYntnWQ7mH6DhnSi1TDOaVD3Z+kOE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.07.24 11:55, Ryan Roberts wrote: > The legacy PMD-sized THP counters at /proc/vmstat include > thp_file_alloc, thp_file_fallback and thp_file_fallback_charge, which > rather confusingly refer to shmem THP and do not include any other types > of file pages. This is inconsistent since in most other places in the > kernel, THP counters are explicitly separated for anon, shmem and file > flavours. However, we are stuck with it since it constitutes a user ABI. > > Recently, commit 66f44583f9b6 ("mm: shmem: add mTHP counters for > anonymous shmem") added equivalent mTHP stats for shmem, keeping the > same "file_" prefix in the names. But in future, we may want to add > extra stats to cover actual file pages, at which point, it would all > become very confusing. > > So let's take the opportunity to rename these new counters "shmem_" > before the change makes it upstream and the ABI becomes immutable. While > we are at it, let's improve the documentation for the legacy counters to > make it clear that they count shmem pages only. > > Signed-off-by: Ryan Roberts > Reviewed-by: Baolin Wang > Reviewed-by: Lance Yang > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb