From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 125DAC636CC for ; Tue, 31 Jan 2023 16:04:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F5B36B0075; Tue, 31 Jan 2023 11:04:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A6616B0078; Tue, 31 Jan 2023 11:04:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 894D96B007B; Tue, 31 Jan 2023 11:04:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 786876B0075 for ; Tue, 31 Jan 2023 11:04:46 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2955D1A0762 for ; Tue, 31 Jan 2023 16:04:46 +0000 (UTC) X-FDA: 80415567372.15.85FB65B Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf14.hostedemail.com (Postfix) with ESMTP id 817DF100020 for ; Tue, 31 Jan 2023 16:04:42 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=mwyaDxKJ; spf=pass (imf14.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=reject) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675181082; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q6/Fny10q5HNMTRUYA+MSwxWc7yc79jg9sgYFcqfSOM=; b=hjf3r3qAW2Cp1CBgTdB1xqeSnVXr+ZTjOYK8S83ibS+1ioyMN0rPpQJLkWKpzVLymVcat9 1x4EsSBKojUd/4ZTLzY7xXCCphSee3nv+8tKOzV0kt3+zf22a8wt7GQqvLFoKLDz8vubUJ A6/dcRpeaD6j4UkwwfHmaAwh3bxDHNQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=mwyaDxKJ; spf=pass (imf14.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=reject) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675181082; a=rsa-sha256; cv=none; b=2lWaPrdqWpPwkb/aHLX8OuYlHEcS85GczPKHVkQBuCeYgxsTG45zHjg5cQsXefk8apvXmq Rl22HegqXVI7y7QwuyWZJhI6qxaR9VnkA/1M5kumdbP/66soANfdeH2JKUYJqcZ9LJ6mCh zqZIU4ViSyHWSIH4SDqblxSmd4FfnxA= Received: from [192.168.10.12] (unknown [39.45.165.226]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: usama.anjum) by madras.collabora.co.uk (Postfix) with ESMTPSA id 1817E6602EBA; Tue, 31 Jan 2023 16:04:30 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1675181080; bh=bWKosL3FqQvGKVbLtHwh+SviC5G8f7DqaNQ3HiK29gg=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=mwyaDxKJAgsiN57aH1NG+118IRW4nXqfCENped3PNLTVXscFLnCORdHU0Y7018s7e a/xzkXGtIHGAUNgO92cQeor2oHe1iEjqRos1cyJficaxPOxybgB/Bjhe0dPuW34Ojv RfCkTGF9ARvcNY02mCp8+ScZ37tkKNUjN3earw5U5qAt14LGzgw04cjRxx3vETcpyZ fniY/yXMn+IR7xGkfAsUXwQlv23+37inwe6p7QcVaLxUy+32ig754ma4g7Bey4C9GK /iTCphurFTH3Yge6p0oZDKvFe0WqqDdGrUEcjV8xRlYU8CF7wMDkT66ORWpS+w7SKF C8TcyeBZH42KQ== Message-ID: Date: Tue, 31 Jan 2023 21:04:26 +0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Cc: Muhammad Usama Anjum , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Mike Rapoport , Nadav Amit , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, Greg KH Subject: Re: [PATCH v9 2/3] fs/proc/task_mmu: Implement IOCTL to get and/or the clear info about PTEs Content-Language: en-US To: kernel test robot , Peter Xu , David Hildenbrand , Andrew Morton , =?UTF-8?B?TWljaGHFgiBNaXJvc8WC?= =?UTF-8?Q?aw?= , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov References: <20230131083257.3302830-3-usama.anjum@collabora.com> <202301312359.8WtBkSkQ-lkp@intel.com> From: Muhammad Usama Anjum In-Reply-To: <202301312359.8WtBkSkQ-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: d7yh9s8198sdo1crud1439ai9ifo9eis X-Rspam-User: X-Rspamd-Queue-Id: 817DF100020 X-Rspamd-Server: rspam06 X-HE-Tag: 1675181082-480676 X-HE-Meta: U2FsdGVkX19eN+k79AkZ7cWYghQo79ApemR4iJPLirzc3XKVtORoJLjt6qpsOuFVKa8uE4Y31IytLI4tFaQn3O0HKJWhHbn53VFFol+wMJju6lGxmLnceR1q66erk8hgmZTVcHEaDaGD/iGiYoWYO8DE6sOVPaF+njF3Th7CpprYFypyvnxX1Tz4ex+ZVn6sLR2k9a+/zMWaiSjgY061u8h20IL5nJOLsuOp3wnNkiKVaHYX9fkjexlJ035GI7NU1UiLNwpixMF73zgFGi/+a/CVINr8mYxFu9yavTylQ0S9ZmNNbsTlf4PbSQuyxMRmAcXAhhaLWILEK7F4Ejw8nEgnuOFH2ZwRSdZFDdr5un3meBf0WyUEMTCm7ctyCVvg4SPDc/8z3ptyLuVqpdtsEvXyBibnITveNUVleW9s1IZuqJ6ERmAz38GVTOA5sbBuhJ2CE0+txatTJT3fdePwl/5yIptwgSPNcYIj9k1WiugZJsSmktRfU59A2HPVMZxp2i0Qc+Zdngo0RGkAXiHMkK46oN126x/Sd0h/TUKFHDGHFwzD/btS1c03Loz9ZWq5u3RruLQn+qhNLEzFpZ70HGnSGdcu/ydp6DNWNXcyZuvDr6ILCt5xoGQdFEBIi+gPP/Ehua0D4TR9DvUBbDhi6vTrvOKaLrXKoFXZOTpUhMTeIMLdU4sNhV88EJjRPly0PslKkCgtKgqj411dgQ7ra7QHha5QEFgFxh6WEB+STwqr2pmeT+f+CrR+YJGYLKZ5G7c0YSIj/fsAkahtRDIOee+RdpaTkW+oyHxo1b81FAzRGQzi01YCA7e0FN7dst9SwcRJF5eQ0xBsnyxALS3Jg80gAzIcaKcPhMKp9qPTxTRObHr/1k42GswPoxOVvRm01vQcr8gAtAbKLh2Kvv7h3r6J+nqtyWLXYx8pJHYXa7XZw9h9ZzHFLD/0oIKObN5WRNTR5Xl6PcxEoJvuL2G tKmkngpB 9h5YL95TYfAW62B0wv/5CHFlfQ5oIv2lVrEgFHvtQrbXG4c5KCcZzpgBbCY2tC6YTVWVhA9G+X6nrqsz2+yopUgAIq3bRPYd+n9Q1AR4kZRnbMus2AV+OhmC6tbNy5UbCaiFklLxHUFDywAN5RvcqeLJhwwREM9ySUgcxyaMVZGBZONGJ9n+ceIi3QsCPQsXzdHo9Op/+lPhcj1iuBzdfI5XtC7C/1fIw/I8vuEXk7FLAFp5U6WMg9QLe53uE8ZdEirGFkf5y3ESnlmnIo4CYXBLQ4URKM5NW6BEcBT01XOA7IEjZ4CuLERMYMLPRXNufbsHrKsIz7BXm9ijuFcAKMQNIRk6+V89uOTmu+MUyz7W25nRStdNafdiRdv2/fjt+Xx7DenBeXiPiySkINdKknBnVRhFyFXRbX9uWZ+ASK7nwAxZFIzTBgu+8c5Oq9db4Qh48sWY6L9OnBz1sYngY1gp6dMwj6EtUdqDWEUo3UaRqup4a0a2I6HLfvRUzInSe7GwxPrbTt2yGfHkhUYjiOizK5PSonFKsgZiabfZt5Rru7Zsm+YZxveCplzAi9i+c/LNe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/31/23 8:52 PM, kernel test robot wrote: > Hi Muhammad, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on shuah-kselftest/fixes] > [also build test ERROR on linus/master v6.2-rc6 next-20230131] > [cannot apply to shuah-kselftest/next] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Muhammad-Usama-Anjum/userfaultfd-Add-UFFD-WP-Async-support/20230131-163537 > base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git fixes > patch link: https://lore.kernel.org/r/20230131083257.3302830-3-usama.anjum%40collabora.com > patch subject: [PATCH v9 2/3] fs/proc/task_mmu: Implement IOCTL to get and/or the clear info about PTEs > config: arc-defconfig (https://download.01.org/0day-ci/archive/20230131/202301312359.8WtBkSkQ-lkp@intel.com/config) > compiler: arc-elf-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/intel-lab-lkp/linux/commit/11677b6b7fda958031115ea40aa219fc32c7dea4 > git remote add linux-review https://github.com/intel-lab-lkp/linux > git fetch --no-tags linux-review Muhammad-Usama-Anjum/userfaultfd-Add-UFFD-WP-Async-support/20230131-163537 > git checkout 11677b6b7fda958031115ea40aa219fc32c7dea4 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > fs/proc/task_mmu.c: In function 'pagemap_scan_pmd_entry': >>> fs/proc/task_mmu.c:1927:17: error: implicit declaration of function 'uffd_wp_range' [-Werror=implicit-function-declaration] > 1927 | uffd_wp_range(walk->mm, vma, start, addr - start, true); > | ^~~~~~~~~~~~~ > cc1: some warnings being treated as errors I'll fix this by adding the following patch in next version: --- a/include/linux/userfaultfd_k.h +++ b/include/linux/userfaultfd_k.h @@ -190,6 +190,11 @@ static inline vm_fault_t handle_userfault(struct vm_fault *vmf, return VM_FAULT_SIGBUS; } +static inline void uffd_wp_range(struct mm_struct *dst_mm, struct vm_area_struct *vma, + unsigned long start, unsigned long len, bool enable_wp) +{ +} + > > > vim +/uffd_wp_range +1927 fs/proc/task_mmu.c > > 1915 > 1916 pte = pte_offset_map_lock(vma->vm_mm, pmd, start, &ptl); > 1917 if (IS_GET_OP(p)) { > 1918 for (addr = start; addr < end; pte++, addr += PAGE_SIZE) { > 1919 ret = pagemap_scan_output(!is_pte_uffd_wp(*pte), vma->vm_file, > 1920 pte_present(*pte), is_swap_pte(*pte), p, addr, 1); > 1921 if (ret) > 1922 break; > 1923 } > 1924 } > 1925 pte_unmap_unlock(pte - 1, ptl); > 1926 if ((!ret || ret == -ENOSPC) && IS_WP_ENGAGE_OP(p) && (addr - start)) >> 1927 uffd_wp_range(walk->mm, vma, start, addr - start, true); > 1928 > 1929 cond_resched(); > 1930 return ret; > 1931 } > 1932 > -- BR, Muhammad Usama Anjum