From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B611C4338F for ; Mon, 16 Aug 2021 08:04:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C60C561AEF for ; Mon, 16 Aug 2021 08:04:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C60C561AEF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5E4BE8D0002; Mon, 16 Aug 2021 04:04:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56EAC8D0001; Mon, 16 Aug 2021 04:04:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40E6F8D0002; Mon, 16 Aug 2021 04:04:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 245588D0001 for ; Mon, 16 Aug 2021 04:04:21 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B1648181AEF2A for ; Mon, 16 Aug 2021 08:04:20 +0000 (UTC) X-FDA: 78480206280.33.CEE034A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 60A1C702614B for ; Mon, 16 Aug 2021 08:04:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629101059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qRgugS5R33xzA7Rkgh8EjnbwTLS/bf85VMWTo3kT5R8=; b=Huq6XSg8h0FU7uCnfMQiSVu74n0f87QsGzJGCuZBMaYGn5f1i8vGV+Wlkzw1OkL4ZZbX3K gtvjZ3Iz0jOvg5Q7BLIoChv+H+iTQhoqwaQYuuqqgbtbrg9q0H+Hz7ujgRT+hIlGQnmdmv micH6qa7eOagG2DmcXGDRKmhTPfTqho= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-572-gVNJc_z2OQaFBc0wHf-3Mw-1; Mon, 16 Aug 2021 04:04:16 -0400 X-MC-Unique: gVNJc_z2OQaFBc0wHf-3Mw-1 Received: by mail-wr1-f69.google.com with SMTP id x18-20020a5d49120000b0290154e9dcf3dbso5191587wrq.7 for ; Mon, 16 Aug 2021 01:04:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=qRgugS5R33xzA7Rkgh8EjnbwTLS/bf85VMWTo3kT5R8=; b=PcfVvsOOFkwmOdD9FIbM1fx+5AbULVIJVq7v6BKrpM8osLRAkBEbgv9OvpiPZXpAo2 rzL/TuSp/Y5im4DCgnJYu8ZfIkLPWCSNon5CSY8poPT2SmCr6pCQzePgZRiPQtZrLBIJ WhBLpO1y4rilKjBKFQ8so8J7dNhYv/kvKWIoKGobr7MiyAXpBOLpr3+frtqHZFaEqubM NWbNjTVtJKLuSGS/T1Y76nfxdp4LLOjrlwzLKpFM1ludl8a8xItbOiYeDPz1qSNduUxW Wo0+AY6GqicIym7lw+zYgt7Lx7s0v178v2oFhI9t+YlcupYiwp2kzlOhFTg4jzFT7FoV RQ1w== X-Gm-Message-State: AOAM530OxRnNhrXaueMInyseNRwTDVMYvX/zMFrDY62UvIwuh+hsTh0B R67k54h+ztv4T5K1gugCVZ8/2WizP9LI8HhT4Snc9b7aPMT4K6hhSXVTpzgKGA8S9Qy+OtJdNs1 qTkQiOMIhnrA= X-Received: by 2002:a5d:4ec4:: with SMTP id s4mr17120166wrv.245.1629101055010; Mon, 16 Aug 2021 01:04:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjWXBAShNHSs++OvRlLvJnRG/VG4/LYlwCfEbIyWeSad1G5UzbxaoCgVNvJe0fSBDpGK2NKg== X-Received: by 2002:a5d:4ec4:: with SMTP id s4mr17120146wrv.245.1629101054824; Mon, 16 Aug 2021 01:04:14 -0700 (PDT) Received: from [192.168.3.132] (p5b0c67f1.dip0.t-ipconnect.de. [91.12.103.241]) by smtp.gmail.com with ESMTPSA id b13sm10670911wrf.86.2021.08.16.01.04.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Aug 2021 01:04:14 -0700 (PDT) To: qiang.zhang@windriver.com, vbabka@suse.cz, akpm@linux-foundation.org, sfr@canb.auug.org.au Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210816074605.30336-1-qiang.zhang@windriver.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH] mm, slub: add cpus_read_lock/unlock() for slab_mem_going_offline_callback() Message-ID: Date: Mon, 16 Aug 2021 10:04:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210816074605.30336-1-qiang.zhang@windriver.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Queue-Id: 60A1C702614B Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Huq6XSg8; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf27.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam04 X-Stat-Signature: wtmt6bo41jzx1bixytt9qnf9jimzwihn X-HE-Tag: 1629101060-162400 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.08.21 09:46, qiang.zhang@windriver.com wrote: > From: "Qiang.Zhang" >=20 > The flush_all_cpus_locked() should be called with cpus_read_lock/unlock= (), > ensure flush_cpu_slab() can be executed on schedule_on CPU. >=20 > Fixes: 1c84f3c91640 ("mm, slub: fix memory and cpu hotplug related lock= ordering issues") Which branch contains this commit? At least not linux.git or linux-next > Signed-off-by: Qiang.Zhang > --- > mm/slub.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/mm/slub.c b/mm/slub.c > index 5543d57cb128..cf3f93abbd3e 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -4593,12 +4593,14 @@ static int slab_mem_going_offline_callback(void= *arg) > { > struct kmem_cache *s; > =20 > + cpus_read_lock(); > mutex_lock(&slab_mutex); > list_for_each_entry(s, &slab_caches, list) { > flush_all_cpus_locked(s); > __kmem_cache_do_shrink(s); > } > mutex_unlock(&slab_mutex); > + cpus_read_unlock(); > =20 > return 0; > } >=20 Memory notifiers are getting called from online_pages()/offline_pages(),=20 where we call memory_notify(MEM_GOING_OFFLINE, &arg) under=20 mem_hotplug_begin(). mem_hotplug_begin() does a cpus_read_lock(). How does this even work or against which branch is this? --=20 Thanks, David / dhildenb