From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CA51C432BE for ; Wed, 1 Sep 2021 17:49:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 937FD61027 for ; Wed, 1 Sep 2021 17:49:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 937FD61027 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 316038D0005; Wed, 1 Sep 2021 13:49:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C6658D0001; Wed, 1 Sep 2021 13:49:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 140AC8D0005; Wed, 1 Sep 2021 13:49:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0190.hostedemail.com [216.40.44.190]) by kanga.kvack.org (Postfix) with ESMTP id 03D6F8D0001 for ; Wed, 1 Sep 2021 13:49:31 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9F97518226CF8 for ; Wed, 1 Sep 2021 17:49:30 +0000 (UTC) X-FDA: 78539741700.13.161583A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 47FEC50407B4 for ; Wed, 1 Sep 2021 17:49:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630518569; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wcSS0stjCZ+EufNjuLhGnQ5APuKOPn6/83B2E8zhIVk=; b=hUQo9ZkiC9HyLZh9jzqLz4vh3qzKlzFR+qh6jd+2YrVq9Ldq8kLVSb5V25Zo/1dEy+0lxz pu/tEWZDviEyjwXRtUIMZTDY3WQ9QJm7lqtzT+qOdSdsH+r6XoN8j6ID9dDPEU0qn3UXEu EYtvkijdULb6M1YMKwTwcQfd5Fa+qLY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-517-TV65HrhpMRC0nIYO0C9cwQ-1; Wed, 01 Sep 2021 13:49:26 -0400 X-MC-Unique: TV65HrhpMRC0nIYO0C9cwQ-1 Received: by mail-wm1-f71.google.com with SMTP id p5-20020a7bcc85000000b002e7563efc4cso107892wma.4 for ; Wed, 01 Sep 2021 10:49:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=wcSS0stjCZ+EufNjuLhGnQ5APuKOPn6/83B2E8zhIVk=; b=m5dukRxLOqDqlLh92+sHcIFWKiuD9i/n259Lk81Os35dEeuTOk4Zt6mfEWwLvPZ2EB Wq+cnVpnRJvlhGEgIas4oU8wMfXfLlI8kHUPGCtzv4UteS5bhPO7riyDqzsiCFOY5vlz QPvfJKbA3TfE1D+XUlk/3xta1Qaf7QOQO8IAZNZKH4KdESLmnmbuy/WyiaFF9NYXoa+g mQPDSi7+rCc/vtdwbNfId3OHNFXoxVyLZZnBl3i7aHYrvdAC40lhWKwVW7pBm2APlyzv BmTkcnGgmHg2XIMfMb5KKm4oNFWFf1fOgb+LU7t6tx39WQ4OyUuSIIGtND7cvv4Qp2wv g0XA== X-Gm-Message-State: AOAM53171Y4jaLDo4GyOYHTX0hRpD9W+iQ9275HKh+jGIa0b+9GNgoel LWi2SaIwpop3uZyWE6Tpev10rl32iWXAB5UPz+lqsF51OtdeT66S5pL1ozuC9n+ER1IrPVTN0Rr aqf1wXwMOg5M= X-Received: by 2002:a1c:19c6:: with SMTP id 189mr717982wmz.174.1630518565343; Wed, 01 Sep 2021 10:49:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/NrrsbhKylVigxv7rpdncN0pJ4zbcVXVZJsfupW2ppJ5IrimVhHTvVn8Y5YEQ7YGxyE6BKQ== X-Received: by 2002:a1c:19c6:: with SMTP id 189mr717962wmz.174.1630518565124; Wed, 01 Sep 2021 10:49:25 -0700 (PDT) Received: from [192.168.3.132] (p4ff23f71.dip0.t-ipconnect.de. [79.242.63.113]) by smtp.gmail.com with ESMTPSA id q11sm192401wmc.41.2021.09.01.10.49.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 10:49:24 -0700 (PDT) Subject: Re: [PATCH v2 6/9] mm: free user PTE page table pages To: Jason Gunthorpe Cc: Qi Zheng , akpm@linux-foundation.org, tglx@linutronix.de, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, kirill.shutemov@linux.intel.com, mika.penttila@nextfour.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, songmuchun@bytedance.com References: <20210819031858.98043-1-zhengqi.arch@bytedance.com> <20210819031858.98043-7-zhengqi.arch@bytedance.com> <20210901135314.GA1859446@nvidia.com> <0c9766c9-6e8b-5445-83dc-9f2b71a76b4f@redhat.com> <20210901153247.GJ1721383@nvidia.com> <7789261d-6a64-c47b-be6c-c9be680e5d33@redhat.com> <20210901161613.GN1721383@nvidia.com> <20210901171039.GO1721383@nvidia.com> From: David Hildenbrand Organization: Red Hat Message-ID: Date: Wed, 1 Sep 2021 19:49:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210901171039.GO1721383@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hUQo9Zki; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf05.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 47FEC50407B4 X-Stat-Signature: 6dhsg5uu8nbrg6npsnzb1giono5wmn14 X-HE-Tag: 1630518570-822731 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.09.21 19:10, Jason Gunthorpe wrote: > On Wed, Sep 01, 2021 at 06:19:03PM +0200, David Hildenbrand wrote: > >>> I wouldn't think it works everywhere, bit it works in a lot of places, >>> and it is a heck of a lot better than what is proposed here. I'd >>> rather see the places that can use it be moved, and the few places >>> that can't be opencoded. >> >> Well, I used ptep_get_map_lock() and friends. But hacking directly into >> ptep_map_lock() and friends wasn't possible due to all the corner cases. > > Sure, I'm not surprised you can't get every single case, but that just > suggest we need two API families, today's to support the special cases > and a different one for the other regular simple cases. > > A new function family pte_try_map/_locked() and paired unmap that can > internally do the recounting and THP trickery and convert the easy > callsites. > > Very rough counting suggest at least half of the pte_offset_map_lock() > call sites can trivially use the simpler API. > > The other cases can stay as is and get open coded refcounts, or maybe > someone will have a better idea once they are more clearly identified. > > But I don't think we should take a performance hit of additional > atomics in cases like GUP where this is trivially delt with by using a > better API. Right, but as I said in the cover letter, we can happily optimize once we have the basic infrastructure in place and properly reviewed. Getting rid of some unnecessary atomics by introducing additional fancy helpers falls under that category. The performance hit shouldn't exist if this feature is not compiled in. -- Thanks, David / dhildenb