From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED61ECD1283 for ; Mon, 1 Apr 2024 09:48:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F1616B0089; Mon, 1 Apr 2024 05:48:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A0F16B008A; Mon, 1 Apr 2024 05:48:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 669426B008C; Mon, 1 Apr 2024 05:48:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 487DC6B0089 for ; Mon, 1 Apr 2024 05:48:09 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CD3EFA0603 for ; Mon, 1 Apr 2024 09:48:08 +0000 (UTC) X-FDA: 81960487056.18.5D6775D Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf25.hostedemail.com (Postfix) with ESMTP id 14ECEA000A for ; Mon, 1 Apr 2024 09:48:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=IKkpukb8; spf=pass (imf25.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711964887; a=rsa-sha256; cv=none; b=4Qg7M1jio0/7bdHIFXFIhDh5txgc20RmdzLEbsyAPtO+DmNB+yqYaYYmaKmwBi8p7z9+3M wToLKGzQHUaMhv+61973jwfVwNwl5BKwq7hC0hk05HAGUt3BgbEjLjNZofreZMEtG8SrHY SFlgmvTsMvA9SfkdQoEBZnoquPslMqI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=IKkpukb8; spf=pass (imf25.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com; dmarc=pass (policy=quarantine) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711964887; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ztu2FvgPGsMIM9MGAhUC5Pglx6IH/1lc7B3TQ59R8vk=; b=YC2c2iYFwqvKBfyLBUYjYK1SiSVJKFEJNdPosTbor6Vq7hW2uKvCMo/ADxtGsg1mFjq0pt Wx9qOF2SJGtF0glVWTj+DrarER03n/Q9mbufZIiA2lGRce4sZoEs8IYpc2guJigRtN6k+a 0H6TdpBOZEYOECFRSJ2vyL2HmG6erFg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1711964885; bh=06wOk/U0MualMJ4bunj44L58B9nb+s9Iaqf0BY9Iihk=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=IKkpukb884sj8Eg4Yw/1yM6F+jVI41WbIFR5wppl38DPIFzg7d+snPhJSh90a3YbB 6UxRTezpSmT4wNQmWC70hAfP/JxH0Ch921mvOmRMG6ao7uQPIuZ7OsFD7KR2aH5N87 tG0r+nrikfEXbQvrvlxX1XWEKAWH5gay7UPdFl6DDuIhYIr3WnRTZy/d4En7a/hkhB ryU3/OINHUKgVPtbeLhy24Ru35rCA0iPfjdVytimtX+uverHEJe3H4njiECn3UAPIe pNY86YqfqdyTKZh6NivIn+8POtsgH3Jxd+ULYNYtQQqgOUeGD7ZqZngxjW5K5IDaXk qoDfDq7BJ5Z5Q== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 8BFC2378148F; Mon, 1 Apr 2024 09:47:23 +0000 (UTC) Message-ID: Date: Mon, 1 Apr 2024 14:46:13 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , paul.walmsley@sifive.com, rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr, bjorn@rivosinc.com, alexghiti@rivosinc.com, samuel.holland@sifive.com, palmer@sifive.com, conor@kernel.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, corbet@lwn.net, tech-j-ext@lists.risc-v.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com, shuah@kernel.org, brauner@kernel.org, andy.chiu@sifive.com, jerry.shih@sifive.com, hankuan.chen@sifive.com, greentime.hu@sifive.com, evan@rivosinc.com, xiao.w.wang@intel.com, charlie@rivosinc.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, dbarboza@ventanamicro.com, sameo@rivosinc.com, shikemeng@huaweicloud.com, willy@infradead.org, vincent.chen@sifive.com, guoren@kernel.org, samitolvanen@google.com, songshuaishuai@tinylab.org, gerg@kernel.org, heiko@sntech.de, bhe@redhat.com, jeeheng.sia@starfivetech.com, cyy@cyyself.name, maskray@google.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bgray@linux.ibm.com, mpe@ellerman.id.au, baruch@tkos.co.il, alx@kernel.org, david@redhat.com, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, shr@devkernel.io, deller@gmx.de, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com Subject: Re: [PATCH v2 27/27] kselftest/riscv: kselftest for user mode cfi To: Deepak Gupta References: <20240329044459.3990638-1-debug@rivosinc.com> <20240329044459.3990638-28-debug@rivosinc.com> <4b38393a-f69d-4a77-a896-b6cd42c7edcf@collabora.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 14ECEA000A X-Stat-Signature: m5kwcsp4o6r55rf6e3rsfpt8mu9bfr5i X-Rspam-User: X-HE-Tag: 1711964886-467740 X-HE-Meta: U2FsdGVkX1/5Wurr7+F1LrH5P5DOIWVXIbgOKkAYpEn4SSRuwbQaGKrGQQkxDCh73SQ56Ofdws7Hqx0yGyrqY4imdx4LQmk9mvFJwFtyAWLA2C3fv8SBVDUUtZTiJ4JF3NNNcpDd8Qd1aMHJQb6NC9rhHN+gK13kdwj8/T4dId4saS2mmf4Sbt4AOF1e2X/Xa2i6smAlSL/m6ef5g8l+0Glh0SMF0CfGFW1o9bcCY+XGXLILwTCdov20BULsmN9a2ZK3oDTfSkKmFJx4sPn1ZE/ABw3/V605P5MtaMMUsnvGNJGCtlPA5dgoMhTbrR9znzLcDhDyyWrBcB1JtGOeO6rqFHhuCBNoHpwNFRmFikBQx0E03hEqcudsJL7OWq90bqQGZ2NolZy/V5VYHAzg0UWL4/pMeSj/mKGHYF2yG1C76zXIIgdC6EnoutVB583XEP1o6Zmn6DMk7N18evh4VUhIPC8cpoxCYWT+Pww2vnL9zG/YpqS+sxI8vsRPqqeUrwiQi64BuE8Z2awRSIMYfnRcDvDWbWy3+oQBZkNhQ9L6SZyE9bOimDm8+V5wTHIXQYKY7ux96svk8neDdNRF7DNux8RbIohAS9OGI+x0tk51f2r54C6bc5KHOXSVD7aIQj1+88u+kph+IR35UNiI0emWbQci8DiLzryfAKZTl0YTjnkcr0YejAWMXneGtmzsn9nHVI7x+BMNV4gCxGP6bcxzdAjncXJVi4hX82TAH5TV/ujkLO8Z/S6525pRplzZBn4N4HVepmhPC14N7WUmQkQi8PtHAAb7OgyJ2H1XlSRX5mYZmxhvHpD5YQXD8ucUGv47NrxWLoyRb+CPDgvY7YTWtJegX+2zLqOQddokAaeO5a3IaTshNbFEJH8H6EvJbDAvsYGkoWlasgY/XK0yKyxH/8JNKlwnR3phhNpe5BQI011KXuC+ulYHmXMpIQr+hwRqpx8+fL8cIbOeKXZ oaXAK7CI cdD3b5ggaB6rVAv12aP3j9nXohycvCQBPhDIVjVLwoikkdyg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/30/24 1:02 AM, Deepak Gupta wrote: > On Fri, Mar 29, 2024 at 12:50 PM Muhammad Usama Anjum > wrote: >> >> On 3/29/24 9:44 AM, Deepak Gupta wrote: >>> Adds kselftest for RISC-V control flow integrity implementation for user >>> mode. There is not a lot going on in kernel for enabling landing pad for >>> user mode. Thus kselftest simply enables landing pad for the binary and >>> a signal handler is registered for SIGSEGV. Any control flow violation are >>> reported as SIGSEGV with si_code = SEGV_CPERR. Test will fail on recieving >>> any SEGV_CPERR. Shadow stack part has more changes in kernel and thus there >>> are separate tests for that >>> - enable and disable >>> - Exercise `map_shadow_stack` syscall >>> - `fork` test to make sure COW works for shadow stack pages >>> - gup tests >>> As of today kernel uses FOLL_FORCE when access happens to memory via >>> /proc//mem. Not breaking that for shadow stack >>> - signal test. Make sure signal delivery results in token creation on >>> shadow stack and consumes (and verifies) token on sigreturn >>> - shadow stack protection test. attempts to write using regular store >>> instruction on shadow stack memory must result in access faults >>> >>> Signed-off-by: Deepak Gupta >>> --- >>> tools/testing/selftests/riscv/Makefile | 2 +- >>> tools/testing/selftests/riscv/cfi/Makefile | 10 + >>> .../testing/selftests/riscv/cfi/cfi_rv_test.h | 85 ++++ >>> .../selftests/riscv/cfi/riscv_cfi_test.c | 91 +++++ >>> .../testing/selftests/riscv/cfi/shadowstack.c | 376 ++++++++++++++++++ >>> .../testing/selftests/riscv/cfi/shadowstack.h | 39 ++ >> Please add generated binaries in the .gitignore files. > > hmm... > I don't see binary as part of the patch. Which file are you referring > to here being binary? shadowstack would be generated by the build. Create a .gitignore file and add it there. For example, look at tools/testing/selftests/riscv/vector/.gitignore to understand. > >> > -- BR, Muhammad Usama Anjum