From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1F87C43334 for ; Tue, 21 Jun 2022 07:20:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5A1F08E0002; Tue, 21 Jun 2022 03:20:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 552106B0074; Tue, 21 Jun 2022 03:20:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 418408E0002; Tue, 21 Jun 2022 03:20:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 328686B0073 for ; Tue, 21 Jun 2022 03:20:04 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 01347332FB for ; Tue, 21 Jun 2022 07:20:03 +0000 (UTC) X-FDA: 79601393928.29.937F5FE Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf21.hostedemail.com (Postfix) with ESMTP id A80201C00B4 for ; Tue, 21 Jun 2022 07:19:59 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id w9so5333008lji.4 for ; Tue, 21 Jun 2022 00:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=5BtOB1xQhN3Ha4LlKucv6D1ctcTjHBCQ1Tbc7a6of4E=; b=TKmlBWKSf8Jf8np6blHHUe6nVaX0uPVSfRFhasrZwmd39FDSNZl4XaFeCsICHLe4pe 3iOJppArYeaDr2n/QMIizqb+wkXnDzvlBOu764SDa08phIvvR0BisPlPrIGCXIVdWjaF 9hJOf3de+mMSi/wW2M72YQSCDX6/H5o3mF1TA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5BtOB1xQhN3Ha4LlKucv6D1ctcTjHBCQ1Tbc7a6of4E=; b=flnCMwlXZYEcHFJTdmTF4CySq2KlF4ZWlqKhZ2PYbiAEj6tlS1Kkmet+RieDsZQzWT isUzQqKWytkOtB0H0PqsYfDe1LPXgOPGWMuzOxYKGko9PFnGlIPvhwoCd+DTQlws5Ydj USZuHilsVJp0HP/jPgcyVzMfGasSALcJLBfGOTb6nXPbVIvJNO9Vc86e5am+ffAt337e zvxilPnFxFbV85xpNQ8m0UARqEmB8jKoHBIHU1Yularkcxxas9Nrrv55rRqt+CyKNT7r te3+IVx4LkGPjxAQvJDB8yrSj7smnWaDk6PUcWHNuw2QOjb1Zw0lgIELqgAf93JHNomN Q16g== X-Gm-Message-State: AJIora/3fVwEF5mVeqlrnJeXC7m48Jj9Qpahgc2vGGnJD56RJQrJjaRn r6ayI1+Jm7RbQ3OblAKIedfFtQ== X-Google-Smtp-Source: AGRyM1t8lAzm2G9gBIAvQgEqwiF6CQ9GPFlZ198nRDR3H852J1Ff4TQnDKakZTc6DG+MeGM/mzTzAg== X-Received: by 2002:a2e:99c5:0:b0:255:7dc1:3b1 with SMTP id l5-20020a2e99c5000000b002557dc103b1mr13775416ljj.277.1655795998108; Tue, 21 Jun 2022 00:19:58 -0700 (PDT) Received: from [172.16.11.74] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id 13-20020ac25f4d000000b0047f4291a10esm2062922lfz.163.2022.06.21.00.19.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jun 2022 00:19:57 -0700 (PDT) Message-ID: Date: Tue, 21 Jun 2022 09:19:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4 13/34] test_printf: Drop requirement that sprintf not write past nul Content-Language: en-US To: Kent Overstreet , linux-kernel@vger.kernel.org, linux-mm@kvack.org, pmladek@suse.com Cc: rostedt@goodmis.org, enozhatsky@chromium.org, willy@infradead.org References: <20220620004233.3805-1-kent.overstreet@gmail.com> <20220620004233.3805-14-kent.overstreet@gmail.com> From: Rasmus Villemoes In-Reply-To: <20220620004233.3805-14-kent.overstreet@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655795999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5BtOB1xQhN3Ha4LlKucv6D1ctcTjHBCQ1Tbc7a6of4E=; b=xWUgWs+5xRcei924qUkNdA2xsN88dbHXA8kl9kFN5YYv3s4b2cVkPpDEcL8ObN3ecHfjAA +FCyhC1vhk8SMzAtRTvFPjTPLy1TduwC3yi+Ie+Qg4q3a2u0oC7VWpcCDSX+2HFpcFeYfe hpZ94MRQB6N274HzxDj7IwVh3aHyxRk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655795999; a=rsa-sha256; cv=none; b=xTbuQZ5qEH63c2zRB/+Z4IhVqf7SYKUr6InsqZq1gGu8Fc5QRCOdtY1En34Jx9PN56Pb5P 3smQubjmun2+wpJZevVnFl3sWqK3jWKHXylIm9DvrrWoOSKVndxxc6XagSqZPiMuvibMQb yT+TqsihxRFZsQy1kag+GNrVN98qSOI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=rasmusvillemoes.dk header.s=google header.b=TKmlBWKS; dmarc=none; spf=pass (imf21.hostedemail.com: domain of linux@rasmusvillemoes.dk designates 209.85.208.181 as permitted sender) smtp.mailfrom=linux@rasmusvillemoes.dk Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=rasmusvillemoes.dk header.s=google header.b=TKmlBWKS; dmarc=none; spf=pass (imf21.hostedemail.com: domain of linux@rasmusvillemoes.dk designates 209.85.208.181 as permitted sender) smtp.mailfrom=linux@rasmusvillemoes.dk X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: qcfdg956agxke1n84ou6q6ajt5if1xrb X-Rspamd-Queue-Id: A80201C00B4 X-HE-Tag: 1655795999-652309 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20/06/2022 02.42, Kent Overstreet wrote: > The current test code checks that sprintf never writes past the > terminating nul. This is a rather strange requirement, completely > separate from writing past the end of the buffer, which of course we > can't do And which of course you don't check anymore. So any statement about "all tests passing after these patches" is not worth much. So NAK in this form, but perhaps if/when my year-old patch gets picked up (or you could include it in the series) we can talk about eliminating the check for past-nul-before-end-of-buffer writes. Rasmus