From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB552C001DB for ; Tue, 15 Aug 2023 02:53:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35D4C94000E; Mon, 14 Aug 2023 22:53:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 30EDC90000B; Mon, 14 Aug 2023 22:53:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B06994000E; Mon, 14 Aug 2023 22:53:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0A02590000B for ; Mon, 14 Aug 2023 22:53:48 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C9FD81C9721 for ; Tue, 15 Aug 2023 02:53:47 +0000 (UTC) X-FDA: 81124818894.09.084803B Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf08.hostedemail.com (Postfix) with ESMTP id 02D8F16000B for ; Tue, 15 Aug 2023 02:53:44 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=e5H6YSxa; spf=pass (imf08.hostedemail.com: domain of wuyun.abel@bytedance.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=wuyun.abel@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692068026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a8HyUjDBkW62Y7ia/YRzhrRt6SI0MoeiKF06ymvveI4=; b=Cy2l5ToFxS5Ye5oX49sVUEQCD04BSCNKlyMwWIGYBGWQo8g3fmrFMGA+3EPDImbJrmtEXG XTkijMJpW4vWzCca0n1JbjrcIaVRyNaHxhikyFY+iwrvFmdeeRab/zVSg7c3sA/kDO/CBm OCU0mhDwZnIkUb7OUoWt1aMvCtDM5CE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=e5H6YSxa; spf=pass (imf08.hostedemail.com: domain of wuyun.abel@bytedance.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=wuyun.abel@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692068026; a=rsa-sha256; cv=none; b=v5TQ5ELG9ZG0XFGpnHW617GQo2v0Ec357isfs20IJcMuRjQrxW07I7kYt0ffzdNU/bbo6/ /JrnIKav6wSWbf+CHkTO/CYIFxUnJmHvy8TNFPe2WqFR3e5im+rb92GAsdt1U7LjemGY70 cJvHUaKVMSKAdiDa2s+ygbFIqj9ISwE= Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6874d1c8610so3230893b3a.0 for ; Mon, 14 Aug 2023 19:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1692068023; x=1692672823; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a8HyUjDBkW62Y7ia/YRzhrRt6SI0MoeiKF06ymvveI4=; b=e5H6YSxaquRTypkZyjRtJDCwTmj5Z8r9Hx5apY8RhyinYxtJgLPHfj1RJYFYO+7j7h /XDrG7/16OKncrgd4rQzDKiDxmTxML7eTcIcJlApNVK7VwSPMRia945Nj3UpFZFqLVxr c+TJdcrrYEsJ2D+NPAvrqWZ/lcET6O9a7jF5NDA3w5oNdN00BW0X7ksw3eGvMmN4iAVv IPJTW3vBweY463qXeEMbiUcYWz3Ge+Zn5GN9ZdDLS+iEAXkLnBKigA9mtVVe0iPmHT/9 HIfoGsl7xLunxJrwgoVyzkqCS1QH7hmlNRPFsL1uZKuEccnQq4wlLjkrsukuqlh8NNH1 rMpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692068023; x=1692672823; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a8HyUjDBkW62Y7ia/YRzhrRt6SI0MoeiKF06ymvveI4=; b=X+AUQaqFuNjlk+Zdr6XQkP63eJycB1Y2pFAPTr7TupnZDmNfnZg9JTWHjXmyz9Zgj7 U/oHNGDk1AbAHM5Sjg7sRcSgt938qm+Di4G3mY4bUlHw1n8J2J4ztHfdC2qJxoe9Sr28 5ShJSBiEPY1oWYega/9plh7O7UdNnognnSW50YUFDbI9oK1t5wx1sjjiVDJf8eQDxHcY kg0DVEgNAnik+y9mM0KoRGnt0qQ3W2m+QrK07cjywtjsNpTUnHSt6mg2UMR7Uhg2vi+4 I3dUKbt8PNWAvSDTc50XgS3abNRzYXBgpqa5WjFC1BCJa+p382fQm3bVdzx9OiRYoqQG 23MA== X-Gm-Message-State: AOJu0YwKyiVR2UhgIf5FnjskGBz2Iz9zoqtpoVG4O66KFjVukg9X1UKF 7VRLLHM+fjXUSNRZntRMv1Bi/Q== X-Google-Smtp-Source: AGHT+IHjc044e6npnV/BiafJF0UU9FsLZmr9i/ZW8Kkux8QHJDLaNlnB4TRHzQQqdetV8IlA/XzFsw== X-Received: by 2002:a05:6a00:13a8:b0:682:2e99:9de0 with SMTP id t40-20020a056a0013a800b006822e999de0mr11561476pfg.23.1692068023296; Mon, 14 Aug 2023 19:53:43 -0700 (PDT) Received: from ?IPV6:fdbd:ff1:ce00:11bb:1457:9302:1528:c8f4? ([2408:8000:b001:1:1f:58ff:f102:103]) by smtp.gmail.com with ESMTPSA id g4-20020aa78744000000b00686f9789064sm8835581pfo.12.2023.08.14.19.53.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Aug 2023 19:53:42 -0700 (PDT) Message-ID: Date: Tue, 15 Aug 2023 10:53:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: Re: [PATCH net-next v2] net-memcg: Fix scope of sockmem pressure indicators To: Shakeel Butt Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , David Ahern , Yosry Ahmed , "Matthew Wilcox (Oracle)" , Yu Zhao , Kefeng Wang , Yafang Shao , Kuniyuki Iwashima , Martin KaFai Lau , Breno Leitao , Alexander Mikhalitsyn , David Howells , Jason Xing , Vladimir Davydov , Michal Hocko , open list , "open list:NETWORKING [GENERAL]" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" References: <20230814070923.35769-1-wuyun.abel@bytedance.com> Content-Language: en-US From: Abel Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 02D8F16000B X-Rspam-User: X-Stat-Signature: mr4yat8f5up11k1xfxbm3rok8konngnx X-Rspamd-Server: rspam01 X-HE-Tag: 1692068024-597934 X-HE-Meta: U2FsdGVkX1+pKYwik5KJ/AnoUMdG0BprNM70lY3baOQhnKlRCp3XUPcVCvWUFsCNHR8oc4n4Mx7QOa8mYcAdRdxEbYIbwfgtYuCWhNmjS/5MjNyRz1V0DdyV5Vb/d/IZ1Gf7DF8Ug2we7H+0e3RonsQOtc7u+VMJC7L58VSlW++GFFg7o18S7TP9Hey7WzEKBJKNKoLgOA48rXQxRtKIH2jVCKssRWmUPxO3bTiXFkOWQ5JzaD8S4CkCPtloET0iHK6RnCPz7kyK4cCbMe2JBeziBg/n61BM8t7pXpn5bexfaM4hZ4iB11X+ciiYm5sCbqCh9HfHvydxQs/vzFbnxTZkXPv007OXm8CbMtZzh9Hz0R6cshP4wnqapD/3D2BptXZ6Ruv8SdCgQTnaBwTMCgUtxwOUAJNSV6uf3SIa6xH9kBEKT5FZWG6rmojAUo5Vyi2fzeiqWBV42NVc2i1mEcKAXpYkB69KGNEFtp3zhBon9WMpPROzSab+f2bO5l0hCWm/EQaainFK/RNM4W6GE0kpK3Gp62PHsGoQ0bXIRr0GykkjzNaQdn3O1wbuDTjOUqDJFeN583F6wnoTnyC2ExGGj7ly5B3nfK33ypPORiepg0f1vuo8LgvKgHWOFDCEmlnGa9H/FYoTyJaFbrlP4wYVQiCIOPyhJB7eeTuwKhklBPiTy2n8jsv1PpnIsr1R6XVMBC/q0nxuWBSTmLLg+cHgXnGbow0mzxdwIt5RZ4v8FplnjvtxJHSazru4DISibO6fnjZyS4vhKBZw3Fy3a7ijiDJePKjI/3E0JkOd+DAMcCqABvJ/uv0Ztbx/rEB0k9sysyDRGZzAlGnnyOaff8dn2MZofKZbWL+cAjPIZw6bLGq6SkRTUIr8hJ5QIdfo0Dh3KL3CC6vHklHoYFSqFBBBkvgeHo5zbAHhQcVBUJN4AcGSCnYBvLU6ZUNaD4260WO7ngPQxB8nT49X6+y VBVtQ5c1 d5xGO5+qI+cRM+R/DO2u+J3cS0qn42bWsPvpE20pmq8cKEvMQVY3E32UunsLCADquJiC9MALy8G04SBFiFElx7iK1bXa/3B4RhIzX/W1txksIxDQUmSUM3kLSiy+N0AisX3aS1mt6TVw3gpHNP+z+F412vaC6ncizzL3qpaHXGVFB5SY5JYdIRKXfh3HvBJqOIwucHalNZxg0w80tqqvxplPClE35s1fnJg56uXqOg/qOYxQOYaDK7jwk5xVtNKdtRI3v/4L3PW9v6IfaN8OGqA/ATByCzapCAJHhXXss7CZ7lrXHaKC3oQpXKQkUhGIaBJ8psiXMtFGbemkr8iI6RI7jr5Rc8kqsJZbsTqdAKXCd8zP79mPyZpsyIyM3OQaTpbi9qjSQW1XY7kI5SH6ODc5A4YDAZX7FfsxLtLEeuW8wjAPNpw6oZmknqwcKzSMZZ447/fHsjgBnrmhuZXrynl3V/dq8eN3TVcKb7zDUxDPYWHZkJwIATRu9jNoEtNdF84I5OLhfkm85osTU2snjkOZeRXLr4l4rnyguJE3FxRbQk2q1z3eIbpMBTE6Smrp4GIjDruW/wgXAeg0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/15/23 4:18 AM, Shakeel Butt wrote: > On Mon, Aug 14, 2023 at 12:09 AM Abel Wu wrote: >> >> Now there are two indicators of socket memory pressure sit inside >> struct mem_cgroup, socket_pressure and tcpmem_pressure, indicating >> memory reclaim pressure in memcg->memory and ->tcpmem respectively. >> >> When in legacy mode (cgroupv1), the socket memory is charged into >> ->tcpmem which is independent of ->memory, so socket_pressure has >> nothing to do with socket's pressure at all. Things could be worse >> by taking socket_pressure into consideration in legacy mode, as a >> pressure in ->memory can lead to premature reclamation/throttling >> in socket. >> >> While for the default mode (cgroupv2), the socket memory is charged >> into ->memory, and ->tcpmem/->tcpmem_pressure are simply not used. >> >> So {socket,tcpmem}_pressure are only used in default/legacy mode >> respectively for indicating socket memory pressure. This patch fixes >> the pieces of code that make mixed use of both. >> >> Fixes: 8e8ae645249b ("mm: memcontrol: hook up vmpressure to socket pressure") >> Signed-off-by: Abel Wu > > So, this is undoing the unintended exposure of v2 functionality for Exactly. > the v1. I wonder if someone might have started depending upon that > behavior but I am more convinced that no one is using v1's tcpmem > accounting due to performance impact. So, this looks good to me. Agreed. The performance impact is not negligible. While not accounting tcpmem is also undesired for Resource Manager to do provision properly. So we have to migrate to cgroupv2, and now we encountered a new issue. Some discussion with Roman can be found here: https://lore.kernel.org/netdev/29de901f-ae4c-a900-a553-17ec4f096f0e@bytedance.com/ It would be great if you can shed some light on this! > > Acked-by: Shakeel Butt Thanks! Abel > > I do think we should start the deprecation process of v1's tcpmem accounting.