From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C925DC2BA18 for ; Thu, 20 Jun 2024 11:50:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 421D88D00B1; Thu, 20 Jun 2024 07:50:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D1E58D00AF; Thu, 20 Jun 2024 07:50:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 299718D00B1; Thu, 20 Jun 2024 07:50:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0C25D8D00AF for ; Thu, 20 Jun 2024 07:50:47 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7C506161A91 for ; Thu, 20 Jun 2024 11:50:46 +0000 (UTC) X-FDA: 82251100092.02.B826D52 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf10.hostedemail.com (Postfix) with ESMTP id 40065C0008 for ; Thu, 20 Jun 2024 11:50:42 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718884237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v4w70t6z3S15EFqvtWPpRq462vdCBE/OouUYIKgthhQ=; b=0yTqoxsUNaUN65lnfCAaMc1yaoL86oMblfWvA7EhvO5Mx2p+Vj55AVu9Na2kZ0dsBOxXOT BBvixxsWgNt0sixYUaF5GIUGLVtY09ZrnNANQd5DTQFjNKDWDCDlPt5IuL2OF8fKqLrrk2 gfahAHbe5WywMxF4X12hVyWWo2zopts= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718884238; a=rsa-sha256; cv=none; b=ReRCPoqIRKyfcc01BYWQv0ftDLyxD/AaK6/x4tbS8f6hPjfPf6p/JGk1yKUvWwrQMyIfLY RMuuWXVM2jZEN5Cv9J/yYcBtzfZGpqJJNpNzc9BOmAh0geaCe4nKOvJsvJl+CvZgYULk8p KtCv8UX6bCa0/OdtiiSM6bGal57VQ7g= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4W4f0N0tJJzdcfk; Thu, 20 Jun 2024 19:49:08 +0800 (CST) Received: from dggpeml500022.china.huawei.com (unknown [7.185.36.66]) by mail.maildlp.com (Postfix) with ESMTPS id 3EBC61808CC; Thu, 20 Jun 2024 19:50:39 +0800 (CST) Received: from [10.67.111.104] (10.67.111.104) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 20 Jun 2024 19:50:39 +0800 Message-ID: Date: Thu, 20 Jun 2024 19:50:38 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] hugetlbfs: use tracepoints in hugetlbfs functions. Content-Language: en-US To: , , CC: , , , References: <20240612011156.2891254-1-lihongbo22@huawei.com> <20240612011156.2891254-3-lihongbo22@huawei.com> From: Hongbo Li In-Reply-To: <20240612011156.2891254-3-lihongbo22@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.104] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500022.china.huawei.com (7.185.36.66) X-Stat-Signature: xfsyd97z8ietkzukqj8e4qtk3cohhrxe X-Rspam-User: X-Rspamd-Queue-Id: 40065C0008 X-Rspamd-Server: rspam02 X-HE-Tag: 1718884242-669128 X-HE-Meta: U2FsdGVkX1/XRAb3EmA3NcK0Y5ZG2LhZarY+LeBCt1u/0gG+n1hpOOUPoNbv9StQxH7DI0tZD0ZTvir5ktWZhIUo1BCHd59bInO/IduZzHUA1wFPs2FLDbNAzoPhcPdla5C9c2PfFdqfOw0rPuc5wbW6zfSGy9QmMXcRLVrfJVRDUGlFEmC0V75doW1mhS99H/CueuipTxJ8NBZdgHI5aJIZUkNPQSNrWFxzinQLjt4BV7w1CSKlz4RIEQAI8VIAezHS5KmYGD8j5VpOC5+urKzQtM7rh8ZXo0LGekqN/sKdDOkQQ9lW89OjdFtpnpdsp+ml+wPWXji8DuK6aZfI3jaZHVR1uKCCQVCcATQ88nHILkV2HQzzxn8bXqgrhlxlY1dtGAPanqxyxDTnD43OFuDGINwKbC6z6fmdm4yuQiWUgIwU3zDHYQTNBoprmuGd7j2d076dkVznAVRY8vaW6NItXCCYE/QtL9NVP0QIH0czVMowP18o4C0QpSK8bykG9E0HObgbgJgvvZOoYqlGL8cS4Az4qiUxzH8PzEjkQ8NOR0af3tzcEE17L3X8TKRzUhhseXoDD9p5S1vWFnbLebRj3NAW1tEqJ/Dd6r7fLhDwwBeyEWJiuP0KK/0vzyzqCcEdheVh2z0TYC9uEtOjuBcAQMIswAknFZKy6kipudCcQseCKCT8Fv9/a+GUBKLwquRUHtWDfFnQ4uUtmxC6u2qzpNO+4ddUB4TckkOnY2Mx/f3cpRUTaDej0dYO6XTAIBYVt7zrvfLDumiw7LMZ9hlxioyxBxAkCHTyQPmDf73JcJGj57QejkRBgaM2SNw3JYrBhiRwC6cKpYT2oJvqU3lIiGR/kQQTv3HO478WXgcqT9b1EEX6JZg5XDMiTXgIB/nA4rGVuTZPmvcLZ7c0jwRNbDFA5jBUVxWtYwxZlRTXlSuLG3hvuxXv+YEkeLpuXmG7e9g6Qw3ZluyQV5T XvM599EZ C1iqAN//7jzGdlPkht2nWQAWlTKSV9aHjdiMtZNtcmPPlqUZHXBCSZYhftWmNOgvPPo75EWMyNfypXLBPSq8c+SJzDR3TvqewBMSjx6pVFbVHXLZpQ0UijFht2sfT6uTzFYUMTgYg/DgEzK+vookz3oA62CV04fzzpoSLP2MWv3aTFrU4aXA6/l6ONyJsa1P85Qjjo81wfefoY54We7maicfn7JXKruPOW/zBUh5MGGAoA76QgWBBC/YC2+oK/iy3ecB8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Just a friendly ping to the patch :) https://lore.kernel.org/all/20240612011156.2891254-1-lihongbo22@huawei.com/ Thanks, Hongbo On 2024/6/12 9:11, Hongbo Li wrote: > Here we use the hugetlbfs tracepoint to track the call stack. And > the output in trace is as follows: > > ``` > touch-5307 [004] ..... 1402.167607: hugetlbfs_alloc_inode: dev = (0,50), ino = 21380, dir = 16921, mode = 0100644 > touch-5307 [004] ..... 1402.167638: hugetlbfs_setattr: dev = (0,50), ino = 21380, name = testfile1, ia_valid = 131184, ia_mode = 0132434, ia_uid = 2863018275, ia_gid = 4294967295, old_size = 0, ia_size = 4064 > truncate-5328 [003] ..... 1436.031054: hugetlbfs_setattr: dev = (0,50), ino = 21380, name = testfile1, ia_valid = 8296, ia_mode = 0177777, ia_uid = 2862574544, ia_gid = 4294967295, old_size = 0, ia_size = 2097152 > rm-5338 [004] ..... 1484.426247: hugetlbfs_evict_inode: dev = (0,50), ino = 21380, i_mode = 0100644, i_size = 2097152, i_nlink = 0, seals = 1, i_blocks = 0 > -0 [004] ..s1. 1484.446668: hugetlbfs_free_inode: dev = (0,50), ino = 21380, i_mode = 0100644, i_size = 2097152, i_nlink = 0, seals = 1, i_blocks = 0 > ``` > > Signed-off-by: Hongbo Li > --- > fs/hugetlbfs/inode.c | 21 +++++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 412f295acebe..f3399c6a02ca 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -39,6 +39,9 @@ > #include > #include > > +#define CREATE_TRACE_POINTS > +#include > + > static const struct address_space_operations hugetlbfs_aops; > static const struct file_operations hugetlbfs_file_operations; > static const struct inode_operations hugetlbfs_dir_inode_operations; > @@ -686,6 +689,7 @@ static void hugetlbfs_evict_inode(struct inode *inode) > { > struct resv_map *resv_map; > > + trace_hugetlbfs_evict_inode(inode); > remove_inode_hugepages(inode, 0, LLONG_MAX); > > /* > @@ -813,8 +817,10 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, > if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE)) > return -EOPNOTSUPP; > > - if (mode & FALLOC_FL_PUNCH_HOLE) > - return hugetlbfs_punch_hole(inode, offset, len); > + if (mode & FALLOC_FL_PUNCH_HOLE) { > + error = hugetlbfs_punch_hole(inode, offset, len); > + goto out_nolock; > + } > > /* > * Default preallocate case. > @@ -918,6 +924,9 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, > inode_set_ctime_current(inode); > out: > inode_unlock(inode); > + > +out_nolock: > + trace_hugetlbfs_fallocate(inode, mode, offset, len, error); > return error; > } > > @@ -934,6 +943,12 @@ static int hugetlbfs_setattr(struct mnt_idmap *idmap, > if (error) > return error; > > + trace_hugetlbfs_setattr(inode, dentry->d_name.len, dentry->d_name.name, > + attr->ia_valid, attr->ia_mode, > + from_kuid(&init_user_ns, attr->ia_uid), > + from_kgid(&init_user_ns, attr->ia_gid), > + inode->i_size, attr->ia_size); > + > if (ia_valid & ATTR_SIZE) { > loff_t oldsize = inode->i_size; > loff_t newsize = attr->ia_size; > @@ -1032,6 +1047,7 @@ static struct inode *hugetlbfs_get_inode(struct super_block *sb, > break; > } > lockdep_annotate_inode_mutex_key(inode); > + trace_hugetlbfs_alloc_inode(inode, dir, mode); > } else { > if (resv_map) > kref_put(&resv_map->refs, resv_map_release); > @@ -1274,6 +1290,7 @@ static struct inode *hugetlbfs_alloc_inode(struct super_block *sb) > > static void hugetlbfs_free_inode(struct inode *inode) > { > + trace_hugetlbfs_free_inode(inode); > kmem_cache_free(hugetlbfs_inode_cachep, HUGETLBFS_I(inode)); > } >