From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f71.google.com (mail-wm0-f71.google.com [74.125.82.71]) by kanga.kvack.org (Postfix) with ESMTP id 741916B0038 for ; Mon, 9 Jan 2017 07:06:55 -0500 (EST) Received: by mail-wm0-f71.google.com with SMTP id w13so14699009wmw.0 for ; Mon, 09 Jan 2017 04:06:55 -0800 (PST) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id go16si96452262wjc.76.2017.01.09.04.06.54 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 09 Jan 2017 04:06:54 -0800 (PST) Subject: Re: [patch] mm, thp: add new background defrag option References: <20170105101330.bvhuglbbeudubgqb@techsingularity.net> <558ce85c-4cb4-8e56-6041-fc4bce2ee27f@suse.cz> From: Vlastimil Babka Message-ID: Date: Mon, 9 Jan 2017 13:06:44 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: Mel Gorman , Andrew Morton , Michal Hocko , Jonathan Corbet , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-mm@kvack.org On 01/09/2017 11:04 AM, Vlastimil Babka wrote: > On 01/06/2017 11:20 PM, David Rientjes wrote: >> I'd leave it to Andrew to decide whether sysfs files should accept >> multiple modes or not. If you are to propose a patch to do so, I'd >> encourage you to do the same cleanup of triple_flag_store() that I did and >> make the gfp mask construction more straight-forward. If you'd like to >> suggest a different name for "background", I'd be happy to change that if >> it's more descriptive. > > Suggestion is above. I however think your cleanup isn't really needed, > we can simply keep the existing 3 internal flags, and "madvise+defer" > would enable two of them, like in my patch. Nothing says that internally > each option should correspond to exactly one flag. Forgot to add that if/when you repost this, please CC linux-api and summarize what else was considered in the changelog. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org