From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B113CC77B7C for ; Mon, 22 May 2023 01:53:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8EB26B0074; Sun, 21 May 2023 21:53:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3D96900003; Sun, 21 May 2023 21:53:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2C88900002; Sun, 21 May 2023 21:53:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A13406B0074 for ; Sun, 21 May 2023 21:53:45 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6F85A160337 for ; Mon, 22 May 2023 01:53:45 +0000 (UTC) X-FDA: 80816219610.29.C125536 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 8C11A1A0010 for ; Mon, 22 May 2023 01:53:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CvH7IghC; spf=pass (imf19.hostedemail.com: domain of xiubli@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=xiubli@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684720423; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LjpVYliWYmLsp+7DmHIQ6WIiz69+8hAntxXwMv/K+0o=; b=LbhDAbTjWq5sWLBoy3XQZ+f1LOMwD8s1K7CCqqASFjezZXVHQ+HE4yTJuE2+2tetDkIywg IBTU0YnsB1y9FdK+3R56QkoRtu/bXsQMZ+ZhAfWtBYKWRFjHBu89qz+qCo7dxJeBa37qwO oxVgJeNgHQYzbZDhqCxh3qx35WH9hSk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684720423; a=rsa-sha256; cv=none; b=aFx6XFZDBu26UOx8FOyl6D1BtkjgmQIK426Aunj461AXfd4qoeQp6Z7hLRqJVA8Yxp/9Pz TFDjP5PDiIBMWQB4xyjKTOuml6+D6Zz+7B4bxVQGES5RoEwOIa3kqK6trZBWtRnieGhPky 26Un8iNRnKczmmdZeFOdtqzVMvAe4YA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CvH7IghC; spf=pass (imf19.hostedemail.com: domain of xiubli@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=xiubli@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684720421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LjpVYliWYmLsp+7DmHIQ6WIiz69+8hAntxXwMv/K+0o=; b=CvH7IghC8elxO57ELNFV/bL58s7z+VJxJqi+eCGivHSX0fsBjdB844y2xp6a2hxy+uJLBS sBjmT0Qjg+s/t7atzfblECqiq+1Z4ySBGB+TebyP3m/APCVq8+fIoVC5G6G1eFNuu3Hzyi Guol+TZMoHkcbcRCd6m9apwuLvHbcRg= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-S55J4JDnN3qnyWZ8vXf66Q-1; Sun, 21 May 2023 21:53:40 -0400 X-MC-Unique: S55J4JDnN3qnyWZ8vXf66Q-1 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-64d2b93f803so1850133b3a.1 for ; Sun, 21 May 2023 18:53:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684720419; x=1687312419; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LjpVYliWYmLsp+7DmHIQ6WIiz69+8hAntxXwMv/K+0o=; b=jBL2mf9ApHU2f3E8+z0xbkFWWh7fOZ+Gjj0J5OJKW2Xdlevq7KutqHoa42JxpHGHMj 5Dloh+QUfkdXKnDtQS/9e+XcMFXsYqOVpZbXPhO1BYpuPt2gbAEJ+6Rm64prs9s1HIpO RO7CDz9+DbXYxexCWWfWXxcUTaUSXBj2sjrNhDAMlz3POxpQNH4ocedHZPul4UinV0Eh ZJSbNFSDazBkGouVfLJwti1d85Rw//b9tnGwDBLacwp99FY3Bk5Mevjrkkb8/MzEGu5U VFLfELxcU3DCwYpcFBqCnV16VNmzmcrEIpcXlsRAXA1DT4jYkIBZOxOqAwT2cN1NdzW5 V/MQ== X-Gm-Message-State: AC+VfDwp97G609IO7NVGMRAUakN9/ZbfILWfvZJaK2ObKHK4z3/VOEzF dcEBqpEg1bo7rxhw52+QadmcXipbSf9P1Jd39mk2VxMtFGJI98PONsItflkhuG8KVCcYaZHoGp9 ZM3kwOjAemT4= X-Received: by 2002:a05:6a00:2314:b0:63b:6149:7ad6 with SMTP id h20-20020a056a00231400b0063b61497ad6mr11651216pfh.34.1684720419701; Sun, 21 May 2023 18:53:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Mn7xT7CCI+yBGqvco+AvK/IKOxX++Ib2iwxBd4veVXnB4vaLlF/dnAev/HMla5PSUAUk2RQ== X-Received: by 2002:a05:6a00:2314:b0:63b:6149:7ad6 with SMTP id h20-20020a056a00231400b0063b61497ad6mr11651198pfh.34.1684720419429; Sun, 21 May 2023 18:53:39 -0700 (PDT) Received: from [10.72.12.68] ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id s9-20020aa78289000000b0063f2e729127sm3121905pfm.144.2023.05.21.18.53.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 May 2023 18:53:38 -0700 (PDT) Message-ID: Date: Mon, 22 May 2023 09:53:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v20 13/32] ceph: Provide a splice-read stub To: David Howells Cc: Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Ilya Dryomov , ceph-devel@vger.kernel.org References: <20230519074047.1739879-1-dhowells@redhat.com> <20230519074047.1739879-14-dhowells@redhat.com> <1743656.1684488288@warthog.procyon.org.uk> From: Xiubo Li In-Reply-To: <1743656.1684488288@warthog.procyon.org.uk> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8C11A1A0010 X-Rspam-User: X-Stat-Signature: ret9gizhgayrrh9inobprw6gxuzg7tp1 X-Rspamd-Server: rspam03 X-HE-Tag: 1684720422-588921 X-HE-Meta: U2FsdGVkX1+nxe4VnDSi8ovzxj4oeMwtEYsDY1CjQqpdDHuMnuXFTo7f/Fo8wIhXQCp0TAwH0plUC0RfnCWkDJKCHyhh5Mbe0896gXpFTHHGCPFn/p+f3aaqDxYSimOp8b2drOsvEhuPfN7Gx0fxQ7MGIic0f8F2Ey1SuzFlXFOTmvXlQy80dyBs+u0KI6qvl6Lu6CCbSO2UNcusfweeo1g5bKYhO0zzooiKH/TEsWoho4T7Xm0e6DwEzuDop6VZFrNYtin7187vqZzvOKsMli8BOeu/z64PDnyA6+C3835hbckODEpUqJJeai57XexFBTdb5cXjt6JW97JgYXi0t5SPxb6nUhqCCiGfQXIvPBWlg4OMwBUtOVimO1Zb45n8wHqMd+rEBIieD0pUeEtCaybf+E++fz52qS/ynAhpAb6RjrAjk5j8LwvRE4I9okEuu7rnGF3KLSyGhiXQD1qwp807Y4rnqMFYJWpVaDAnY79UZeQ1lPBqr9fW67amyAU+AfIgtYixw7zZre4gobhJEk8mc2gPSisT0rcyuzSyBEtvwQ4i9cInStnAJ+HxXjb7sy0zxn0Y9pNulH3FiR/g4D+YrMdEA4bUztbC/gR9UkgqLNUb5K021aXWdn6BRLKVKgxjt13hHKl0s7eNXCsT484Gw/17i0ltv2c1ELSolA6Dqxs3onnXzEviTjlPfjVtl4lmwl3ZEYAive84WTSiPg81B64FoWSEzxJXQ3rrlNCx0Mqf1YKhy/aPpAgp4b0xcLRO0caYuvyf1GOIPk+SeQ1LrzyySJKl/9IC6YRX476F6JTXE79KIS383KyRTWK0sNw312Fqd940YfPbxfg98tbE8yClsByMlB/3dZC9hV7hMoTO5xo8TU4bkgj7oqAH3V/k8u/1YyLqqv6VjSRvRXV69uDGL/Irbv4E0lbCNQIq7Rak2JXRBCJ7/HJoTQteBkmb6qnY+pEEHzxSBTM IqqCw0/y m+lAod2EyOb9ErLhxPUPRj3jwHXbE0F5DClEOZarS8lKy9j8zfgXiLVF4ShX8P4VgN7UjojYWfABzmu0pFlLPCH4yewUf/ehlzoy7Zbl3Ew4b5PbqKJXRPfG2Ad9XA0J41DN4QAxZpJYOu+gzlrZekIn4lbt5YADep0u5fiiZBZwkY9gXgnUEuHj1KkNvBZAsztFUxaiLVBVi8Wk4a8+o9/mWj49Ttkyk1jmBpU0VG9lXANht7yWfeMlByvl3na/dYONVyUgrkm96u7lh+iP32icqmJa7srb3cCWUr1o4hVoTMB1kDVbWy0I8tCeBZMjPKTWruUeE3rT3lLOHDgZEme5Ce9xpSa77AkPdSsmqLHLmHkWpzskFJnw7ydAO550mHZE5yiEmPjKWWoE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/19/23 17:24, David Howells wrote: > Xiubo Li wrote: > >>> + ret = ceph_get_caps(in, CEPH_CAP_FILE_RD, want, -1, &got); >>> + if (ret < 0) { >>> + ceph_end_io_read(inode); >>> + return ret; >>> + } >>> + >>> + if ((got & (CEPH_CAP_FILE_CACHE | CEPH_CAP_FILE_LAZYIO)) == 0) { >>> + dout("splice_read/sync %p %llx.%llx %llu~%zu got cap refs on %s\n", >>> + inode, ceph_vinop(inode), *ppos, len, >>> + ceph_cap_string(got)); >>> + >>> + ceph_end_io_read(inode); >>> + return direct_splice_read(in, ppos, pipe, len, flags); >> Shouldn't we release cap ref before returning here ? > Ummm... Even if we got no caps? No, at least we have got the 'need' caps: CEPH_CAP_FILE_RD once here. I saw you have updated this and will check it. Thanks - Xiubo > > David >