From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B13CA100C for ; Fri, 30 Aug 2024 18:52:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6C588D0009; Fri, 30 Aug 2024 14:52:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F4958D0008; Fri, 30 Aug 2024 14:52:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86E528D0009; Fri, 30 Aug 2024 14:52:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 593F18D0008 for ; Fri, 30 Aug 2024 14:52:44 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E5CF18045D for ; Fri, 30 Aug 2024 18:52:43 +0000 (UTC) X-FDA: 82509808206.02.FE0D58D Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf24.hostedemail.com (Postfix) with ESMTP id A817118001E for ; Fri, 30 Aug 2024 18:52:41 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf24.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725043895; a=rsa-sha256; cv=none; b=DXs7rosrpz7iKwl89U+3Oyqm90KC5bAhhSCGNRkU8ZysCbsbEp6UUJqxEcdyNHnBFSYvwZ mUIW7XJpI8uhkxP2lozy3o3pIK+v/8zcDM2w/tBrds0EnDk9GPGXBC6PYGNTUWJn0NWEJM jcrL25yrdJIch4IEQRcUA9bpFz4W35I= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=csgroup.eu; spf=pass (imf24.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725043895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ixFOCowLbihHuXZkkS8D+oetf/5p26hfwIgu6Bu4264=; b=I9PeVTvKPPCCQl2+SwBMw9fjmgaVFy8NkBREj0BvlppD3BVFk+THUtPJAvAjkcRlPqRypg qUL5HFt+Xv7I/dNK1r0zvVWXWCUXA0SIMU2deVo1VX00nsedoKbt6QmOTWI4mqM8ji0alA ZPgAU8npr4DcMn69klIhYCIWxb4jQHw= Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4WwS2H2zdLz9sSN; Fri, 30 Aug 2024 20:52:39 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3f9-XC2A1YeT; Fri, 30 Aug 2024 20:52:39 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4WwS2H1wnjz9sSK; Fri, 30 Aug 2024 20:52:39 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 28C2A8B794; Fri, 30 Aug 2024 20:52:39 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id h0_TT9jQfciA; Fri, 30 Aug 2024 20:52:39 +0200 (CEST) Received: from [192.168.234.133] (unknown [192.168.234.133]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 428938B764; Fri, 30 Aug 2024 20:52:38 +0200 (CEST) Message-ID: Date: Fri, 30 Aug 2024 20:52:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/5] powerpc/vdso: Wire up getrandom() vDSO implementation on PPC32 To: "Jason A. Donenfeld" Cc: Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Shuah Khan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, Adhemerval Zanella , Xi Ruoyao References: Content-Language: fr-FR From: Christophe Leroy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: A817118001E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 38qaxyoxc6a1uxnn9nt4a7w1w6rse3yy X-HE-Tag: 1725043961-69933 X-HE-Meta: U2FsdGVkX19+g6aYs6Hhf6cqskklmdQFAV45x2NriGf0BbqJaXRUO3happp8RboNizcxloZqW/xL3EbRHKgvFp7ZeVkzPobLFCiz/eGDb6aFRpmqOLSOuUiCmpeaP6Pi9cqYRLZ8f4k2+p32H9x8SRb3ifzCOvEOt/Zv8N5HXnolbIVAy5nhfJpHu5IEYmlLP7JrL1Cx61BmuvvbJMLWsyjjBWwjsTVrNfcCbevoKh9J2wZytIuAmXuLX8H1yxKxTLS8eiS2BigC/rOsul5eK2yDAF0e7UuDOZ5rsQJNp1LtgXpLbziTyfn+6Vgm2EVsYs4gKZkFxBcSHUxFk0lEPEJLm3Oyqi7LLuSB799OGJQ5cn+bWwfeK4OKasdyoEYX7Dj0hxkZMfPDe75qblsVc6j1GBoZIf+WBkfge3i35C6jKLol0+lkvUVP91++4xglYxGcpdEBcCbjR9B7XThDp/ivxFt0QZcuPVyiihgb9c1E3bleWnzCSWpYk08ecH3dYCU3lmiVM7FdEoRYAybGFROOzLz/dvBa6N2+NyyCa9TqPBdhxF3t6z+x4BzjczRd50TDTGmPHokWrTC2zx5gEQ7nHvbIc/MzNB3O6ipSVN8kfCALf04SN59Pnadv3BxAndlzFqj4ic9HhBrqqvDumvqyWaLRv0gkZA3aLW493hHR2GNDNiYcjFa6ETvR3PjUFGEd/4BIVIv7I1WzrgRVzFJJmYZUetWZT2wW7/LHJENAbh60+3shkMi32xpnQXLHzGOWwITt+W1Byhwvj+7B6BOMsH2ZSTobHO1ijooN/EAfpuJmeg2KsktGR+63KDtSSSs86+lUZ22icOJj+hqtwoQnq1YOjv+/S5FTgEXChGCDosF6cI6x5Gq1r9Z29o7Kryel/gaIth/WC9irEaqSGnrhtjLuDoEf1Aqk+i5UNDSwRoYB1uSEB9zryrhuthKLVfWNMh2DMrRvcvEiBUX J3QAn7O3 zWo71Y+sFv3gmJb6U2yjgA1ci+6lfwP8elC0/n/UbTSLNdxYqLL+ge9o2egiIFekYO2+yJTxCgtDOGewMWkwABUQZ5pbbcwAbwIAp1X7xuDZp3nafVd99Dr6lCesxEtIpokWJHPvKzBPAx+l8tEeU90zULOuEqdrKbmg2PPbpsCakQXvPw46nyFiZG0r619NZcY5AuNkjVQETBEn9s7EZxzuAPBbZ5tqO4q7EmUdBbMoLxgPV34DpWsMuOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 30/08/2024 à 18:17, Jason A. Donenfeld a écrit : > On Fri, Aug 30, 2024 at 05:57:08PM +0200, Christophe Leroy wrote: >> @@ -14,6 +14,10 @@ ifeq ($(uname_M),x86_64) >> TEST_GEN_PROGS += vdso_test_getrandom >> TEST_GEN_PROGS += vdso_test_chacha >> endif >> +ifeq ($(ARCH),powerpc) >> +TEST_GEN_PROGS += vdso_test_getrandom >> +TEST_GEN_PROGS += vdso_test_chacha >> +endif > > FYI, as of [1], you should now be able to add powerpc to the filter list > instead of having to duplicate a new stanza: > > [1] https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fcrng%2Frandom.git%2Fcommit%2F%3Fid%3Dbbaae98172ed284fc0d5d39cc0d68f5d06164f06&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C4f51736c027a44cc7df908dcc90f46d6%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C638606314665557021%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=UtLdKTuEaZVhsguKa7kX1TBJ%2BvvQtl7DmU9hSBeThWo%3D&reserved=0 I'm a bit sceptic with that commit. IIUC you are changing the meaning of $ARCH. How does that fit with the $ARCH we give when we cross-build or with the ARCH which is set by the top-level Makefile in tools/testing/selftests ? Also, wouldn't there be a way to use scripts/subarch.include instead of opencoding ? Afterall, would it be a problem to build it even for i386 ? It should now be ignored anyway with your new commit f78280b1a3ce ("selftests: vDSO: skip getrandom test if architecture is unsupported") Christophe