From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DAB9C25B75 for ; Thu, 6 Jun 2024 08:28:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 620A96B00A0; Thu, 6 Jun 2024 04:28:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D0696B00A1; Thu, 6 Jun 2024 04:28:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 423046B00A3; Thu, 6 Jun 2024 04:28:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 244C56B00A0 for ; Thu, 6 Jun 2024 04:28:08 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AA114120161 for ; Thu, 6 Jun 2024 08:28:07 +0000 (UTC) X-FDA: 82199786214.27.BCF5F51 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 3C3F540010 for ; Thu, 6 Jun 2024 08:28:04 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iq+3N3Ya; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=o5l2hoyd; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=v1UVVONM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DYo2NAoi; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717662485; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6jiPdbd20VjozORRerWC26vG1+ezrVORj3LEO3DREF0=; b=yi8kZy2bhL0JbWEJz7JJ/zplZbz0QWx7Zl5mXO1Bla59scIcd5MyWLFfLyto+Q6cSP+KK/ 06F3MfPzBpoHifkgVHgwfpbpUAhvxHi8hD9GROMUayVEMq5w3PtuuvwMXsK6220AYvXa+A dGr29My1Ju6zlYkP/9rindCXygcXAbU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iq+3N3Ya; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=o5l2hoyd; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=v1UVVONM; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=DYo2NAoi; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717662485; a=rsa-sha256; cv=none; b=rlp+uodCI5FL5XdwwbTqbqYYEwas4olRcuUnNLT2mgg9viFMu34fmFw8NvD9xXpz6a2v/g Lq9/AX4xPNq2gP+wMWZQL9ObysouwREM5lKKFcvQfk8Nk88ITeHCJQO3C1N+QmM9RlnP8L QFbxbLM9WcvO1TGJqmv5I1RsGfVXidY= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1851421AD7; Thu, 6 Jun 2024 08:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717662483; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6jiPdbd20VjozORRerWC26vG1+ezrVORj3LEO3DREF0=; b=iq+3N3YaYHt47ur3L9ka1fOGv8sxQqiI8XCs8dGT6JFsPIbIsHC+ACBEGeaqCOIS8Da7LA GADL+DAmReYhgQjk/jP7ZoUN9eerThBgtpwBZntQcm3mOG5HuRaEYRewLCGpeTsxFQlRrO mbZBq3dJJY+fU1HdDA0RZ/5iYQ58Cc0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717662483; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6jiPdbd20VjozORRerWC26vG1+ezrVORj3LEO3DREF0=; b=o5l2hoydoeKnX6bTTgOSElq+zFayICMJEl3d5BOMEL+bszUHHy+h3FHZYxZLlz66polDwA HFtrN+qVOTuK0/Dg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717662482; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6jiPdbd20VjozORRerWC26vG1+ezrVORj3LEO3DREF0=; b=v1UVVONM11N/gFuFmKHSjLltNLpc6F5B4WM6sDq15UBn+YkdMQKkE+AhRHkGcbT3K/Czee p1QbqRufq9QZfWbPpUiFG8zVwAv1a0BrVnugDWUIKnN3VdikX6T7Om9q5qjE4Vln5aSbKm VRECrQ8gKtg91KRsPv4H5a2OmgUeMxg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717662482; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=6jiPdbd20VjozORRerWC26vG1+ezrVORj3LEO3DREF0=; b=DYo2NAoiAP2OM8rwolgoVWGiaoWEfKdvkMn5CDMMo24CK1Xe6VHhteu3Ok8DYjw57L6DF6 Y5hcksHZZUqrSNBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F1C5213A1E; Thu, 6 Jun 2024 08:28:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id uUepOhFzYWZdYwAAD6G6ig (envelope-from ); Thu, 06 Jun 2024 08:28:01 +0000 Message-ID: Date: Thu, 6 Jun 2024 10:28:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] slab: make check_object() more consistent To: Chengming Zhou , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Feng Tang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com References: <20240605-b4-slab-debug-v2-0-c535b9cd361c@linux.dev> <20240605-b4-slab-debug-v2-1-c535b9cd361c@linux.dev> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240605-b4-slab-debug-v2-1-c535b9cd361c@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: yxundh7m1wdfghcq19c8ho47wzxpkbhn X-Rspamd-Queue-Id: 3C3F540010 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717662484-568498 X-HE-Meta: U2FsdGVkX187jNnwPlDfZsVPq0nibYRkcW6QmifuMX1F8JuXanNrfO142UfTilOahVMbFHeHTSYisv9Oa2XCH/4W3Jz4FxgZ0Xv1V7nIg/nM7OkP02tOEBLe8AYXt0gutOC2+/UieGvq9AqMaOF7gRLmxk1YVZHV3IoAjq3Sepwu64BZzjtq0EXzwYsYGYFLAwEK94+sEddySYheGt9PBnh6iGtEKNxUT5RJxnbIDU49l7Ve25gsxaprikpWKOKsvgfiFgzVUSCMREBK+mY6EjmigX4ioy9x7Xo29iuwHOdBpclAb7Epj1wCKxUszhr/rSPCBZBYQwdW50DIJQrS4pCJo1PFKnCAF2M5RMruIZjLRTDaG7+5ZEIctQIvbqWgXJy6n4dsLRqFZviAnwIGuhE5/ijkvzsJmJHfGCiugm9VpIA+mfWaSoNcXYqCN5CyNUEI9ybVMC/kn28h6vbG9LEmiOzlKO+CDYDQELI7IjGmA3gYNQcPT1+DtXDu0k8LE0G0DXaQ8KUlrlxAV+WjKERDtR/icEsqLayJT36sfdShpOktSNMMlyK4LYvuUTd5P2Y7nwo/YGScWMwGhtgrxOig9fdfGd5tcHaMrEvft9N46jKCMee+ZqhSBpwb0hi7D8WDLL2RORzVXzazKHlWDQrEinl+NdRdkUnXn13KTCzmKPwDtoMVTwAVzLDbovK7iUrSni37AGuZj0YHVdQomdsHDuEM9NScYBz2l8JWs0+VMHQfZjWBEPdV1zHaLBd9tpG0gkvxTN5IVkjAfJ/xgmpVizOd05ooTJcG+PA+uiBg1zKbsoXur1TdOS6oU5T/rRjy/Af0bP6BWmL+L5cahioKnTmB/tDWW2Q0KYO4SId/hLXxPLi1JdQimXPWcylcrI8b3vb7NiyG5+C1//ifO2Q1IAlS8Za7Ua5X63S1FTDd+sAIctxtXkqOIEEvb7N/FiYhcNh7DflORSxxtB/ EAhBXYL+ pCAkisbSdLfOsDNk4Ol2jBxJJXScQzxI4hSCwolb40Zirj9w90psZi4Dz3vtYVlp0tG3oGEgZFtH6/HYc0Xo8HsNBbwlaJ2enf6mV21zKlgrMkaAsTDuvZWEVP7dUXgbBZqouVt6D9J0NeY+/iug8MHbyZphRwKasDxxcSXlxm49lOYVXtUejEVoO9SRa9YccRiKeqKdkJkYSaq86wM6Fez12h3P6Yrdr3Kc+TV1QZxYlTsUxs6359tsJ1kb8XEpJu8E7REoMQLVgVfCLHFu+CZzk5WlAP2GRq5HJu4VeunD4FEceCv4c/W7DhqEghm82sZp8xtFspnrE8NDDR7nr+PzwhrxiLGqZTzeNQxCJMDoK+2+5eRpdemQlVnm9XVbTdvVx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/5/24 9:13 AM, Chengming Zhou wrote: > Now check_object() calls check_bytes_and_report() multiple times to > check every section of the object it cares about, like left and right > redzones, object poison, paddings poison and freepointer. It will > abort the checking process and return 0 once it finds an error. > > There are two inconsistencies in check_object(), which are alignment > padding checking and object padding checking. We only print the error > messages but don't return 0 to tell callers that something is wrong > and needs to be handled. Please see alloc_debug_processing() and > free_debug_processing() for details. > > If the above inconsistencies are not intentional, we should fix it. It doesn't seem intentional, I don't see why padding specifically would be different from the other tests here. > - if (!freeptr_outside_object(s) && val == SLUB_RED_ACTIVE) > - /* > - * Object and freepointer overlap. Cannot check > - * freepointer while object is allocated. > - */ > - return 1; > - > - /* Check free pointer validity */ > - if (!check_valid_pointer(s, slab, get_freepointer(s, p))) { > + /* > + * Cannot check freepointer while object is allocated if > + * object and freepointer overlap. > + */ > + if (!freeptr_outside_object(s) && val == SLUB_RED_ACTIVE && Seems this condition should have been logically flipped? > + !check_valid_pointer(s, slab, get_freepointer(s, p))) { > object_err(s, slab, p, "Freepointer corrupt"); > /* > * No choice but to zap it and thus lose the remainder > @@ -1370,9 +1368,14 @@ static int check_object(struct kmem_cache *s, struct slab *slab, > * another error because the object count is now wrong. > */ > set_freepointer(s, p, NULL); > - return 0; Should set ret = 0 here? > } > - return 1; > + > + if (!ret && !slab_add_kunit_errors()) { Also 5/6 of slub_kunit tests now fail as we increased the number of recorded errors vs expected. Either the slab_add_kunit_errors() test above should have a variant (parameter?) so it will only detect we are in slab-kunit test (to suppress the printing and taint) but doesn't increase slab_errors (we increased them for the individual issues already), or simply raise the expectations of the tests so it matches the new implementation. Thanks, Vlastimil > + print_trailer(s, slab, object); > + add_taint(TAINT_BAD_PAGE, LOCKDEP_NOW_UNRELIABLE); > + } > + > + return ret; > } > > static int check_slab(struct kmem_cache *s, struct slab *slab) >