From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E196E77188 for ; Thu, 2 Jan 2025 14:09:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E8976B00C5; Thu, 2 Jan 2025 09:09:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 397616B00C6; Thu, 2 Jan 2025 09:09:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C36C6B00C7; Thu, 2 Jan 2025 09:09:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EAADD6B00C5 for ; Thu, 2 Jan 2025 09:09:01 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6F00D1A1650 for ; Thu, 2 Jan 2025 14:09:01 +0000 (UTC) X-FDA: 82962691308.06.42F70A4 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf23.hostedemail.com (Postfix) with ESMTP id 4EC2B14000E for ; Thu, 2 Jan 2025 14:08:24 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=cIsBiIYs; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=oKeVYPSA; spf=pass (imf23.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735826899; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N2DdZNZTiT2hUXPOpRkS36Sd9f/OI7pHQw7NeaO7kuI=; b=GWEKS8Tc66ykLY7Q5IxmE/M2w/5g/3JYcTmd+GXmxXeWbxLasVa5zN6loH1uxNg9MTEdYc xF5DQ0TdCdvHsm/2Z1802ZuF5JF7Kdzx8wizDTpbJzP4lZQ+phhl8bOpg6d8RGDUu8buoR UE6FDZ73l7og1v/VmbL/2fQsgcBP2VM= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=cIsBiIYs; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=oKeVYPSA; spf=pass (imf23.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1735826899; a=rsa-sha256; cv=pass; b=7H0pyFzaqGojXmoC5FMD21Jbdy7mnxG0aoXRRDpDBvYuzSrNNNrbi/GjdXaDK4qUZ+TgIb Vg38lJFbpz4PYiPX2La+RHzcaG3Y2Eg56NqJjknlhqWKU1dQ8M1aCY8dJWBlXzInG+nh// //UPZLR8u5wTokO6Qr83+b3317h1Tk4= Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 502Du4ck019893; Thu, 2 Jan 2025 14:08:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=N2DdZNZTiT2hUXPOpR kS36Sd9f/OI7pHQw7NeaO7kuI=; b=cIsBiIYsVFIKiHMDeJcsHn5GBQjKMxzQNp R+K9DqoC9VT0YsHzc4HeyHxgEvw26NfRgfjC00r2Iv9CWNchoxO1/jVGKE0sX8PO 6e0Kwg6TOYGabfhPhwKKMGIlWSsSiU/Zv3gKiFiaLDU7Cm/NyD/dkrrztFT/I5ib +NxPPz8wet6E6eY55fXAu33HppG31kBAK80OSFkRUzPtBIh/IG7X0CTD++jniZ0j Lso+EaZ16r/LxUyg3AW7c6SOiD14f4Dyg2sU54SwIql8ToIBUaTRhBP56rns6NVX wUVSLfJ3XLlEvGc09RKQBjH/z9wExZlQTf3UhEv2jIzlX3nARP1g== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 43t88a5e8j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Jan 2025 14:08:15 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 502Bk3x7008492; Thu, 2 Jan 2025 14:08:14 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2175.outbound.protection.outlook.com [104.47.59.175]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 43t7s8tveb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Jan 2025 14:08:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RazN3KWvwWPp3if9MMH9oyjRQUJTCgXdFBOFMft2Hg3ab/vo7guQjyXmxnyIKRaqdzLjrjeqN+iWhcVYh2qUSlCcf2YZzqAOQHRITIYa3pOPbc/H3YoSDxRbYawuWtdpt9Z1CII2ggxBv3Ga0dXrP75dtSlrhHvawPEiFXtSzpJjnu+HpuW3c87Ak9f4WuNMLJOhplnv5Mz8GBZ2unKfQg+UfeSzwjxyHVAXfQie+VbJDs7Jtzz5yspYtICzyWFUxsV6HLrYJNheImcgtFtL/ACrTVwtRLZ6DXp0Z8p9ZP6+Q1WAbGUpjzW6VTHk6cvn4+4X4Bjwbg1mCgbczQ9Wew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N2DdZNZTiT2hUXPOpRkS36Sd9f/OI7pHQw7NeaO7kuI=; b=R2NnZP6g7fHI/2QUtKAMIUV0gBxKDUTwRxoUHj7lFixsD3SnX0/Jrv6rvRy80u8/lVbXCBC9+wfrsH+CrvfXBfyB8JpI083y3xZFdd/zFGluSlTu/teOEEXHD5YMFeMb/LC3YO5ikow7uYvNLltWSJbgUY5SaHVVAinX+GFAAP04k9zIAKKqIZhnAZczOo7K5hnwfPOSZAGtP4uPZaO9/056SFlLvS0SxRYv3nvteAPcXSxIJMn4rHR19vzmGR1XgwsiszPyQgZmWYmZLHLhRzu6LCpioT8i1R1/yqBgZmqYOcqidZZZxqXdcGLcGQ01t/+8DsVo1DOe+iOcZy4FSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N2DdZNZTiT2hUXPOpRkS36Sd9f/OI7pHQw7NeaO7kuI=; b=oKeVYPSAVJMGnGHQCG+S9/vRHt5o0Ihp8fBM5rP1C+BIfATInGMSGPbrjgQsT83KKeBfI+iHPbut9eztb7mOuCzQYXjdp7n1MjAhTtGlqJ1ovRkdVFe6ydj/0SilSafOAonuamEJ+vRf8QV+3OrrbrOwE1rt0FcvMqQ4pD+b+dc= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by PH7PR10MB7694.namprd10.prod.outlook.com (2603:10b6:510:2e5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8293.20; Thu, 2 Jan 2025 14:08:07 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%4]) with mapi id 15.20.8314.012; Thu, 2 Jan 2025 14:08:07 +0000 Date: Thu, 2 Jan 2025 14:08:04 +0000 From: Lorenzo Stoakes To: Kaixiong Yu Cc: akpm@linux-foundation.org, mcgrof@kernel.org, ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, kees@kernel.org, j.granados@samsung.com, willy@infradead.org, Liam.Howlett@oracle.com, vbabka@suse.cz, trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com, tom@talpey.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, paul@paul-moore.com, jmorris@namei.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, dhowells@redhat.com, haifeng.xu@shopee.com, baolin.wang@linux.alibaba.com, shikemeng@huaweicloud.com, dchinner@redhat.com, bfoster@redhat.com, souravpanda@google.com, hannes@cmpxchg.org, rientjes@google.com, pasha.tatashin@soleen.com, david@redhat.com, ryan.roberts@arm.com, ying.huang@intel.com, yang@os.amperecomputing.com, zev@bewilderbeest.net, serge@hallyn.com, vegard.nossum@oracle.com, wangkefeng.wang@huawei.com Subject: Re: [PATCH v4 -next 06/15] mm: mmap: move sysctl to mm/mmap.c Message-ID: References: <20241223141550.638616-1-yukaixiong@huawei.com> <20241223141550.638616-7-yukaixiong@huawei.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241223141550.638616-7-yukaixiong@huawei.com> X-ClientProxiedBy: LO4P265CA0181.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::8) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|PH7PR10MB7694:EE_ X-MS-Office365-Filtering-Correlation-Id: d378f103-49d8-407a-11f3-08dd2b36e1ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?xx0TjvQz2GfJWD6KdWaR2lZQs3d4pAkIdk6Fv3YVSPqSNr7WL4tb+CTv+8ao?= =?us-ascii?Q?oj3VXvP5cSeiBTegoejwoaulLKORinO8bzRyxGxJdgf9mWGmuBm9iYOiIQiB?= =?us-ascii?Q?pDmXwlfIHZRj+v2fVyHweUxCmlczElBVYmBYF8GiTooNcjKSuw4j6PszVriw?= =?us-ascii?Q?GYrE55d4sAjUTmHswksGscVqtyaU251L+Tb2plvqefqfiXubfevrWBl0cffZ?= =?us-ascii?Q?HBBM/f1f3AdgxnNaVsxa9FuJv+ltyqygEx8AKCtL8yHAEQnKTf4CWr+LzhLG?= =?us-ascii?Q?UwEy1hU4WamKuEep/tynIscRx8fhl2vYBbsc+RetVMP7avommDz+D/7DeIYY?= =?us-ascii?Q?ne6MchSVPcYPCQ0he7KtTKKOr3gH3mAclzFr1DOjOBgSNxl/hls0TZ57Oxsw?= =?us-ascii?Q?hTFFiK1o2gSmnNnRs9ga458L5QW2l+qTz32BDLSpz7ghZz2m8RwSfTN36RUn?= =?us-ascii?Q?I8oPvW3x+wQlFguuBbzKdSNqzQp4jORL+XPL2QSJSyDX9+/1hi9lhnMNFCK0?= =?us-ascii?Q?s8IDvA4IH1ujxaIJyQLYedmZ6l4v/8wy2jGP7ybdgML10UWtO7yybvFxCJ0X?= =?us-ascii?Q?d7ySymPEsgzNMdUmHBPBZmTDUUqji9iL0RaW+GItObJcCUdDm+zV+E3kKY+O?= =?us-ascii?Q?4WSYPmq0nU+rtBsXiJCQIR3mzqK4KdKsDzAibNM9w1TtdsWu3LXVrP8Iqa9Q?= =?us-ascii?Q?K8ex0yBawcHHfUeUVurfAdTuvRDJbzahyCwNzyxmxSZVchl8+Lz+KnyFA8ag?= =?us-ascii?Q?NfglC/Z3IIvDHjiteLZ3gUiAHy5GLoIQWSeo9oZ0LhxqksUYlqCKNW6jc2gm?= =?us-ascii?Q?6uvbJFhFGSZKDteatPCta0U7tXh9VQlcARWx00EWVJypauLSjQo0NTn1iUHu?= =?us-ascii?Q?lM6j9hYJpL3UctHXllbW6nJQMzBR2xQ9oig6Zuloe60UIZXEkGA3g9ypVcX4?= =?us-ascii?Q?Q6U5XJjTFcPL7kk2I44j2ldEvbvTFDmMcerQOtQ5/Scb4StjXJJQ1qxmcEwr?= =?us-ascii?Q?0iUO7prYK3R/e1JQSHmiwVapmIvzXX671ghuaHtfKJ/tmBqiAYsLk9L3iYaA?= =?us-ascii?Q?Di1Ypti9+0p+X0POgGGxjuXUkphvWcnxzWoqQFPoG/n0zSE0SJXn1uDlGqIO?= =?us-ascii?Q?mA29U8+dRH36z9jJJLppzOOEc5Uo87dFDG0cB9XmvGtvVgbTkUjZWnan4xrd?= =?us-ascii?Q?yeyhYCsHkmTsOJcWSG8eMjm3IbbpnXY7SgvHXBrtS9BsGVEZdC3h3QVxpSit?= =?us-ascii?Q?rwKi3jSXAfB+/hrniNui52cgr8+byzeK/EN961VK2yQNbR2GsZ89nBh4ztEI?= =?us-ascii?Q?2iWKXn6ybT9BtRf+Dr0RDeRWrNNUVXnYwzj+PkOMyeKXMVSx/mblLtjSgbUe?= =?us-ascii?Q?2OSncmKjDEjL687ObvvubqHbdn5Q?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3N3XzXuxeyTZzfMyzQBgHtpp93tHu3YO2UxwBq05u8OBSi6TzaxtbIMp+sgB?= =?us-ascii?Q?B9rSGoSNkHPlSV66gxZ2YCgqw8oLgkM3/iaIj1NGkxf/0rHULy3c+zkoKreF?= =?us-ascii?Q?a3iF+ukWsdSQ0uXw37Qp0IEjNyLvP3WDN/gq0HaBsKG1IBDuhgPw6sIdLL02?= =?us-ascii?Q?MxTy5up5Uh1pkbnnoO+VpXOospLkTlDraUIBU3s+WAssVK6ZGzDa9kWahDnz?= =?us-ascii?Q?w9yY6HW2uhhZz2hiQTFWWbetBndxMxeV7kY8wow9vR9rmRWE/CfEr9jYmbNz?= =?us-ascii?Q?bbRM26L8Qrbpw+2mw4HEi9nkbkItLEiLMIxzNaAo7MX5R0j2sqfZHe5X29AC?= =?us-ascii?Q?jr+PxuZZZhBj1zV3730og71TFDfCBz0wCXiHiVSsZ4JHc7rIafQ2l6WCBB5V?= =?us-ascii?Q?hlmcC1g96hCuhaa2jLhFIf45UeHWvvA+yGRNADKCE93sBJwqyJP35N7x2b1T?= =?us-ascii?Q?0y91D+4La7Kcz0KIuBscE+bfal6HrxfZiIIm3jRdoIOyuFU+tszEC5vPH+a/?= =?us-ascii?Q?SGVPnI6baCP4x24GYDPNnS+C2E9i00QxVHUNTcYgCWFsgH0m9OsNR2PEauk3?= =?us-ascii?Q?XiUcuixIlBA559n6zlCE3e2IfNwMxFXND8EAiNf27LC+TLYrhuUPSP2Novkm?= =?us-ascii?Q?i0AXypiMW9F6Zt8b/kdv39WiwYS4k4c3Pdx4nGEI1hXa77wCLc4So2rY7NDZ?= =?us-ascii?Q?DGILjP84Lae7mnzbnfHZx2Sue2x/+5RfZFlUwDV7mT7/BWR2xycK9AbrXBr8?= =?us-ascii?Q?pjxbneJUOufCjUS2HjezFPBCd/B/AarKAoyU60XWwAeABlJe0W5TCpsP8vcc?= =?us-ascii?Q?4MHHnHKUXQs6IUsa8LtSjBu7qwCoSMNhkomBy9GUlALBDhab1xP37/xJlg8f?= =?us-ascii?Q?5e4pBmeUM8IvNnei4mwTP3PfeLQ5b82JBSxjoLGq7vo6y/QQRoMQfpxq0B0f?= =?us-ascii?Q?zePJ9pjxZHmUCsKZRu7apuqt990xQfpf6ySQi9NHrGxID2X4GMsuZVFGjz5k?= =?us-ascii?Q?sAw6v/+yB6KFjE2fL3rlnI4+nKx6e50kghhkonvivtej3nsnNzYnLFr4YNVJ?= =?us-ascii?Q?lDDTXrhDbitXBsBtBA07dq6reJAQQFfPevGHfPVb8j9t7H/+KRsWTd38QHX4?= =?us-ascii?Q?Zn8ocn+D6Bi1SOL48Ed7f3C/YZ4C6P7oRjYmdKd3y/yebUcyE0UcV4AfxFAk?= =?us-ascii?Q?KD/qZhWxU1dFgtT6am3if6BXH3J0Sebxz9GTKfvn4lXELFUwbEPHr3r9TZuy?= =?us-ascii?Q?J1SPK6v/xO+fPSvhdY+44fesxTKNGF5bmn1oUGNirbHosbudTG4nlwmV+L6W?= =?us-ascii?Q?3ToJCzFi2ZRgPhKo8W2kPKq0Pfr4R0oAspHZF2yknNKvlj5RJjnyFaAsIEMA?= =?us-ascii?Q?HE3XD6o4VLDeyPD+SkXc1FEO0vGqu6dR+VzSQ4UPZ5IjSiFBlwKNlIg7SYuH?= =?us-ascii?Q?RJXnfks6OJC8gLAERnsKUeeFuYmzaPc2Z1mSJE2K31E4ua2lnSAWjkNh9N/a?= =?us-ascii?Q?XiNVsLZc0ZVeZbEI+jgI9cW7mypjrYegAZo3f2LecEqJgeK07dQL8ilAXskr?= =?us-ascii?Q?n/fkITZgEuVahU3y6goxISw84Sdl98tRezPOzqpt1e6LqgemdjIseOHAFV1F?= =?us-ascii?Q?7w=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: GmSCc4sdeScesQWM71rNNLpxIrIAWbwZsC7pTclm5LHc+AU07wbXuJa57O3sJ0JkcPVmvhSqKlc2HzqY5M0EzfV/HRFc50rv4YFPovtlwjKryAY275yqt8Nki3WrZyUnCwxqObqiJmPfmQTjmi/XHyrNSZlYU5KNVG5r4Daj7oMAu2s7wr2vdRaH8arqRkqGsTY9KPBTHd8PLymTuy1L27xHodnVcv+LO7CdAjtB6EZ8EAywqriFOWZFS74uPY8nj1RVjbQeha+H6x0OrFD4x61pskgvHDJWKUeZixeg5XNjwQSK68fYy93N9dwY9SFUh4vCbp4uy/Smmc5ZVq65av/FgpV2hAmfbgt8UOF64/CU/oDqsP1KwDYL32Ek1bGC1Ou0JlefLJeouSAHGPv72zpB7K88R4J61g0wgYuUp4xrnattilLlNrCSK8TmqgFBuXr0eC2/FDqNKD6vcFOQDekd5u0/bu/wXQyK0Iu5+F01j27xKMuGiuaI1YW8/rVHjfXdM2P9rODR1aun+BU29lzZPqN99aKCaz9XaoK0tTbU6S+27gm2Ye25ciGzBimwYZ3H2rI6f7IXaChvV2W4bkg8jMJJ4ee7oBQvQhGUxqE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d378f103-49d8-407a-11f3-08dd2b36e1ad X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2025 14:08:07.4480 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VJOF9IdoDJcjHlS8PkqAqfWDa0fFesd5QqRwtPTNaFu1714aKYuIYX1TeSyRarYyW68+yODXB9LpzqKZcH6NDIY0+B3bCvqUT2jqUeo0mKE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB7694 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-02_03,2025-01-02_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 spamscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501020123 X-Proofpoint-GUID: vn2DLHr64tu9gqDjwkN0tZcrR7SHeIrD X-Proofpoint-ORIG-GUID: vn2DLHr64tu9gqDjwkN0tZcrR7SHeIrD X-Rspamd-Queue-Id: 4EC2B14000E X-Rspamd-Server: rspam12 X-Stat-Signature: gnu8bw9eqyqchyg9k479dgs6xeytynts X-Rspam-User: X-HE-Tag: 1735826904-278795 X-HE-Meta: U2FsdGVkX180L2oJBKHCEACiPaMDwe6zq3pluJa7+P/1XM+2xs8757AuTG2bqDoOhJtuMVOmO3LEk4+8ZIWjbXlJHhC1qOsZn432m1ZB5P+TQeQk0iOIB0nIz3PTQKnKL+6PoEc1D/+3vqP+DqGDZ03pQY8N9kgbAXATjq45e9iZhyAuWFsFn/G42452DO9jDO2n75RVexAUefIEB6/3chyFmtVMONwuDIr4PiFmecPjWW1x9gi9ZZcp7zWCbc1F0Y2s1WoHH170IppPDg8KfVyakp9ZpvYk6hzd2W+9jjUtwuSb9o2pVCIgYRrWtnAM/bpW4NbGpbuSpSqfQM7gjizzL/C4aw9pJx6j9UA6gft3up/n5ldwkalm4dR7w/dQjFt0HpoAhjc+2DKaoSblZlW8Zo521HPiuxk12iFRoi/pwsUMEx0PcyCHUKJ8DSTWgrQBR/fAlzptLl6rx823Vojc+EhzinCcvQhQD25uaSZQfemnKk8fYcw0kaaq8HprxchUshux7KAroaZQR1PtR6R8OZIVEdZTMST1KfSND9812UIipSpBpIL7PIdD9J6UshTmEMwlK1/ag7efQJa+HFltk/gXiSKmXDsmmj1cYpx6wCN/wRQM/nXM6CV3ygMReS45GrGlcOonIQ9DeaJlKUOZ8NDYLJm6xRwXM/nMiKaXjr90LbPvLhux/Fi1BKFBWoCCdvB/ZnYevnuBpJWz8ekHb29Hx8XZog3QMV/W9pQ8yn7n64sOnJ9WS8eOi7BDl5OIinL82yi1mpdm4pYkuhSK5m5rcCW9bf9MB9Plz4ARhcURgLgjF4PeqcUfbNdOQfUNC4gGXdEDa1o85gUDJnef80eVg3YJ6wOdzK/un1UV0Bd4j139JoTYCqEViTr9zMO28xQSR6ieKjMqxi7p7fRmykwSpBiC6UnIf65y+uYbpIAj2PXzhb9kifkj9m4ianCpwT53qRotn22aKeq Q+5AzL5T WA1YrhASP9jT3QJmYK9M0AHufY6QeIYkpyfMnjzVeZMog5+Z2yfTs1dd4U+/hHb1uX+3BpYSwGsvkTxluFnUgpYLD8SmKQ6EFV+XPJ7JCXTxZwR264HMhJIJ4dXSrC6hf2eESaP+hFfkNtZ4yJhcTcz0WKq3EYGjHSZL2O3Uu5TgyPsyJhxx9uO5jG92SX57k79ez5d7h+iFJYJdoaD57G1X2c/P9h/pBc0gFW+VRNB1sCXWQpihfEvI/dmXftOjQUlcZrBo3x8bK169wMVZ/tqb0g8wqm/XCC0dl6I2gLaBBMgJ6NBfR4bknPpGqnl4LQ1rzUdSSmguTyAtykGmWor03rLvGI3Tk2td622c8+sWBq0lDxlcGzYQltQTevcZRcfQZyffMFo7c58yhH+DczIIZV0QxKi7rJ6xbD7PVlEsYgKmdwKSwJwAX+Bvaf8FFSHkHP5+djIvl1l2vn59KbAUsy5SVubx28D4GWh5ka1qUTQtVd1lcWaFq4v4hKalzTRxqk6SG6v4zTbySHZDAR9DsTIE7k5LmGj4hft1zIt9ihob8eB9nzj3qa+qR6rFchUWnOJ3gVvQ1QI2XrKHBP4apAcecdqw7oNdI5pCnSFLY0LY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 23, 2024 at 10:15:25PM +0800, Kaixiong Yu wrote: > This moves all mmap related sysctls to mm/mmap.c, as part of the > kernel/sysctl.c cleaning, also move the variable declaration from > kernel/sysctl.c into mm/mmap.c. > > Signed-off-by: Kaixiong Yu > Reviewed-by: Kees Cook Looks good to me, thanks! Reviewed-by: Lorenzo Stoakes > --- > v4: > - const qualify struct ctl_table mmap_table > v3: > - change the title > v2: > - fix sysctl_max_map_count undeclared issue in mm/nommu.c > --- > --- > kernel/sysctl.c | 50 +-------------------------------------------- > mm/mmap.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 55 insertions(+), 49 deletions(-) > > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index aea3482106e0..9c245898f535 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -127,12 +127,6 @@ enum sysctl_writes_mode { > > static enum sysctl_writes_mode sysctl_writes_strict = SYSCTL_WRITES_STRICT; > #endif /* CONFIG_PROC_SYSCTL */ > - > -#if defined(HAVE_ARCH_PICK_MMAP_LAYOUT) || \ > - defined(CONFIG_ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT) > -int sysctl_legacy_va_layout; > -#endif > - > #endif /* CONFIG_SYSCTL */ > > /* > @@ -2037,16 +2031,7 @@ static struct ctl_table vm_table[] = { > .extra1 = SYSCTL_ONE, > .extra2 = SYSCTL_FOUR, > }, > -#ifdef CONFIG_MMU > - { > - .procname = "max_map_count", > - .data = &sysctl_max_map_count, > - .maxlen = sizeof(sysctl_max_map_count), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - }, > -#else > +#ifndef CONFIG_MMU > { > .procname = "nr_trim_pages", > .data = &sysctl_nr_trim_pages, > @@ -2064,17 +2049,6 @@ static struct ctl_table vm_table[] = { > .proc_handler = proc_dointvec_minmax, > .extra1 = SYSCTL_ZERO, > }, Nitty, but this bit belongs in mm/nommu.c? > -#if defined(HAVE_ARCH_PICK_MMAP_LAYOUT) || \ > - defined(CONFIG_ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT) > - { > - .procname = "legacy_va_layout", > - .data = &sysctl_legacy_va_layout, > - .maxlen = sizeof(sysctl_legacy_va_layout), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = SYSCTL_ZERO, > - }, > -#endif > #ifdef CONFIG_MMU > { > .procname = "mmap_min_addr", > @@ -2100,28 +2074,6 @@ static struct ctl_table vm_table[] = { > .extra1 = SYSCTL_ZERO, > }, > #endif > -#ifdef CONFIG_HAVE_ARCH_MMAP_RND_BITS > - { > - .procname = "mmap_rnd_bits", > - .data = &mmap_rnd_bits, > - .maxlen = sizeof(mmap_rnd_bits), > - .mode = 0600, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = (void *)&mmap_rnd_bits_min, > - .extra2 = (void *)&mmap_rnd_bits_max, > - }, > -#endif > -#ifdef CONFIG_HAVE_ARCH_MMAP_RND_COMPAT_BITS > - { > - .procname = "mmap_rnd_compat_bits", > - .data = &mmap_rnd_compat_bits, > - .maxlen = sizeof(mmap_rnd_compat_bits), > - .mode = 0600, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = (void *)&mmap_rnd_compat_bits_min, > - .extra2 = (void *)&mmap_rnd_compat_bits_max, > - }, > -#endif > }; > > int __init sysctl_init_bases(void) > diff --git a/mm/mmap.c b/mm/mmap.c > index aef835984b1c..cc579aafd7ba 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -1603,6 +1603,57 @@ struct vm_area_struct *_install_special_mapping( > &special_mapping_vmops); > } > > +#ifdef CONFIG_SYSCTL > +#if defined(HAVE_ARCH_PICK_MMAP_LAYOUT) || \ > + defined(CONFIG_ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT) > +int sysctl_legacy_va_layout; > +#endif > + > +static const struct ctl_table mmap_table[] = { > + { > + .procname = "max_map_count", > + .data = &sysctl_max_map_count, > + .maxlen = sizeof(sysctl_max_map_count), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + }, > +#if defined(HAVE_ARCH_PICK_MMAP_LAYOUT) || \ > + defined(CONFIG_ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT) > + { > + .procname = "legacy_va_layout", > + .data = &sysctl_legacy_va_layout, > + .maxlen = sizeof(sysctl_legacy_va_layout), > + .mode = 0644, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = SYSCTL_ZERO, > + }, > +#endif > +#ifdef CONFIG_HAVE_ARCH_MMAP_RND_BITS > + { > + .procname = "mmap_rnd_bits", > + .data = &mmap_rnd_bits, > + .maxlen = sizeof(mmap_rnd_bits), > + .mode = 0600, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = (void *)&mmap_rnd_bits_min, > + .extra2 = (void *)&mmap_rnd_bits_max, > + }, > +#endif > +#ifdef CONFIG_HAVE_ARCH_MMAP_RND_COMPAT_BITS > + { > + .procname = "mmap_rnd_compat_bits", > + .data = &mmap_rnd_compat_bits, > + .maxlen = sizeof(mmap_rnd_compat_bits), > + .mode = 0600, > + .proc_handler = proc_dointvec_minmax, > + .extra1 = (void *)&mmap_rnd_compat_bits_min, > + .extra2 = (void *)&mmap_rnd_compat_bits_max, > + }, > +#endif > +}; > +#endif /* CONFIG_SYSCTL */ > + > /* > * initialise the percpu counter for VM > */ > @@ -1612,6 +1663,9 @@ void __init mmap_init(void) > > ret = percpu_counter_init(&vm_committed_as, 0, GFP_KERNEL); > VM_BUG_ON(ret); > +#ifdef CONFIG_SYSCTL > + register_sysctl_init("vm", mmap_table); > +#endif > } > > /* > -- > 2.34.1 >