From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1DFAC021B3 for ; Fri, 21 Feb 2025 02:26:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 447AF6B00CB; Thu, 20 Feb 2025 21:26:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F87F6B00CC; Thu, 20 Feb 2025 21:26:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BF6D6B00CD; Thu, 20 Feb 2025 21:26:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0E5DB6B00CB for ; Thu, 20 Feb 2025 21:26:13 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 63006A0EB8 for ; Fri, 21 Feb 2025 02:26:12 +0000 (UTC) X-FDA: 83142362184.12.C6DB6E3 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf29.hostedemail.com (Postfix) with ESMTP id 9C26B120007 for ; Fri, 21 Feb 2025 02:26:10 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf29.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740104770; a=rsa-sha256; cv=none; b=kG6jVTzlvtNH4C8fcxrH+TLclSTkyJuJSjR1BpZXl5uBG8ONLvT2X6zC1LFtBem+Mzcex+ CRZ43TGNYm0XWzdpEiR1ff+Xr4Mx4iBlppYDgZceOWrAB0tNQcwP6ln4woHa4DU+6sNMwU Lu4CIzQapaSUMQPf6sO2zBpl1THM5kw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf29.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740104770; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ADCQJ1r7H2WVgvt+oDda6zPiBdKTy64DNdcq9mx5828=; b=DtR8t/FdXOG+3AsQHBrwirxLguwOF9hLGBR0sHPHDP0v+Csz7UBggQqeY/UvF/ghroO0RU 8rTFKnIngQkoRQotXoef8pmwzqyrhbROj8sj2KG6MIIRlifH/M8WnCV6sfGjAcAdaN8jnW BrVU3sc+T4m/RbwBe/CccQQE0M82kqo= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tlIj5-000000006TZ-42Bn; Thu, 20 Feb 2025 21:25:15 -0500 Message-ID: Subject: Re: [PATCH v12 04/16] x86/mm: get INVLPGB count max from CPUID From: Rik van Riel To: Borislav Petkov Cc: x86@kernel.org, linux-kernel@vger.kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali.Shukla@amd.com, Dave Hansen Date: Thu, 20 Feb 2025 21:25:15 -0500 In-Reply-To: <20250221015801.GHZ7fdqaGFEvsG6qW1@fat_crate.local> References: <20250221005345.2156760-1-riel@surriel.com> <20250221005345.2156760-5-riel@surriel.com> <20250221015801.GHZ7fdqaGFEvsG6qW1@fat_crate.local> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-Rspamd-Queue-Id: 9C26B120007 X-Stat-Signature: 6ggmgnfdfy6kdoedme6ini33o75rum1k X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740104770-51028 X-HE-Meta: U2FsdGVkX19KlmMwSC5t385S3Cw27AtyxYxNa7yoWbspdr9mWhX42HzSB/sN4MJE+8qAnnHbFpuhbC0JIwe3UiN/FL057M0pI+y4anVdxsV26CZWWQkDfCEfBi4dicOUopOYiqB2Y59IXeJlnVYCMAVXAwcIYUf9/TONM1FNqmWgiooB3ksC0rnSNg8sX7WfV0OPw760OO0QNQ6trA3X/J32ZDHzml4i4RPzuQrVyV8ASMwJsZc2Li/LHGM+PQxw6KWUODaT7W7ScjQyLBMnpxQN21+GVzt+z2DB7AxU0TQu6wwOyrj0cGWbop5RnQ89SV9CU0+34Gf+bFlA+FslPACc+a6g+RHFKnjtHZf+9VTjzDw/2m09loeS8tlO9dEPxH0WaFtz8Nr7HWP010jK75rLCtf8oXSl1UfhtJwB1Mzf/WcjdZhgXDtsqVh7bwaLki2Z95VZuGNUZm3w54N9dsZLAEhVlbxEDNukWrjKKquUWQvlw/R0pnvwIFic13T+8xrQ/XlxrKFn1GsHzHEawSJPTQOM6kvFv27znll4Fk50WQJlBPwklNY29mXIStMSlGG167ury1A/ln8OzoKhOQcS2Z++X1dzGmqMGge/kiWaYPsxehgLE9795t3d/oRsPxyk1NTQ12Jl3IRxdtVqSMlKyWvfQb4KGZ1KJAWaDx5Ml/szovY1toWAIAQUAOxSHP8m+riaga8W8qrFFYDAEp2V6D9lckhESOLwzRy0uMGxyEsVmcKU+kA08w9yNlOGBY387erFOVAfAE1XxzlOfxJh8GOd9AYEZ1Yfzk2C5xyYBFx24y/LGag2VMKDIRySkIm0ubyXWT/QGaYc1A+DIMmwk6bk8oypvsO+7B48OuGBiobOLt+g94DKa4YXKOhCBSH9i+gQ2pdOkZunk1ODjqrLx5i7NWfzf+LlRhvUtK52PqaGg6KFn/X3IWbPTwUiD/IvDwKeD3sYULIpio8 v+PQhqNF 1cp9IHY4ge1IbFcFeT8nyKHYRtdILP5bV7BF0uMHEuU0qmedrInDNdxpAzzOJQdYRsQni37D/yjKvU7XqBbFkQAQWf4V+4bHhr3mdkoKKMAyllRhK3cp4Emx60m0RW6W2WXKiraZeXVQAO9kHL94qmx54pgP4vf0AMQEFp+NkOFzGIDaIwP6sFAzXTYHvmXPX9lt9opHOIjePDvXOI5PcuNwQQF2lbnTFyRHVzqwMWWKaWvd/DrNPSFXN/hwQTY9fWoduTxwJXyiAXs5QC9ORVsQpUH3jitxTUYK0E7AK8dj30+jSBrX8QC3p/+Lz4G+Xw9/12n9UvyUwzjlqV7BIrOwsvw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2025-02-21 at 02:58 +0100, Borislav Petkov wrote: > On Thu, Feb 20, 2025 at 07:53:03PM -0500, Rik van Riel wrote: > > diff --git a/arch/x86/Kconfig.cpu b/arch/x86/Kconfig.cpu > > index 2a7279d80460..bb6943c21b7f 100644 > > --- a/arch/x86/Kconfig.cpu > > +++ b/arch/x86/Kconfig.cpu > > @@ -401,6 +401,10 @@ menuconfig PROCESSOR_SELECT > > =C2=A0 =C2=A0 This lets you choose what x86 vendor support code your > > kernel > > =C2=A0 =C2=A0 will include. > > =C2=A0 > > +config X86_BROADCAST_TLB_FLUSH > > + def_bool y > > + depends on CPU_SUP_AMD && 64BIT > > + > > =C2=A0config CPU_SUP_INTEL > > =C2=A0 default y > > =C2=A0 bool "Support Intel processors" if PROCESSOR_SELECT > > @@ -431,6 +435,7 @@ config CPU_SUP_CYRIX_32 > > =C2=A0config CPU_SUP_AMD > > =C2=A0 default y > > =C2=A0 bool "Support AMD processors" if PROCESSOR_SELECT > > + select X86_BROADCAST_TLB_FLUSH > > =C2=A0 help > > =C2=A0 =C2=A0 This enables detection, tunings and quirks for AMD > > processors >=20 > You missed my comment again. How about you read review feedback more > carefully > please? >=20 I try, but most of my brainpower the last round was spent trying to figure out what to do where you and Dave both wanted something different :) > CPU_SUP_AMD selects X86_BROADCAST_TLB_FLUSH which depends on > CPU_SUP_AMD which > selects X86_BROADCAST_TLB_FLUSH which depends on CPU_SUP_AMD... I'll fix that to have it depend only on 64BIT. --=20 All Rights Reversed.