From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7435CC19F32 for ; Fri, 7 Mar 2025 15:57:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 29EC7280005; Fri, 7 Mar 2025 10:57:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 24C01280002; Fri, 7 Mar 2025 10:57:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1159C280005; Fri, 7 Mar 2025 10:57:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E66BB280002 for ; Fri, 7 Mar 2025 10:57:54 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 712BA80D59 for ; Fri, 7 Mar 2025 15:57:56 +0000 (UTC) X-FDA: 83195210952.27.CE0D15D Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 6ACCF100003 for ; Fri, 7 Mar 2025 15:57:54 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741363074; a=rsa-sha256; cv=none; b=dKGLVumZ4kJ+rU3cu6e1jyaMF7QYR0Ez/6LE5Cbc4ZeehxJQRR2G5jC3DGWC/o5M7cekXb I9ao8YkQH9d4bM9UJUCdmq1GT2AwpEepCnTv+g6QwngdzY/WrdV+nx5zcEnUb0Ep6kr5+g LI2/8liwg+nm7qKcDmkNzZYz1YuW100= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf05.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741363074; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fRDrJH1m2u038pPBi26MkMxgn5EvMPa4VcxYn0IQTwM=; b=J5jzn1VDGlMnQoOOMqvLvMHvTYVnA5qWSUNiXcZPCK/qKBtdKtqTKR/vjK0Qikey23n84M gAOd9mtJ/9J7SJOrQGd+7j73TCYVVKtslfXFNzr3anhgl997ayVaL5RhMKLFUAgbKiFEIv Sf5841JX1dvkGYzf0RG7Dh4OOuIaZ9w= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EFE701477; Fri, 7 Mar 2025 07:58:05 -0800 (PST) Received: from [10.57.84.99] (unknown [10.57.84.99]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 496F83F673; Fri, 7 Mar 2025 07:57:52 -0800 (PST) Message-ID: Date: Fri, 7 Mar 2025 15:57:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm/madvise: Always set ptes via arch helpers Content-Language: en-GB To: Lorenzo Stoakes Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Hildenbrand References: <20250307123307.262298-1-ryan.roberts@arm.com> <03997253-0717-4ecb-8ac8-4a7ba49481a3@arm.com> <3653c47f-f21a-493e-bcc4-956b99b6c501@lucifer.local> <2308a4d0-273e-4cf8-9c9f-3008c42b6d18@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6ACCF100003 X-Stat-Signature: n9seqsi4q3d3xgchdwih9crenbzepray X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1741363074-318552 X-HE-Meta: U2FsdGVkX1/7XNXBv2GIYkIoj1Pv7dM4gW6SUtjKLP4NUnlo27QZh0sq+vZWkt0KI3QB5UAiaPVkw6QtYhGU5N9tFmsljIp+6H44jufAfuZ++ZonF2dRJ8BO8xPCqvWHUmGNbZsoeoQYtqPywFJ43y+sQ5oi0CtfDXKHSpkWdkdZ7xX93YclRpShsDm5bEFoqSNOsHS/tU/yJiTUh7NUJ+aBeZh5UyvnOrOMYlSzMErTEBKi+9wZggMVzQPYmjurIeT1NWvy/FrRVVkd4cmKjqiVjNRc7Tp0QsRvbBkTty+H9JLOVpUnVO7oQ7ZFLDMalH2y6AKJzEjqQNIlH1BwBFM3WhpZXHWrdOfkNETy9tGQvRB5ftHBlzIs6YO0rsfIqjpdDoizm7LTkw7t0/R6k2G3m4fY+OpGOIHShApaQJ95Vn0rP+1T3q1zhQpl9wq991zrm1N+pW7P8FX1nZWPM0iGPE6D+VQn+CATEq978IHRTkkeEuz8rWv8LY2BETc2JcFcF+G9LiSaRwtqUvRabr4C67EsARtc/KtUKSPEiSlFKUarCMSb51crwUgKhEbFJePVR16JbQocCsC0/udU3t+83PbAknu+JnzJtf44qIkUT+B1fbcWNNyP7nCe06kkxrQDoOnVKsAbmPuO6bJEbKpWuOEDFaT8YHuIeYyWnmAHW/xFzGD31RyzVu7KvW9vQ7nzkabFyxwBdwoghGfeqcEq+ijVQAEi6duiNV5USgkfSf1jZhfLyBOoyJp1LnrTvL+VTqr1G6z8O/KyfMIl+r99UONG05a0AWnQBlemrzyw0QDoqFnVMZLPi83iHbwHuxVRZCIHx2n4v9oIlxAOdUXYfCDxQxQj/JStPqtP+3hA178ihtep9Vol2CbJJkFqyyETIIfC1SgTX0aYdX1aF0/Wit2GSWkTHxkb4mGyxLpDpgpa8naCCTrIc7T5vHiiyos2Zs5EcuGk5ig7ezR IFpZCSnF qqh7G9NYj6MEH5/Tivp5tI4xLttp7Pc4Tjz754OllTdbADYVUgoxtXFD5c6A7bk+60NnVwMyea1v24PioMqIad0QJIdKQbDCNMUHmcQW9g2GrlY3Z/9/+PaDzyTreNgeOzjIKN2XWkPlOohw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.300427, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07/03/2025 14:55, Lorenzo Stoakes wrote: > I'm not necessarily against just making this consitent, but I like this > property of us controlling what happens instead of just giving a pointer > into the page table - the principle of exposing the least possible. Given the function is called walk_page_range(), I do wonder how much insulation/abstraction from the page tables is actually required. But I think in general we are on the same page. Feel free to put looking at this quite a long way down your todo list, it's certainly not getting in anyone's way right now. But given it tripped me up, it will probably trip more people up eventually. Thanks, Ryan