From: Ryan Roberts <ryan.roberts@arm.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v1] mm/madvise: Always set ptes via arch helpers
Date: Fri, 7 Mar 2025 15:57:50 +0000 [thread overview]
Message-ID: <ef069b96-aeec-4974-bbb4-59bc11a6d158@arm.com> (raw)
In-Reply-To: <d9cd67d7-f322-4131-a080-f7db9bf0f1fc@lucifer.local>
On 07/03/2025 14:55, Lorenzo Stoakes wrote:
> I'm not necessarily against just making this consitent, but I like this
> property of us controlling what happens instead of just giving a pointer
> into the page table - the principle of exposing the least possible.
Given the function is called walk_page_range(), I do wonder how much
insulation/abstraction from the page tables is actually required.
But I think in general we are on the same page. Feel free to put looking at this
quite a long way down your todo list, it's certainly not getting in anyone's way
right now. But given it tripped me up, it will probably trip more people up
eventually.
Thanks,
Ryan
next prev parent reply other threads:[~2025-03-07 15:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 12:33 Ryan Roberts
2025-03-07 13:04 ` Lorenzo Stoakes
2025-03-07 13:42 ` Ryan Roberts
2025-03-07 13:59 ` Lorenzo Stoakes
2025-03-07 14:35 ` Ryan Roberts
2025-03-07 14:55 ` Lorenzo Stoakes
2025-03-07 15:57 ` Ryan Roberts [this message]
2025-03-07 17:43 ` David Hildenbrand
2025-03-07 18:04 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef069b96-aeec-4974-bbb4-59bc11a6d158@arm.com \
--to=ryan.roberts@arm.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox