From: David Hildenbrand <david@redhat.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org
Subject: Re: [PATCH] mm: Fix Kconfig indentation
Date: Wed, 20 Nov 2019 15:36:44 +0100 [thread overview]
Message-ID: <ef0008f0-b017-8909-9797-0bd623f7772e@redhat.com> (raw)
In-Reply-To: <20191120133759.12629-1-krzk@kernel.org>
On 20.11.19 14:37, Krzysztof Kozlowski wrote:
> Adjust indentation from spaces to tab (+optional two spaces) as in
> coding style with command like:
> $ sed -e 's/^ /\t/' -i */Kconfig
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> mm/Kconfig | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index e38ff1d5968d..27b7e61e3055 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -160,9 +160,9 @@ config MEMORY_HOTPLUG_SPARSE
> depends on SPARSEMEM && MEMORY_HOTPLUG
>
> config MEMORY_HOTPLUG_DEFAULT_ONLINE
> - bool "Online the newly added memory blocks by default"
> - depends on MEMORY_HOTPLUG
> - help
> + bool "Online the newly added memory blocks by default"
> + depends on MEMORY_HOTPLUG
> + help
> This option sets the default policy setting for memory hotplug
> onlining policy (/sys/devices/system/memory/auto_online_blocks) which
> determines what happens to newly added memory regions. Policy setting
> @@ -227,14 +227,14 @@ config COMPACTION
> select MIGRATION
> depends on MMU
> help
> - Compaction is the only memory management component to form
> - high order (larger physically contiguous) memory blocks
> - reliably. The page allocator relies on compaction heavily and
> - the lack of the feature can lead to unexpected OOM killer
> - invocations for high order memory requests. You shouldn't
> - disable this option unless there really is a strong reason for
> - it and then we would be really interested to hear about that at
> - linux-mm@kvack.org.
> + Compaction is the only memory management component to form
> + high order (larger physically contiguous) memory blocks
> + reliably. The page allocator relies on compaction heavily and
> + the lack of the feature can lead to unexpected OOM killer
> + invocations for high order memory requests. You shouldn't
> + disable this option unless there really is a strong reason for
> + it and then we would be really interested to hear about that at
> + linux-mm@kvack.org.
>
> #
> # support for page migration
> @@ -302,10 +302,10 @@ config KSM
> root has set /sys/kernel/mm/ksm/run to 1 (if CONFIG_SYSFS is set).
>
> config DEFAULT_MMAP_MIN_ADDR
> - int "Low address space to protect from user allocation"
> + int "Low address space to protect from user allocation"
> depends on MMU
> - default 4096
> - help
> + default 4096
> + help
> This is the portion of low virtual memory which should be protected
> from userspace allocation. Keeping a user from writing to low pages
> can help reduce the impact of kernel NULL pointer bugs.
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2019-11-20 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 13:37 Krzysztof Kozlowski
2019-11-20 14:36 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef0008f0-b017-8909-9797-0bd623f7772e@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox