From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B14EBC369DC for ; Thu, 1 May 2025 14:11:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D67D6B0088; Thu, 1 May 2025 10:10:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2852A6B0089; Thu, 1 May 2025 10:10:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 125FA6B008A; Thu, 1 May 2025 10:10:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DD9226B0088 for ; Thu, 1 May 2025 10:10:56 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8CB3780C7B for ; Thu, 1 May 2025 14:10:57 +0000 (UTC) X-FDA: 83394525354.16.0F1C591 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf16.hostedemail.com (Postfix) with ESMTP id 05450180012 for ; Thu, 1 May 2025 14:10:54 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=akdthsjn; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf16.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746108655; a=rsa-sha256; cv=none; b=Y1cbJOj75LuBKrDik4i0Ze+iXd422jNoSgWcIZpdL/SvslamqjzFgk6G72wskgqKLOOMtS 9Ip5WDQswd8ghwsc6kSvDBB3GuLtu8d9WlpeBmh9XduErutn+rjWWeACSR4zQDWvI0Z+Nu n1889VwV/iTNjPWhTwG342qoJmS4bUs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=akdthsjn; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf16.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746108655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l70TwKmPbbUNPJBQcsTTi97Jt0SmLosu6cNfY4ZVL3Y=; b=NveYq8Yrn7OUi8G/bnBGrz5Tqf1ZdtxOSjm2kW3BnWV66msF9/uY2UZdhV9EuNZtRlxpst bQmRqEIiVyQuve4aIRlGGjSiS0Gkfj6mMZ/or4eQ0VvuJaivoiaaA+sVO45MbkEtLQCjEA JZLwvCpfNrdL/KQO4n08LbrzLlAddCU= Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 541BovuK027337; Thu, 1 May 2025 14:10:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=l70TwK mPbbUNPJBQcsTTi97Jt0SmLosu6cNfY4ZVL3Y=; b=akdthsjn58t/aoXJ4cFpBg W9ZPaEEj5GAWkwX6u/2/TmvIRsoj+4KO1KZcFBFRj9u8bNZgrhO+eXM/9+dJVgA9 mYxTHHt1DlnBxb5AhXkrmlOpmNn1CS2ODmzuVcdsMwxaQLhXStPggQnwOdDYWniD 46pXyp/xjoPpe2BDiVeiEXOB6lXIjmqRfItBmkPgtRzUo2E1lpluOhqg8So74/2K 1Y88Cq1gTSknWcZ46h9WSwsPUeQ5+exVMCEnfHzBVUecJUr6B6zDa2B4AGWrVo+X MmavU/ecXDKRazGn09BPw9n4BfloemsYrQ4HvoaZrwpEZ+RFhNTgMENYTJHGFkbA == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46buy93j1k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 May 2025 14:10:42 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 541EAgLL030074; Thu, 1 May 2025 14:10:42 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46buy93j1g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 May 2025 14:10:42 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 541C0HhA008518; Thu, 1 May 2025 14:10:41 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 469ch3d4qh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 May 2025 14:10:41 +0000 Received: from smtpav01.dal12v.mail.ibm.com (smtpav01.dal12v.mail.ibm.com [10.241.53.100]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 541EAeXd66847178 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 1 May 2025 14:10:40 GMT Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3D7E858057; Thu, 1 May 2025 14:10:40 +0000 (GMT) Received: from smtpav01.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5478558059; Thu, 1 May 2025 14:10:34 +0000 (GMT) Received: from [9.39.16.182] (unknown [9.39.16.182]) by smtpav01.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 1 May 2025 14:10:33 +0000 (GMT) Message-ID: Date: Thu, 1 May 2025 19:40:32 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] driver/base: Optimize memory block registration to reduce boot time To: kernel test robot , Mike Rapoport , David Hildenbrand , Oscar Salvador , Greg Kroah-Hartman , Andrew Morton , rafael@kernel.org, Danilo Krummrich Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Ritesh Harjani , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , linux-kernel@vger.kernel.org References: <202504300024.YxAyenLy-lkp@intel.com> Content-Language: en-US From: Donet Tom In-Reply-To: <202504300024.YxAyenLy-lkp@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTAxMDEwMyBTYWx0ZWRfXyyCklGBK9z6n WV0FN2Lw1S/4HdP4WMg1kXbYyDRTjicnudctzpxC/icDYmWJLKxsh/UCwBnI37e07rzXwcmmXWr sT06B827uQml2IjZvVvpNKRmFWbV9sMtsSSf8htSwVV/0jMeKvWC5ZwXJB9UKSLFC34iwgrLZjp pl9VudFEFwR3gZayND4v1WjXCkRSWjQ9Cep0hDagt7h4LHY6qvDU8BKXXsNBxHxQmk0R67Xtr09 NRqT8pCVQ3JIXqd8ZmxjG/SPtBw4aZd8//HEm+jfJbbhjNzL9Oa/3iqtqKP1q/lWrIAUqWLuts/ h8vXtDm/9q8yjtNLv5uiYj40eFLGpZYQ+I8x5ATUCOTmDZv2E+aKn+gIoKN1JbYuMQT+hxQsR2t nUGa7yQP0da4zP/gslT/cDLWlN8sQJ9pD5Rb4gkhMhA93bS0g0J+m94Ya2gb1pOupX/Hgfx3 X-Authority-Analysis: v=2.4 cv=FOYbx/os c=1 sm=1 tr=0 ts=681380e3 cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=anyJmfQTAAAA:8 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=i3X5FwGiAAAA:8 a=QyXUC8HyAAAA:8 a=Qydo1BIZeAhsg4m5zJgA:9 a=QEXdDO2ut3YA:10 a=mmqRlSCDY2ywfjPLJ4af:22 X-Proofpoint-ORIG-GUID: iYr0RAGbRdlNFWnmlUeZrkRvvjGST1j1 X-Proofpoint-GUID: W4pxqsK7vzszLGTcSSCcyhQ042Wnb_nu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-01_05,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 adultscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 clxscore=1015 bulkscore=0 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505010103 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 05450180012 X-Stat-Signature: fp7zie1tp9zqphzry5jdzemzh5tqe9uh X-Rspam-User: X-HE-Tag: 1746108654-316953 X-HE-Meta: U2FsdGVkX18Fc1AqcFiNNItjlw1Rurz+aAeUKDlpvze7kgWZIbWKJ3yCudBTUGFvvQqUMOQKTyzgjopg+9g+mCRdS8Bw3pFMkJGVGQpiDzt01iTpOmC1hjaYcCSLYqjxa8QMHrHfDfsCyCjpu+aKskRaoonFHaKXZp/1IyUYMv+ITqNOe3sfsi9n5kFhcFDpqrx4TKsVNq7aOQonLjiQ6YcrEN6zs068m0AvnaieXO2cfzKC87c+UDw5SPwfw+pnl9OSuDNdIXsdZ/ForhGB+3JOstNE8cDxc4MBB2NSRlQTpOlBk7pB9uzHeGOXaAOH+cpxK/xw8lBNVHvYM0Yjc7FcXdjttr59yTgaBb0m7o6FL6emG0A0voby61RsLsEziv+uGDym+PbIW7DhNpWXqJncHCq3R/8Ehl8iQSWohUeoxGObckdLkmqUGKkhCw0Qbuc5IXgjelAamfAzU/3KYtsOLKfrVQOPCcWrKLj1qDQBPtxt1zLNpCaCeUaQyJQbd57SypuRPftC/18v4cR/xLdwmAh18Z+GzSiGMFOJ6VqtlwA2vv1ACoPCKOWUc6S2HRat84HI9Zf0Gdcu/bSPL0fRzAiCiH8cm7rFwR9/+q5Wv/pgdvAX7F/0ztErqdeNIPuja9HAJ9w8QAazpCm9st6LMMeciWubmS0SaVSy80b8cg42MxY1O+U0VTr7lgP7aml5Li+IzTLRiYH+C0pc9QId48GpknPf0xcjT5zOdYjBypAjqcE2sfhNFL5PG3d9go3RuPERrmtaZ2N+2O0I1YJlnqEjH6lFanzrcvgp9bwtgT0aGKRp9IDk5y4MT+5XG0X9QW7Zpo1KYR9HVwC26PIEFDlU5ioLEbe8qM0E6HsISFEKaaL568e2WTGzbfz3IN4cYIOCBQ8CnNhtKzylq3f8oqBBE22nfAMcAK2wlGFsUkNSVQHrv2whTtyrd/3aHLmsGbb3T4UpRtSwQ+L ZdrJj3vO DGDU7UH7jCj9fQ6Rf/xxWwGV2zbuCOcmqNl9ioTiaK1FPk0HAmc9ynqc1QOcWQZ5psjK2TDCEjFkpr3Ukj0dw45jOLHk3OMi16m8u+Fg5WoymwnobndDJtrXIBZvj6yJdDalCW1kgOxGls4Srk26Z1NCTLs/Ak3oPaXDJgqoruYQE3Wb1LhWoFtzfC17SygL20wL8SWcJIn11O4VNpIRF90EQAOFcPW7r0QTTAD39xvl6K2YS6eUN676rHJucRDzSF3snwUw1Ke72Q3a3+OUWBEklIziOPl2RMtwucQS1qU9KASY0yboPFHi81lLa1r6zx9h55nBMf7QMVxRkC71nx+2xp1NEvHltQOnLTlCFNRUHXek3+YtWS9zo1Ja85hVWKj7E5NgS82GggmW3NehJvbYI596TrAJL0JU/x0UxCa6DKc7rFBZOiGiuEz9f1EDTprizGNuKbIM82FdeWLAOP6/glqPqrvYXXg0PcLhZug0To8YzCfDUjTYkUbZMiQtnM1a4ggqKNuU7UlpRrehwt487BJGKqtEZCaBABEMniQGsGIMcaG3wtIEh8EDIi5x/FixI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/29/25 10:31 PM, kernel test robot wrote: > Hi Donet, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on akpm-mm/mm-everything] > [also build test ERROR on linus/master v6.15-rc4 next-20250429] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Donet-Tom/driver-base-Remove-unused-functions/20250429-010442 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/fbe1e0c7d91bf3fa9a64ff5d84b53ded1d0d5ac7.1745852397.git.donettom%40linux.ibm.com > patch subject: [PATCH v2 1/2] driver/base: Optimize memory block registration to reduce boot time > config: x86_64-buildonly-randconfig-004-20250429 (https://download.01.org/0day-ci/archive/20250430/202504300024.YxAyenLy-lkp@intel.com/config) > compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250430/202504300024.YxAyenLy-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202504300024.YxAyenLy-lkp@intel.com/ > > All error/warnings (new ones prefixed by >>): > > In file included from include/linux/swap.h:11, > from include/linux/suspend.h:5, > from arch/x86/kernel/asm-offsets.c:14: >>> include/linux/node.h:124:6: warning: no previous prototype for 'register_memory_blocks_under_node_early' [-Wmissing-prototypes] > 124 | void register_memory_blocks_under_node_early(int nid) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > -- > ld: security/keys/encrypted-keys/masterkey_trusted.o: in function `register_memory_blocks_under_node_early': >>> security/keys/encrypted-keys/masterkey_trusted.c:125: multiple definition of `register_memory_blocks_under_node_early'; security/keys/encrypted-keys/encrypted.o:include/linux/node.h:125: first defined here > -- > In file included from include/linux/cpu.h:17, > from include/linux/static_call.h:135, > from include/linux/tracepoint.h:22, > from include/trace/events/tlb.h:9, > from arch/x86/include/asm/mmu_context.h:9, > from include/linux/mmu_context.h:5, > from include/linux/cpuset.h:18, > from include/linux/sched/isolation.h:5, > from kernel/sched/build_policy.c:19: >>> include/linux/node.h:124:6: warning: no previous prototype for 'register_memory_blocks_under_node_early' [-Wmissing-prototypes] Thanks for the report. I will fix this and send a revised version. > 124 | void register_memory_blocks_under_node_early(int nid) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from kernel/sched/build_policy.c:52: > kernel/sched/rt.c:9:18: warning: 'max_rt_runtime' defined but not used [-Wunused-const-variable=] > 9 | static const u64 max_rt_runtime = MAX_BW; > | ^~~~~~~~~~~~~~ > -- > ld: drivers/usb/host/xhci-mem.o: in function `register_memory_blocks_under_node_early': >>> include/linux/node.h:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/usb/host/xhci.o:include/linux/node.h:125: first defined here > ld: drivers/usb/host/xhci-ring.o: in function `register_memory_blocks_under_node_early': >>> include/linux/node.h:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/usb/host/xhci.o:include/linux/node.h:125: first defined here > ld: drivers/usb/host/xhci-hub.o: in function `register_memory_blocks_under_node_early': >>> include/linux/node.h:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/usb/host/xhci.o:include/linux/node.h:125: first defined here > ld: drivers/usb/host/xhci-trace.o: in function `register_memory_blocks_under_node_early': >>> include/linux/node.h:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/usb/host/xhci.o:include/linux/node.h:125: first defined here > ld: drivers/usb/host/xhci-dbgcap.o: in function `register_memory_blocks_under_node_early': >>> include/linux/node.h:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/usb/host/xhci.o:include/linux/node.h:125: first defined here > -- > In file included from include/linux/acpi.h:18, > from include/linux/i2c.h:13, > from drivers/power/supply/sbs-battery.c:13: >>> include/linux/node.h:124:6: warning: no previous prototype for 'register_memory_blocks_under_node_early' [-Wmissing-prototypes] > 124 | void register_memory_blocks_under_node_early(int nid) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/power/supply/sbs-battery.c: In function 'sbs_get_property': > drivers/power/supply/sbs-battery.c:834:30: warning: '%04x' directive writing between 4 and 8 bytes into a region of size 5 [-Wformat-overflow=] > 834 | sprintf(sbs_serial, "%04x", ret); > | ^~~~ > In function 'sbs_get_battery_serial_number', > inlined from 'sbs_get_property' at drivers/power/supply/sbs-battery.c:965:9: > drivers/power/supply/sbs-battery.c:834:29: note: directive argument in the range [0, 2147483647] > 834 | sprintf(sbs_serial, "%04x", ret); > | ^~~~~~ > drivers/power/supply/sbs-battery.c:834:9: note: 'sprintf' output between 5 and 9 bytes into a destination of size 5 > 834 | sprintf(sbs_serial, "%04x", ret); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > -- > In file included from include/linux/swap.h:11, > from include/linux/suspend.h:5, > from include/linux/regulator/consumer.h:35, > from include/linux/phy/phy.h:17, > from include/linux/usb/otg.h:13, > from include/linux/usb/of.h:11, > from drivers/usb/core/usb.c:41: >>> include/linux/node.h:124:6: warning: no previous prototype for 'register_memory_blocks_under_node_early' [-Wmissing-prototypes] > 124 | void register_memory_blocks_under_node_early(int nid) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/usb/core/usb.c: In function 'usb_alloc_dev': > drivers/usb/core/usb.c:706:37: warning: '%d' directive output may be truncated writing between 1 and 11 bytes into a region of size between 0 and 15 [-Wformat-truncation=] > 706 | "%s.%d", parent->devpath, port1); > | ^~ > drivers/usb/core/usb.c:706:33: note: using the range [-2147483648, 2147483647] for directive argument > 706 | "%s.%d", parent->devpath, port1); > | ^~~~~~~ > drivers/usb/core/usb.c:705:25: note: 'snprintf' output between 3 and 28 bytes into a destination of size 16 > 705 | snprintf(dev->devpath, sizeof dev->devpath, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 706 | "%s.%d", parent->devpath, port1); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > -- > ld: drivers/i3c/master.o: in function `register_memory_blocks_under_node_early': >>> include/linux/node.h:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/i3c/device.o:include/linux/node.h:125: first defined here > -- > ld: drivers/i3c/master/mipi-i3c-hci/ext_caps.o: in function `register_memory_blocks_under_node_early': >>> include/linux/node.h:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/i3c/master/mipi-i3c-hci/core.o:include/linux/node.h:125: first defined here > ld: drivers/i3c/master/mipi-i3c-hci/pio.o: in function `register_memory_blocks_under_node_early': >>> include/linux/node.h:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/i3c/master/mipi-i3c-hci/core.o:include/linux/node.h:125: first defined here > ld: drivers/i3c/master/mipi-i3c-hci/dma.o: in function `register_memory_blocks_under_node_early': >>> include/linux/node.h:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/i3c/master/mipi-i3c-hci/core.o:include/linux/node.h:125: first defined here > ld: drivers/i3c/master/mipi-i3c-hci/cmd_v1.o: in function `register_memory_blocks_under_node_early': >>> include/linux/node.h:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/i3c/master/mipi-i3c-hci/core.o:include/linux/node.h:125: first defined here > ld: drivers/i3c/master/mipi-i3c-hci/cmd_v2.o: in function `register_memory_blocks_under_node_early': >>> include/linux/node.h:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/i3c/master/mipi-i3c-hci/core.o:include/linux/node.h:125: first defined here > ld: drivers/i3c/master/mipi-i3c-hci/dat_v1.o: in function `register_memory_blocks_under_node_early': >>> include/linux/node.h:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/i3c/master/mipi-i3c-hci/core.o:include/linux/node.h:125: first defined here > ld: drivers/i3c/master/mipi-i3c-hci/dct_v1.o: in function `register_memory_blocks_under_node_early': > drivers/i3c/master/mipi-i3c-hci/dct_v1.c:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/i3c/master/mipi-i3c-hci/core.o:include/linux/node.h:125: first defined here > ld: drivers/i3c/master/mipi-i3c-hci/hci_quirks.o: in function `register_memory_blocks_under_node_early': > drivers/i3c/master/mipi-i3c-hci/hci_quirks.c:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/i3c/master/mipi-i3c-hci/core.o:include/linux/node.h:125: first defined here > -- > In file included from include/linux/acpi.h:18, > from include/linux/i2c.h:13, > from drivers/hwmon/pmbus/ibm-cffps.c:11: >>> include/linux/node.h:124:6: warning: no previous prototype for 'register_memory_blocks_under_node_early' [-Wmissing-prototypes] > 124 | void register_memory_blocks_under_node_early(int nid) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/hwmon/pmbus/ibm-cffps.c: In function 'ibm_cffps_debugfs_read': > drivers/hwmon/pmbus/ibm-cffps.c:169:60: warning: '%02X' directive output may be truncated writing between 2 and 8 bytes into a region of size 3 [-Wformat-truncation=] > 169 | snprintf(&data[i * 2], 3, "%02X", rc); > | ^~~~ > drivers/hwmon/pmbus/ibm-cffps.c:169:59: note: directive argument in the range [0, 2147483647] > 169 | snprintf(&data[i * 2], 3, "%02X", rc); > | ^~~~~~ > drivers/hwmon/pmbus/ibm-cffps.c:169:33: note: 'snprintf' output between 3 and 9 bytes into a destination of size 3 > 169 | snprintf(&data[i * 2], 3, "%02X", rc); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/hwmon/pmbus/ibm-cffps.c:180:60: warning: '%04X' directive output may be truncated writing between 4 and 8 bytes into a region of size 5 [-Wformat-truncation=] > 180 | snprintf(&data[i * 4], 5, "%04X", rc); > | ^~~~ > drivers/hwmon/pmbus/ibm-cffps.c:180:59: note: directive argument in the range [0, 2147483647] > 180 | snprintf(&data[i * 4], 5, "%04X", rc); > | ^~~~~~ > drivers/hwmon/pmbus/ibm-cffps.c:180:33: note: 'snprintf' output between 5 and 9 bytes into a destination of size 5 > 180 | snprintf(&data[i * 4], 5, "%04X", rc); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > -- > ld: drivers/usb/typec/tipd/trace.o: in function `register_memory_blocks_under_node_early': >>> include/linux/node.h:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/usb/typec/tipd/core.o:include/linux/node.h:125: first defined here > -- > ld: drivers/usb/cdns3/drd.o: in function `register_memory_blocks_under_node_early': >>> include/linux/node.h:125: multiple definition of `register_memory_blocks_under_node_early'; drivers/usb/cdns3/core.o:include/linux/node.h:125: first defined here > .. > > > vim +125 security/keys/encrypted-keys/masterkey_trusted.c > > b886d83c5b621a Thomas Gleixner 2019-06-01 1 // SPDX-License-Identifier: GPL-2.0-only > 982e617a313b57 Mimi Zohar 2011-08-27 2 /* > 982e617a313b57 Mimi Zohar 2011-08-27 3 * Copyright (C) 2010 IBM Corporation > 982e617a313b57 Mimi Zohar 2011-08-27 4 * Copyright (C) 2010 Politecnico di Torino, Italy > c9fecf505a3421 Alexander A. Klimov 2020-07-05 5 * TORSEC group -- https://security.polito.it > 982e617a313b57 Mimi Zohar 2011-08-27 6 * > 982e617a313b57 Mimi Zohar 2011-08-27 7 * Authors: > 982e617a313b57 Mimi Zohar 2011-08-27 8 * Mimi Zohar > 982e617a313b57 Mimi Zohar 2011-08-27 9 * Roberto Sassu > 982e617a313b57 Mimi Zohar 2011-08-27 10 * > 5395d312dff00d Kees Cook 2017-05-13 11 * See Documentation/security/keys/trusted-encrypted.rst > 982e617a313b57 Mimi Zohar 2011-08-27 12 */ > 982e617a313b57 Mimi Zohar 2011-08-27 13 > 982e617a313b57 Mimi Zohar 2011-08-27 14 #include > cc100551b4d92f Stephen Rothwell 2011-09-15 15 #include > 982e617a313b57 Mimi Zohar 2011-08-27 16 #include > ee0b31a25a0101 Mimi Zohar 2012-01-17 17 #include > ee0b31a25a0101 Mimi Zohar 2012-01-17 18 #include "encrypted.h" > 982e617a313b57 Mimi Zohar 2011-08-27 19 > 982e617a313b57 Mimi Zohar 2011-08-27 20 /* > 982e617a313b57 Mimi Zohar 2011-08-27 21 * request_trusted_key - request the trusted key > 982e617a313b57 Mimi Zohar 2011-08-27 22 * > 982e617a313b57 Mimi Zohar 2011-08-27 23 * Trusted keys are sealed to PCRs and other metadata. Although userspace > 982e617a313b57 Mimi Zohar 2011-08-27 24 * manages both trusted/encrypted key-types, like the encrypted key type > 982e617a313b57 Mimi Zohar 2011-08-27 25 * data, trusted key type data is not visible decrypted from userspace. > 982e617a313b57 Mimi Zohar 2011-08-27 26 */ > 982e617a313b57 Mimi Zohar 2011-08-27 27 struct key *request_trusted_key(const char *trusted_desc, > 146aa8b1453bd8 David Howells 2015-10-21 28 const u8 **master_key, size_t *master_keylen) > 982e617a313b57 Mimi Zohar 2011-08-27 29 { > 982e617a313b57 Mimi Zohar 2011-08-27 30 struct trusted_key_payload *tpayload; > 982e617a313b57 Mimi Zohar 2011-08-27 31 struct key *tkey; > 982e617a313b57 Mimi Zohar 2011-08-27 32 > 028db3e290f15a Linus Torvalds 2019-07-10 33 tkey = request_key(&key_type_trusted, trusted_desc, NULL); > 982e617a313b57 Mimi Zohar 2011-08-27 34 if (IS_ERR(tkey)) > 982e617a313b57 Mimi Zohar 2011-08-27 35 goto error; > 982e617a313b57 Mimi Zohar 2011-08-27 36 > 982e617a313b57 Mimi Zohar 2011-08-27 37 down_read(&tkey->sem); > 146aa8b1453bd8 David Howells 2015-10-21 38 tpayload = tkey->payload.data[0]; > 982e617a313b57 Mimi Zohar 2011-08-27 39 *master_key = tpayload->key; > 982e617a313b57 Mimi Zohar 2011-08-27 40 *master_keylen = tpayload->key_len; > 982e617a313b57 Mimi Zohar 2011-08-27 41 error: > 982e617a313b57 Mimi Zohar 2011-08-27 42 return tkey; > 982e617a313b57 Mimi Zohar 2011-08-27 43 } >