linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Bert Karwatzki <spasswolf@web.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jiri Olsa <olsajiri@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linux-next@vger.kernel.org
Subject: Re: commit 1c29a32ce65f4cd0f1c causes Bad rss-counter state and firefox-esr crash in linux-next-20240613
Date: Fri, 12 Jul 2024 11:38:04 -0400	[thread overview]
Message-ID: <eee7hvd6vh4v65ta5fl7iacth7yesvryktxouu34uy4cxpxalm@ngeeuayw2lxp> (raw)
In-Reply-To: <20240712121800.3049-2-spasswolf@web.de>

* Bert Karwatzki <spasswolf@web.de> [240712 08:18]:
> I did some experiments on the rss counter bug. The next patch is made for linux-next-20240613
> with commit 1c29a32ce65f4cd0f1c0f9 reverted. Then I simply inlined the code of do_vmi_unmap()
> and do_vmi_align_munmap() into mmap_region(). This version of the code works fine and does not
> show the rss counter bug.

Are you still working with v1 of this patch set?

I root-caused the rss counter issue and seg fault to the fact that next
or prev may be expanded and I was using the new start/end on munmap() in
the completion.  This was fixed in subsequent patches.

I've sent v4 recently, but will have to a v5 to back off the removal of
arch_unmap() for PPC.

...

Thanks,
Liam


  reply	other threads:[~2024-07-12 15:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12 12:17 [PATCH] mm: Fix mmap_assert_locked() in follow_pte() Bert Karwatzki
2024-07-12 12:17 ` commit 1c29a32ce65f4cd0f1c causes Bad rss-counter state and firefox-esr crash in linux-next-20240613 Bert Karwatzki
2024-07-12 15:38   ` Liam R. Howlett [this message]
2024-07-12 16:26     ` Bert Karwatzki
  -- strict thread matches above, loose matches on Subject: below --
2024-06-21 19:32 Bert Karwatzki
2024-06-13 23:40 Bert Karwatzki
2024-06-14  0:03 ` Andrew Morton
2024-06-14  8:26   ` Bert Karwatzki
2024-06-14  8:37   ` Bert Karwatzki
2024-06-14 12:30   ` Liam R. Howlett
2024-06-14 17:21     ` Andrew Morton
2024-06-14  7:54 ` Jiri Olsa
2024-06-14 12:31   ` Liam R. Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eee7hvd6vh4v65ta5fl7iacth7yesvryktxouu34uy4cxpxalm@ngeeuayw2lxp \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-next@vger.kernel.org \
    --cc=olsajiri@gmail.com \
    --cc=spasswolf@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox