From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E0CFC54E94 for ; Thu, 26 Jan 2023 11:29:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B8C526B0075; Thu, 26 Jan 2023 06:29:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B15E16B0078; Thu, 26 Jan 2023 06:29:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B6D38E0001; Thu, 26 Jan 2023 06:29:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 87CE76B0075 for ; Thu, 26 Jan 2023 06:29:13 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 443C41C4AAC for ; Thu, 26 Jan 2023 11:29:13 +0000 (UTC) X-FDA: 80396728986.18.4516F1E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 988A31C0015 for ; Thu, 26 Jan 2023 11:29:10 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Sw9Eyzn8; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674732551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=auJUTiA5gppUN88yh5GL328mtp2gCdG5Khsqvq1NfCo=; b=Dgp+spLBkeqQxslMiHtimOQZp/z45FAJQ/HNbdwaforLG++eb26XmUJMZULulLyGa9V0lh SkTMpU+ZAg9Xf6nRgZwlHDDGKWaxOSPTcKcu3pVALhK3av6qzwA14VF0izunlZ9nEIkYmP 2fpF4VmQWgqZU5YjFpaD07n+qWAvtV4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Sw9Eyzn8; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674732551; a=rsa-sha256; cv=none; b=V1mppB4pOrMhKcOF+Yefnzsd0Wv3HVxp6hXlZFaKbgprioeEHc5+q1xd0f/3Q2AkSNFkjK l6poyHTg44fTxItY+pUrhdW6Ckh12Ij0/uWkfNapgSfJYqgoUcTJkZSsJwxsNXL2OnDK1g 4uh+DLsG0YcwdJtn6ryY0+2Ql2kVEaY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674732550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=auJUTiA5gppUN88yh5GL328mtp2gCdG5Khsqvq1NfCo=; b=Sw9Eyzn86AUMM6CgqKijOJ10dD2EpJwlQMn78KFnzmadK3d7PXxnyBgukxNqHN7TlNowBE gqL6EEb3/Nuc5bJHr+SKdwtri5e1x0IVcXjFMc0AarYUxPcFPbahfjSpTGw6xeKbeOeERk dP6iQwHUu81j1H1SG3C2qrvWgudqLO8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-635-fqEPhajhPZuke3O9cXZ8Gw-1; Thu, 26 Jan 2023 06:29:08 -0500 X-MC-Unique: fqEPhajhPZuke3O9cXZ8Gw-1 Received: by mail-wm1-f72.google.com with SMTP id bi18-20020a05600c3d9200b003d991844dbcso2679394wmb.4 for ; Thu, 26 Jan 2023 03:29:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=auJUTiA5gppUN88yh5GL328mtp2gCdG5Khsqvq1NfCo=; b=wldrkWldhwHsqkQuyKhxvx1nDdNOgaFKfDeu544miy/fxEsWnNRXZqk1eSkQLTmFgG IhOnMKXR09/NJ2pSv7KPpSR1Aq1IAHNTZDlVqD+TtlXbVog0jxTTtnju0mtGyT6BHlAz cXhXC2Kjjmotgt+1XUhFlFrKPVcSL4TlGRb/0M93SjD1G/mRytclb/Mo3DcVGyVvRCdD OUFMSubY+gJ8/PTV7f8Y+OAlhrWAuQWqd03NctPjVu9MmaU8qcWqiE2IiQx7nnGSykyS ARA7M9iBOZ4GQwemMaMvuB/GFsQlavGnMacfey+tX/YxzXcKQTLwsJcrPQ5l34w4Abve m+RA== X-Gm-Message-State: AFqh2kqumug3+puuvx9BYfyoEVRrOktuxN9dgfV/XdOekChAFifFOwvQ VxIQ8OknMFP/irczv0KX6dXMsvwZlIm9TGl6DVt4GvLsg4Xnd+1Xf/FnwbPBdzfyahPietKUR0V 3bJjKPrdFL1E= X-Received: by 2002:a5d:6b0e:0:b0:2be:d03:287 with SMTP id v14-20020a5d6b0e000000b002be0d030287mr31125921wrw.44.1674732547540; Thu, 26 Jan 2023 03:29:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXvSjU3va2cCxqDvMlFbGM+bpzK1YBTp5fh6M5TiPc8Nn+D54qwZ7uZD7LtA55nNkVDIk+uzmA== X-Received: by 2002:a5d:6b0e:0:b0:2be:d03:287 with SMTP id v14-20020a5d6b0e000000b002be0d030287mr31125900wrw.44.1674732547215; Thu, 26 Jan 2023 03:29:07 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id t16-20020adfe450000000b002bbdcd15e44sm1040429wrm.37.2023.01.26.03.29.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 03:29:06 -0800 (PST) Message-ID: Date: Thu, 26 Jan 2023 12:29:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 12/13] mm/gup: move gup_must_unshare() to mm/internal.h To: Jason Gunthorpe Cc: Alistair Popple , David Howells , Christoph Hellwig , John Hubbard , linux-mm@kvack.org, "Mike Rapoport (IBM)" References: <12-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <12-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 988A31C0015 X-Stat-Signature: qjojriqdnq99f8eo1znopej5rsrho74w X-HE-Tag: 1674732550-525857 X-HE-Meta: U2FsdGVkX1+M3uD+mU2Lg8QWT4Wp2goXKTvAKn8e44hNSFgBoW7UYiaDA31EDXJZnxDDnvbHKgBydYjsD7g0Ki+aDlJaW1xb8fakkU96PoaQzDjeXBqVau42mAdl+z9Ruh36g5qX6SeI3yKfQOPmTD/oZ/WOrSi5MF1lhuQjPOpDka4A2wkfBwM9QE3UbO45Ykn7Lj1qibEPUI4ToltNpJnUwnAblFBTN25bKiah7Q8JFYcWOgqRI1cP9vyTcUG+DFsudaTb7aqbeKVTw3yyNrSVT3UlujK6PueD/+Zl0m7wfLCd85OtRtoKc/ZfY/8vTjkgw89pvgxmgUO7Kq+fbznvAhcV8p2tnr8sjRxLSBXJqW26pl8fHj+KXTndjW99Wf5OYhiVz5thd2ZY0WqGOYsLT+8YyplC2zvO/7BdJ0GTgmRqmc095Ls1dBRCHeojW3v6eQmc9Z5dH7E1E8fmjYqnX1dBpfGLe4S/7XivgXWBcFOEphndCBDrTQUhhnLTozXcta7MVWte48ICeJqdUGkE/s3UVwupmPdKydSUWdy0kKfTmZYsWTF1K5oyVa42+F+3F7vTjd01hqE6JY0rpbkNsOQYgHJbaXpNfQ/1ODycqU571ZUSqE7H3YmpI8Vz1PIWqBgMrN9B7UzDRsUB7yukUhwcML3ICPbWNN9trs0Te9Vd+UA3C+d7YINpUl+yvitNmzutYFKwlIsNp9cMtFMSKOMUFU57m4f1iAFhiya5gu34Z9DNajtcAolHGCyy0TaUSxMdKFOYmvOwr3hOVMtNOhPZEQZqeLLepswhBVe+8vgownOTZxiDpYy+MpcowzUAlebmaeXzW4sYl3lRpZizl3pgAZXyvE3jNXrlCrjiHFIcRCLfk1Q8FsVcro+W7ZpHbudfOzv9W0mqtPSGbXBypl+5Xvlli3z1S/ZWe1kOsjFwyUAJi343gnypXtjXq/+P8Js59WsHP1meeWF 49eZIo4d 6ECTKo1qXtydxrSEVfH6eDiC0AWsW+PZ8T1WzqlRJi7g5axIdUqqBWnanhDw458qdehPxF7OZqFzEq0bhbvPF+h8/tKYPEK+Gp6DnQWuI73pQcWanvkhl+8eINGti5TSNHCt5rRVOVeHBcz1o22bo9KR91eo9agSbgE2XJMaVltSp8V0kbeTDd7o/j370Yev7G2VbujCdej5L0iE8H8lJrmP00rsqS0Y1ZVMVXlnGOgxHWqhCf9rbiHPmeGOYxqYiS8IPZ5qBFhh7vu8TsEa385Me1GZOMttJ3MnSJnWMo/bbJ0cfCZZfXFxD1sLxEPmmQRPNlPliKBoU78yIad9rjrYNHzeHiW39InnTNZoQUBaUaaV/XgoBBhG5RYt99H3i+3j1cYItag/0i6WmnGpTrQr0CsD4aP/WtCwacpV2SmLXGF+4AmqPm58Q2GM67C7+TaEjal6YpOcXgzyKf/uu/gJ+p8tegGMOjL31Lr8A0gEAkcNlVj2mofeXbw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.01.23 21:34, Jason Gunthorpe wrote: > This function is only used in gup.c and closely related. It touches > FOLL_PIN so it must be moved before the next patch. > > Signed-off-by: Jason Gunthorpe > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb