From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68B15C433F5 for ; Fri, 29 Apr 2022 09:54:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA2EE6B0071; Fri, 29 Apr 2022 05:54:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D53476B0073; Fri, 29 Apr 2022 05:54:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF3A86B0074; Fri, 29 Apr 2022 05:54:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id AC1E76B0071 for ; Fri, 29 Apr 2022 05:54:41 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 75415619B0 for ; Fri, 29 Apr 2022 09:54:41 +0000 (UTC) X-FDA: 79409457162.08.7613332 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 533DDC005C for ; Fri, 29 Apr 2022 09:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651226080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=taFIyfF8aQ8L/XDSdTbfsKUW0s/xVxGlxL7GYD+pc+4=; b=hchFIvGbBSbiIGtFOkYRtZoo4yhegZvKRWUbUInHQmyH+qHyp5la8XCQ9HdIK/SX5bfH9e IUg2VHAFGaanCZB95be4Pla2vg7FHD6QYBCLO6XeQNvJc3Rj3XrXH45QSGhOvEeZUGBvvo re7N/tYeApclYBZiLjG/3NOJlJDW1wo= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-VV1kXAFANZOYLdl8yAqj7g-1; Fri, 29 Apr 2022 05:54:39 -0400 X-MC-Unique: VV1kXAFANZOYLdl8yAqj7g-1 Received: by mail-wr1-f70.google.com with SMTP id e21-20020adfa455000000b0020ae075cf35so2893119wra.11 for ; Fri, 29 Apr 2022 02:54:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=taFIyfF8aQ8L/XDSdTbfsKUW0s/xVxGlxL7GYD+pc+4=; b=OuQh5x80yQSnUuKHxyxfJrV1c8tUPKT9ackglwrgxmgBtu8du40LFaW5mguoRVV9aJ NRStv1XKWL68B1ASEblXspKbm3PvLvOea0cg8o3euxzvGbyqSQpz92ogm7PoMAYMFtnA jT/g0cDhXI88/YW8HmAmhzunxaXYZRCklW/RWwA0Bv8S16jMQmf1VhpjZBjf8OhGHppW 7n/+DcXXwsHHUo0lTe0fdXxNA5kswCnOdwUGNiQ90MZ3VwVWBWScQmH7OBrJrP0/10gF Cq7mOXhZ+9NJT7UXbhPHo65J4EPqaAbv9TzsYapzKrYpYTWT9A2PSBR6JfPfscDgQ03m zyfg== X-Gm-Message-State: AOAM530qPkgjM3aeU68DhvumzGuVwGGfv9lWco/s9aEPHaRR7vXSej+g xqVBscK9h6oTxkC3EJPCXvjLjJtsjUDnOFCnC9h6U8SWIMg11FXooO/JsvMQ8tZ/NFWamrf9PA+ Ca/GYpJn6VYs= X-Received: by 2002:a05:600c:1e85:b0:391:ca59:76be with SMTP id be5-20020a05600c1e8500b00391ca5976bemr2386601wmb.184.1651226078097; Fri, 29 Apr 2022 02:54:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyuz74y5fMW0AcrjTHiajh/StenTy5kkz2aFzsCAM/mvBiSzOFfrIe3mpO9zSvUfJEwurviA== X-Received: by 2002:a05:600c:1e85:b0:391:ca59:76be with SMTP id be5-20020a05600c1e8500b00391ca5976bemr2386577wmb.184.1651226077822; Fri, 29 Apr 2022 02:54:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:fe00:bbeb:98e6:617a:dea1? (p200300cbc707fe00bbeb98e6617adea1.dip0.t-ipconnect.de. [2003:cb:c707:fe00:bbeb:98e6:617a:dea1]) by smtp.gmail.com with ESMTPSA id bi7-20020a05600c3d8700b0038eb78569aasm5961159wmb.20.2022.04.29.02.54.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 02:54:37 -0700 (PDT) Message-ID: Date: Fri, 29 Apr 2022 11:54:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH v2 1/4] mm/migration: reduce the rcu lock duration To: Miaohe Lin , akpm@linux-foundation.org, mike.kravetz@oracle.com, naoya.horiguchi@nec.com Cc: ying.huang@intel.com, hch@lst.de, dhowells@redhat.com, cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220425132723.34824-1-linmiaohe@huawei.com> <20220425132723.34824-2-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220425132723.34824-2-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 533DDC005C Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hchFIvGb; spf=none (imf10.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Stat-Signature: 8bh6ocsiryre9oz8p1pg7hfr5p493b3r X-HE-Tag: 1651226070-755021 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.04.22 15:27, Miaohe Lin wrote: > rcu_read_lock is required by grabbing the task refcount but it's not > needed for ptrace_may_access. So we could release the rcu lock after > task refcount is successfully grabbed to reduce the rcu holding time. > > Reviewed-by: Muchun Song > Reviewed-by: Christoph Hellwig > Signed-off-by: Miaohe Lin > Cc: Huang Ying > Cc: David Howells > Cc: Christoph Lameter > --- > mm/migrate.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index b2678279eb43..b779646665fe 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1902,17 +1902,16 @@ static struct mm_struct *find_mm_struct(pid_t pid, nodemask_t *mem_nodes) > return ERR_PTR(-ESRCH); > } > get_task_struct(task); > + rcu_read_unlock(); > > /* > * Check if this process has the right to modify the specified > * process. Use the regular "ptrace_may_access()" checks. > */ > if (!ptrace_may_access(task, PTRACE_MODE_READ_REALCREDS)) { > - rcu_read_unlock(); > mm = ERR_PTR(-EPERM); > goto out; > } > - rcu_read_unlock(); > > mm = ERR_PTR(security_task_movememory(task)); > if (IS_ERR(mm)) Similar pattern in: mm/mempolicy.c:kernel_migrate_pages() kernel/futex/syscalls.c:get_robust_list() kernel/nsproxy.c:validate_nsset() Exception: sched/core_sched.c:sched_core_share_pid() Should we unify -- i.e., adjust the remaining 3 as well? -- Thanks, David / dhildenb