From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7BF8D3B995 for ; Tue, 26 Nov 2024 14:26:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C5746B0082; Tue, 26 Nov 2024 09:26:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2764D6B0083; Tue, 26 Nov 2024 09:26:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13CD66B0085; Tue, 26 Nov 2024 09:26:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E40B16B0082 for ; Tue, 26 Nov 2024 09:26:36 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 915971A0F85 for ; Tue, 26 Nov 2024 14:26:36 +0000 (UTC) X-FDA: 82828471866.15.272E6E2 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf22.hostedemail.com (Postfix) with ESMTP id CE245C0002 for ; Tue, 26 Nov 2024 14:26:28 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732631191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M+h5DxED7xTpGVtMCw7uarfhqfox7mW4cS7od/IH8dA=; b=TUMgHyAcrgaf67UScgRFPD1AOKJ95Krt/ELe2fJiwWx9uMwCOY1XMZ1etP5t7wN04ttv2J bvio4Vf08xEwvZ0Uk+eXNu93YLqYWcqfHlT/Oof5KOPEXWcZSeX8+2fJRSJsVQCJzCkxG7 oz5zKXTKUSwG131vw/apWJ1iS5rVFXY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732631191; a=rsa-sha256; cv=none; b=6ArkhPo7orREHxrXTsHVhd/62XdXVChC2vgVz6z3eQfClTQhzwhc1nzGq/s4JKbX1FSGms UYetgb3iU70B0QmJvAyCcxTfRcSvNTwDl9KkVP8o5rPE/stt0agsehiIij3Lklb8fZt+E1 lA8X6wcrd4kV6KTKFIoET/tMDTWqhTo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf22.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9A8891A00; Tue, 26 Nov 2024 06:27:03 -0800 (PST) Received: from [10.1.29.199] (XHFQ2J9959.cambridge.arm.com [10.1.29.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A8A543F5A1; Tue, 26 Nov 2024 06:26:32 -0800 (PST) Message-ID: Date: Tue, 26 Nov 2024 14:26:31 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm/slab: Avoid build bug for calls to kmalloc with a large constant Content-Language: en-GB To: Vlastimil Babka , Dave Kleikamp , Andrew Morton Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20241014105514.3206191-1-ryan.roberts@arm.com> <20241014105912.3207374-1-ryan.roberts@arm.com> <20241014105912.3207374-6-ryan.roberts@arm.com> <44312f4a-8b9c-49ce-9277-5873a94ca1bb@oracle.com> <7fb6c5a2-b9ae-4a29-a871-2f0bdc636e41@arm.com> <9675f4f0-6290-43aa-bf17-6b9c2b461485@suse.cz> From: Ryan Roberts In-Reply-To: <9675f4f0-6290-43aa-bf17-6b9c2b461485@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CE245C0002 X-Stat-Signature: 4jb3466hxmn6pyux6pqka9nf1gf4mc7u X-HE-Tag: 1732631188-488710 X-HE-Meta: U2FsdGVkX1/zIepxN0YfB6LVNRDFc5+M+AI9ibaV7vM3G5qNN1wUumm69x2FlAhylnEWzM3GWa47NADLTOaWbAYknAk4tShLi+R6MIlggrHtwFrkh6FJfNoxjeBwS/3xjkbM+gqezWrqRNDU1LDAx0w3xCwpHk0EoNooALrEWulEHfuOYkp0n/2YZZofqfipTvd+uIdXpEkx/nlsjSePDg5qIIrGhDPMfEmVtoewEm4V79fZIvT9jDyzwXx+oVHu9Uv6KKYbs2p+2WFBX4imHGwknefcq9d2YL4xsTGPBZtrmIhGdEnkn87QwZwnXen5RZp8xzFwLI4uGn9uqUDvlU/UaU70z1IpEzj7A9Cliix1uFJNycOR5o7669c7vYwnGuKE65gTMqIDK2FJjLEHOyaRD8xlbLqvmR2pigtQO37IVHYBpklr20+zXlzhKu9z/nhjDbOD67KnHNxXu/KDJg2IjkARlkY/Jf47Kl9gmKlNiRqm6YxA5MBcfhGwC8ToQA0Z3AUAm580EOYmcXzF2ueG00dsaSG15GmuBOT3hry1hZMZQUMbw16e12ULVDfF9+AKdJ6lz+zMVFyAWHi957kd5kagWZbDQvX2RFNIm+1zhfmqJ4a2rkPNurvOzW8nmMLTDXt7Wd3v+UWwGA9nakc4JB/U1u/th1ujnijnqWWvuEYayV/RPGwizrnHQuWFKM82s5IyDlp+8LK+wU+LGSXgtMFGRXGZwsd2qSRHpmBpebS1xRGA47sj9+S9i/KRC3hRKiR27+AesABY28XHCciGMHf4GHG1ip4DF297cCQldcFn4RVz4A0M7jOPvK/V53qjQb6Lb8lvvnmYcYy/jZEgFxcNJDOg0KdnMH7v+/DCvqljZ8vbpe9spGxlp0bwb5g0ULat6CUo+/+uEWIs+38LzIAcmzaNV/v44Hdqzs0rY+xhvYPG0//Js5iFLrEwoGB0RTTnDXm7jYzicbJ BQURT8XB 4XCHg9Fkk3E9ssFB+io+wCDE6BDhpx8FJMQ+JhJzrVN+1Mvm+58nr7EjvFfJvgdaFfdZaeb97CTPUUQpK6GQw5bNckBXre3N+DHYqCtETf4gjnqv43k8GkhjB4lkI7QWpO/f44opN6ICD6rVjUjbBj29ZWUvA/vta40t7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26/11/2024 12:36, Vlastimil Babka wrote: > On 11/26/24 13:18, Ryan Roberts wrote: >> On 14/11/2024 10:09, Vlastimil Babka wrote: >>> On 11/1/24 21:16, Dave Kleikamp wrote: >>>> When boot-time page size is enabled, the test against KMALLOC_MAX_CACHE_SIZE >>>> is no longer optimized out with a constant size, so a build bug may >>>> occur on a path that won't be reached. >>> >>> That's rather unfortunate, the __builtin_constant_p(size) part of >>> kmalloc_noprof() really expects things to resolve at compile time and it >>> would be better to keep it that way. >>> >>> I think it would be better if we based KMALLOC_MAX_CACHE_SIZE itself on >>> PAGE_SHIFT_MAX and kept it constant, instead of introducing >>> KMALLOC_SHIFT_HIGH_MAX only for some sanity checks. >>> >>> So if the kernel was built to support 4k to 64k, but booted as 4k, it would >>> still create and use kmalloc caches up to 128k. SLUB should handle that fine >>> (if not, please report it :) >> >> So when PAGE_SIZE_MAX=64K and PAGE_SIZE=4K, kmalloc will support up to 128K >> whereas before it only supported up to 8K. I was trying to avoid that since I >> assumed that would be costly in terms of extra memory allocated for those higher >> order buckets that will never be used. But I have no idea how SLUB works in >> practice. Perhaps memory for the cache is only lazily allocated so we won't see >> an issue in practice? > > Yes the e.g. 128k slabs themselves will be lazily allocated. There will be > some overhead with the management structures (struct kmem_cache etc) but > much smaller. > To be completely honest, some extra overhead might come to be when the slabs > are allocated ans later the user frees those allocations. kmalloc_large() > wwould return them immediately, while a regular kmem_cache will keep one or > more per cpu for reuse. But if that becomes a visible problem we can tune > those caches to discard slabs more aggressively. > >> I'm happy to make this change if you're certain it's the right approach; please >> confirm. > > Yes it's much better option than breaking the build-time-constant part of > kmalloc_noprof(). OK, I'll take this approach as you suggest. Thanks, Ryan > >>> >>> Maybe we could also stop adding + 1 to PAGE_SHIFT_MAX if it's >=64k, so the >>> cache size is max 64k and not 128k but that should be probably evaluated >>> separately from this series. >> >> I'm inferring from this that perhaps there is a memory cost with having the >> higher orders defined but unused. > > Yeah as per above, should not be too large and we could tune it down if > necessary. > >> Thanks, >> Ryan >> >>> >>> Vlastimil >>> >>>> Found compiling drivers/net/ethernet/qlogic/qed/qed_sriov.c >>>> >>>> Signed-off-by: Dave Kleikamp >>>> --- >>>> >>>> Ryan, >>>> >>>> Please consider incorporating this fix or something similar into your >>>> mm patch in the boot-time pages size patches. >>>> >>>> include/linux/slab.h | 3 ++- >>>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/include/linux/slab.h b/include/linux/slab.h >>>> index 9848296ca6ba..a4c7507ab8ec 100644 >>>> --- a/include/linux/slab.h >>>> +++ b/include/linux/slab.h >>>> @@ -685,7 +685,8 @@ static __always_inline unsigned int __kmalloc_index(size_t size, >>>> if (size <= 1024 * 1024) return 20; >>>> if (size <= 2 * 1024 * 1024) return 21; >>>> >>>> - if (!IS_ENABLED(CONFIG_PROFILE_ALL_BRANCHES) && size_is_constant) >>>> + if (!IS_ENABLED(CONFIG_ARM64_BOOT_TIME_PAGE_SIZE) && >>>> + !IS_ENABLED(CONFIG_PROFILE_ALL_BRANCHES) && size_is_constant) >>>> BUILD_BUG_ON_MSG(1, "unexpected size in kmalloc_index()"); >>>> else >>>> BUG(); >>> >> >