From: Pekka Enberg <penberg@iki.fi>
To: Qian Cai <cai@lca.pw>,
akpm@linux-foundation.org, cl@linux.com, penberg@kernel.org,
rientjes@google.com, iamjoonsoo.kim@lge.com
Cc: andreyknvl@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slub: untag object before slab end
Date: Wed, 13 Feb 2019 09:32:32 +0200 [thread overview]
Message-ID: <eeac3e54-c31a-a583-b185-b2d36d7debed@iki.fi> (raw)
In-Reply-To: <20190213020550.82453-1-cai@lca.pw>
On 13/02/2019 4.05, Qian Cai wrote:
> get_freepointer() could return NULL if there is no more free objects in
> the slab. However, it could return a tagged pointer (like
> 0x2200000000000000) with KASAN_SW_TAGS which would escape the NULL
> object checking in check_valid_pointer() and trigger errors below, so
> untag the object before checking for a NULL object there.
Reviewed-by: Pekka Enberg <penberg@kernel.org>
next prev parent reply other threads:[~2019-02-13 7:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 2:05 Qian Cai
2019-02-13 7:32 ` Pekka Enberg [this message]
2019-02-13 10:31 ` Andrey Konovalov
2019-02-13 21:12 ` Qian Cai
2019-02-14 0:26 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeac3e54-c31a-a583-b185-b2d36d7debed@iki.fi \
--to=penberg@iki.fi \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=cai@lca.pw \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox