From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7101FC3DA61 for ; Sat, 27 Jul 2024 19:00:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A00426B007B; Sat, 27 Jul 2024 15:00:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B0A46B0082; Sat, 27 Jul 2024 15:00:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DB366B0085; Sat, 27 Jul 2024 15:00:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6170A6B007B for ; Sat, 27 Jul 2024 15:00:28 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8EC74401FC for ; Sat, 27 Jul 2024 19:00:27 +0000 (UTC) X-FDA: 82386448494.09.ED382EC Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf04.hostedemail.com (Postfix) with ESMTP id 2FA4F40006 for ; Sat, 27 Jul 2024 19:00:23 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=aJAkbTBj; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Hxfk3eX5; spf=pass (imf04.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722106784; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XsDIpy8y5u3LfUNBJYyNyWHlMPQUJ6NALDcDoZScPEw=; b=Ac4PAWRpoqahE+X6pycgto1TZYv7zJ3gwEBqX/3VhayK5JwQpB5bzc137njJ3/xThd/YPc AWBije44wCmh5dP1OlMfZQ1k/BXXSxF31yfHIVQxi+kb38GpqUOj4GlTuhZNSdc6MRllEX rnfcO149CmB6c8skupLIGzVzOscysME= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=aJAkbTBj; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Hxfk3eX5; spf=pass (imf04.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1722106784; a=rsa-sha256; cv=pass; b=3R8pjfdbhb25jj2q9iLouIZrRLUQd4Avk8Z54t3G3n/ewYGWPCvrF+mD4zOGHyMyjyGzHI 5vUcbcC3z1z6YaE6q4CWSEY6o8QChuBq4pPj2zLAr62fir+xZSIK228O4C1rdoJQLQ0r6+ e/w5d2RuL+WTfMZdkl7xzhEU20FtuMM= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46RF3L7W019861; Sat, 27 Jul 2024 19:00:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=XsDIpy8y5u3LfUN BJYyNyWHlMPQUJ6NALDcDoZScPEw=; b=aJAkbTBjGJjwjaTSdDItY8OUck9szQZ vOeL5pQFkabumLOgs/iJZxMiZrkmECMThl9Pph/pjHQl3GSUqEC+uB7wg0OsJ/aa wq+JS4CRSjb9U2TNP0S58zSg1e18VP5XZ4cpVzr0TeT4JY7tVkGvSpppqb1XYBbA S3Kf+oCU+J43rZhT/3shgjiQDbZTzHCnN3bJ7gN4evYkBnDpRZN/QDOHyx6RCYL7 SKzAUb6D3+flKGpH6XjqoP9U/0DziUNynYhpQfihyV5JsqbIRDYoJ+qvxr+smWFc UNHOrDg5pG+3l41Cd377/rqsrxyTFEgJHlPVCGgRBgRtNMezatzSSpA== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 40msesgg0d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 27 Jul 2024 19:00:03 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 46RH2C0Y016009; Sat, 27 Jul 2024 19:00:01 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 40mqb5ebe5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 27 Jul 2024 19:00:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Lbsp6wp5HQPKX1YeyVccqlxSbT6SRLn+JIPwHk3ZBXeyUDhLYY9onZxhymAXF2MUeRYw9ejSZwsdw4T4bSW+lMSn7MZQcf9tZuMa0K2TbTQiDRjyEPrt33nrz+z+/E6xm1Ez7w2hdgEBDmuA8tfcmKIPgcKIW4qK3nHnX46CT9ShQJ37YZ3g8VEH12g8lMV5k4oW2zn1AIDX7frqivFEPqKuKbeXtyjELAbAREGOmegxJsYnVJyIvYUdPlkW2TBY/+F/1vs76qxRvwXrpr64N8ym8NLhxO1cVft7l5fSI3vaFSnAxhvdL/j6EOoWppViMtciC53qc1vU9nv1jXC6CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XsDIpy8y5u3LfUNBJYyNyWHlMPQUJ6NALDcDoZScPEw=; b=bTbs5iv2O9stVigY1bRONm2oaFPnwcnw0Itq4D3Z8ZznpwQMOYpE85vCmevdSididqePx6V3Smw/1++HIeNlkkXZ0kEMwuLnzg9puGAuDK2iCm7uHBIjUwaeFYBSWGq41ugJuOd0wgPxHJg31lbDYwD/h6pEtPR+m2ZshG7hvI1zWrPN/VJLNXAc8Y0UhbTIocfHpLuqECRdrhoEPXNOFdIzmkHkPEPJy/MTH7pzdPCL54FwxCqkSrG05LT5FUmEvPxBIakhHEy/2jhTeYcd15myMc8h3Jbwy8ancP+fqWQlafi41poydwlmwW6OANulSUJWXL5bQQnHigDma5Gjsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XsDIpy8y5u3LfUNBJYyNyWHlMPQUJ6NALDcDoZScPEw=; b=Hxfk3eX5MNOVzgOQOvfHxsftHRBSFmz0Tp5FE+LnzSsOb47CMStvr1gbVcKl8etxwdVaORG7ZtOScZBu8NxL+eOYZBow/orvbhzvsIgeXhKPwTdS/Xijfv3UvZDIg+wnuLWVodeDt1kjWCWrpqjcbx2OwuHQtfHtPQOY1cf7xEg= Received: from SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) by IA1PR10MB7239.namprd10.prod.outlook.com (2603:10b6:208:3f8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7807.26; Sat, 27 Jul 2024 18:58:58 +0000 Received: from SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e]) by SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e%6]) with mapi id 15.20.7807.026; Sat, 27 Jul 2024 18:58:57 +0000 Date: Sat, 27 Jul 2024 19:58:52 +0100 From: Lorenzo Stoakes To: David Laight Cc: 'Linus Torvalds' , Jens Axboe , "linux-kernel@vger.kernel.org" , "Matthew Wilcox (Oracle)" , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , Arnd Bergmann , "Jason@zx2c4.com" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" Subject: Re: [PATCH 0/7] minmax: reduce compilation time Message-ID: References: <23bdb6fc8d884ceebeb6e8b8653b8cfe@AcuMS.aculab.com> <902a9bf3-9404-44e8-9063-03da3168146a@lucifer.local> <137646a7-7017-490d-be78-5bd5627609c3@lucifer.local> <36aa2cad-1db1-4abf-8dd2-fb20484aabc3@lucifer.local> <40369e153bd447e5b597c31e7bc9a2b1@AcuMS.aculab.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40369e153bd447e5b597c31e7bc9a2b1@AcuMS.aculab.com> X-ClientProxiedBy: LO4P123CA0159.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::20) To SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB5613:EE_|IA1PR10MB7239:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ccf7dd3-b388-444d-e365-08dcae6e2b4f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6NkOiPbDQ6FJBFb0WXyzXmNF7DJPsj1CXKvCG8AJXAY34d4jsgrLv9EEKb1g?= =?us-ascii?Q?S2dZIDovxjf9mZg9J00krYLLVFmEiVf//oMx9ELqg0R+ISr5e7yJPGWX9uwW?= =?us-ascii?Q?TCbkMZRtasXmHY1lptij5Ui0HB5SHfkhm7jndakLyiHfwGcNg5wHnuVMXJWo?= =?us-ascii?Q?mqrmyoUv7nlcxInxorB9AKhvu7MswCqlDBHjd4ZebqPJB7DVhlcQxVtusj2q?= =?us-ascii?Q?sO6VPvS7fXV7gDtI4/0VrGa2MChj+xA3fLOOe4dfuTIIjJgZuGpo3hG3ozHK?= =?us-ascii?Q?jZqQjCu/T4tIh7CdqhCzWFl/asqkViPWhV+f8K9Y4vBnQzLkbp8fyJujunHY?= =?us-ascii?Q?FKlAMNbAPP40oTd5DN63jTNEDX/zsvHfVqcq7oJZBs1jtqSzUPUaMUCA12RS?= =?us-ascii?Q?+SxiVBEVLo6MJBBSw1zAww4dL8p8W9GFReKSnZgkeGwuI8e8MBWCR+O9xol3?= =?us-ascii?Q?6ZRCfvG9w1HmNk9JI0OGFZVEhlT9kvgOeuxAaR+Wo5M78pUes2at3VhI1tYF?= =?us-ascii?Q?jxS9i04cjkOJss0aECyVhXYLDoxWIbPOxuQJPRSLZnLXJuGx9UfvA7J76guP?= =?us-ascii?Q?yU48sJzPqjOJqYBwxt0tZvEbD1xTLp7WRvYoHppoauXze82YNjAH4v++bXJd?= =?us-ascii?Q?1n42BzhT5/r84qFn8gf+wOd4QlkKtrLbgc5fDyXrzwHTdNYt6lQ4j7dJDIrJ?= =?us-ascii?Q?37zR5uH28d5RaszfKJPBUwC7JJXgcyVsYOCd1NRUZEHtxYEchmrp2R1LSWe7?= =?us-ascii?Q?Qn0833lM+Tu2pW7hAAZgzQgVDdjDfYdp/huLtZo7UBY2qY8b4MWEeLE1ge0F?= =?us-ascii?Q?42cKDGH6G1VaEZT1qh5pxbzoQ5/xIydTMQnAXeV9pTFmUXn5n7h3wderfPKL?= =?us-ascii?Q?JXXL2jW8KTnf15eiCdQ8OM3Dq33T1lSKrWRx/Du5tPjBQ1omL1t10IVMFRfr?= =?us-ascii?Q?UBv4HbvZ580OAt/EvAId0xXoKYhabY9squx8AbSdQHXEa62PeET/1s63KdtS?= =?us-ascii?Q?ormDQ3V0Uq4dMRh+aXwyBuyu95XN3KApHHstWhhAIBkOm41WXlWjhoiRnPQM?= =?us-ascii?Q?sD5exvJE5WjCeR4VTi3xi9kSGYDezZfaI883+wi4NF2IXgzAgHwuM2ZhHnRw?= =?us-ascii?Q?xainBLPkt/ksk6tIPAWVGdaS+MjH35I9jS7aGPVBAMietPOOMrcxNFnWqbUo?= =?us-ascii?Q?/J/JujmPmDOyebUyxiFPTHsg0XeupBDNEYDkpPy+wnPUx5sh5rbsOfb34VWE?= =?us-ascii?Q?tDvRTpRVXHHW3Q4HRzjHo154fs2hnAwPR/PiabNfPi+jsJoqC57gC37Hnt5F?= =?us-ascii?Q?NGIhlTPXtgIkY8Kx4sj5RmfKJDKoF3yknS6VJZMCxbauUg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB5613.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5Qm1Nn4qXAO2a4FwuPGlml4ar1KbENplicDUNC5Aqq0f21Zc7pCZHvY+my7T?= =?us-ascii?Q?+V00WgE7FDy/6Z+NYYx3P4lzhJ2f2E/3OR31dzRJI+2Zepvasvo/YvA6DMA3?= =?us-ascii?Q?2o+GZ4CsvHjTbr4NAdXWLcK9bvbFnkY0MmAzCjYSEeQdxq0V0odEVqZ+4lap?= =?us-ascii?Q?P7Jp/unQ2RKM6e+Y7DaKrbD1XFFeSPxIQm50mRvNnFdKA7qjFkDWV9kilX8J?= =?us-ascii?Q?uIr28PUIepHx4bdkMgS5qF8LGrsdWdjC9qjrgfn/S5r8aSiwNhijPm5E9/P+?= =?us-ascii?Q?+NJ5cnKYyHg/3iVwVq8k9c/fisMGm6vB2+LjM6XWN17+jxVkHSCktAlCQUJa?= =?us-ascii?Q?HmRYCxThV+bVjrlquJfmd/VEaEhIoPCDbKrH/rUGdKXBmHqhM+3j8PCpgu0X?= =?us-ascii?Q?oMCr/2WKSeTII9vZy2OxItwpk3LeMInymKT4pPHWdZNjDcuwwAdiKtN34vjv?= =?us-ascii?Q?ZNb/oy5n5X4AEJmuJrUvChQfIWFn/2BA3UAQL1XQhdwqp3dN196ytgcRGFtu?= =?us-ascii?Q?4MeEKPnQRaUw5fpG6WqOAWB1fKGk/HGWfIFaU5Kz4IgjlKHlqP0LVvU/Tldq?= =?us-ascii?Q?owQZr/4isQ7IaGSSTHzPEZ6zwOXXM6+nMcYhzDSwoszocOszB70dEIY9JCSv?= =?us-ascii?Q?kYyx6Nfy9ySXoUCx3Y4ek6mgn7x+41pnJTt6p1gNF5Q7O4H0JqWu9XP03gHU?= =?us-ascii?Q?EQ27+Og1OQvmruBOkJnAx3v8GEDOfLzavJiJzjgFFKHpg49DOKtefc9jn9UO?= =?us-ascii?Q?b+CuzLU3zjeGhtCCvUxXV25cFwmRuglIGmnquwmmGfQzmURj8nKX8x2grCRj?= =?us-ascii?Q?8DxNyF65Pm0Zu+Wka1lpmOIJvLrGGcG6H4grpGH9YbCi1m/P5JIsE2deRvCx?= =?us-ascii?Q?u5GP5xqtiXj8SjpWDEwpEi94dPq5uW3IAcGUqKSrN27OGXfw77Udt0+wfU+y?= =?us-ascii?Q?mCOEzgQ8CJPJmBGVpCmhWXJt7DVzTsCevBW2ntPAKmnGvqeWYY+iruJ2xEBw?= =?us-ascii?Q?r75375v+F8oYzswUlowJiywh0Jk/Gct/n9+L2JI2KGvcavclJls3iRsKxjuO?= =?us-ascii?Q?VTOd7DF5MovkIFvA0dv+BT6GX/mmBYl0REgJ88yjIqV5ObAooC/gg7CR2dR9?= =?us-ascii?Q?Pj6nsdkf7na3lcjzr7MGjCQzzibhUKvFWsU6WFO/osbbkRm0aWrPfyJyfXQL?= =?us-ascii?Q?GB++5a4dU044VaTfjfUC+dOBu6tc9Rm9XSkaEF9QR9XB1D7BPfi70kay12sx?= =?us-ascii?Q?yvlSSN0mi6QV8rFsbL18saVKK2BUs/5NI66lHLSy3dQy8qg2rgT2CqoZ9Ou6?= =?us-ascii?Q?HLfIOOr2Mecjg2ErSbDKj8DRg1AseEnTs2n1hMNve1D5GQAPLwhIYixvQGtj?= =?us-ascii?Q?x/uwiw9EWCG+RlVWI9PdwVp13KTCOt2OdSACQ2hoV/jrUaahOphFC2cdvlvc?= =?us-ascii?Q?YaL174eMZfP+3hcbXRpg8irQVSAToSfOqoB9bGU713bsSXhArYYb7rwAAKLw?= =?us-ascii?Q?TLrEyp0yY7g1F6sbGXjTeFtbM3WQoY0zsbZ7Si1GvJxFsbuLi6v/C5ZangPb?= =?us-ascii?Q?HhsAk8PyIklbpudqiBXWBO9+679SoUkNpxrJuTn5nrXbUc92m6TXYFOdS6tl?= =?us-ascii?Q?EWq0niUVT+pFQukFAr57ZdUmobhxP2xqRnOM7WFgemXc2kWdegI1FU5zx8M7?= =?us-ascii?Q?4Pyydw=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: q7Nuuy9dtZ2m0VpekQepqIOiEwSHY+ugBgUUuYTLSQrLgtiYaURvv7Wps8GPhS9NkYodZELNF3fDhiNzXqOu0QR2Y07fEv+mcUWE2OF2487ezNzCbb8HkNBkVfNVdByvwtD1u8P6diPogZkWYzvmww16ZZU4Rao02oJslN9GL4Or+Dpkc5rs8CoyHeCrm9HuICHS9O3lP5DvVrGPteLbsNnH0LRPq8tzN+2G6xOktUuMUY7zFDMD864n5T0Tird7PLrk10idEqZPZBhrgRHKJpIZNnneOpHBkaYDfp0fRmfMN5uwTNLIOy32NQ1g1XMXCTUdND4L5sgxLgSw+NECtCABFPzprNVG0FvXPW3biVqWHEI32XXQORb6DP//9TmUlz7yTEB9XtAO5nB1RBBeHSz1i1k0fs9EvQjmDKpdwrCzToJhdI4GFRMnhPx3Wtpaw9FFkowZ+wUhPKSqrWLkURHe4qug2c1lleGfolMImcIk3FYDb6BrbvE8DtvV2+vyarKLY/lXwzfenkwbFNxZiRu66mTmx9Ef+NyI5Lm+22O6XSRVlszhOGyc5nmerNBOR5jDNRJa4nL4Oqw++Wn1qEGqhmXrcN7jf09XdydMMHU= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ccf7dd3-b388-444d-e365-08dcae6e2b4f X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5613.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2024 18:58:57.6761 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oec8jy+7Qx5zLVr7qjQV2caQnW7VCm86z4nYQaxG4PZDcPT969GjOatgTRa/cLjbzmJYJKwE9cyY1COxu/e6bospZAr15mNtNfWd0rODcqU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7239 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-27_13,2024-07-26_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2407270131 X-Proofpoint-ORIG-GUID: NK44Wq4HK60901T4FTr_S0s4gr76U5Th X-Proofpoint-GUID: NK44Wq4HK60901T4FTr_S0s4gr76U5Th X-Stat-Signature: 4pefwtp9c1zs1n93ca91j7tx5i74x7yd X-Rspam-User: X-Rspamd-Queue-Id: 2FA4F40006 X-Rspamd-Server: rspam02 X-HE-Tag: 1722106823-820969 X-HE-Meta: U2FsdGVkX18NfGCdUdL7KuV4MXav+mqYOPAeN57DvjwvTl25OMeEspfR0HXfTcDZZXumLKFe5QsyOuat+0i8GhnMDPtTAxeZJ70a8D3Vje4NZjoSos493k/p49S31f3TiUN+9B9i5FYztHcfUzPIqm01QrUWFRWlycmZD9Yy12K7VUte/sr3tCbiW/w/4CxE8pDfzrb+3IF/y4rBS9p+xAwJ1uzE1axmKCAfzC0QOeo1oiUFprAlMGyfcAvsCrjy8n/4+QJn6oTsB/bDX9E3mdCCLB5lQCcU+VGat1/kL3MyradY3XWnXyDl1Uu5KuxaRRvmdR2gvOPqyLB1Pf+8708F0nNMRsGtb4N3X+7QhOL29u4LiqBBDEpmLo0LARem7uRWkKR5ghsNMIoEAhEhi1G/iYM5s7JGDXFJCAF6A3VI/Fl+3KbrmStZHm71EmA8mJymHmcZhZcuhsVDA/VDEVtSlCooXwUxYfMTHtNcKW6efZfKROGhw7k/XCsuhciZLyuIiFqTQ61+GoS4qeoTcQFpF0IesuXtzPhR5/7RjzRvd0fjH+huXe6ekTa8iWNPw8lCVcN4CAqdnEto+xToUy8FFfnC+K3B4oYI0G6KqesuaYxhi2CRNqMyaU9J2KbLUWPpYgyqV/p90XcOts6fggF0+sZNZBQYr0XwR/szRmgZhGFMZDe2LBKK88ZR/W9MycfJJNJUlSE00dZjehVYTvJcQGiyWWfyTiKqAA/+3H3s0BMP2KPUhDe7RukIZSAc1tFBkyNXezLzD6waS4Fqu6bpZ3S7JThWIuHdMAmrEbAd0cnAl65IoZQ4GxIZTiiHiQe5IAaKT5qmD4lYueVKvpSjgdHWAOSGef5uMBoAOMoljpoYQhaamgf7rEXvlPqEOx/KYImrQw+mCE7301WxDoMEXRculuWUJGPKooEtp56Cuy75e3AlqcWpWttUK8fS0iVxI3XbFsHKJbYNh25 a9Wz85HP Txi142tdSKeVgl+INHuiSoYLoO40T2QUiCcDfLHKSR5pUMnfpkt6ANHI0QLdRPy5TC1XhrE8+ifA3DK0NDYeWaDh/G3L+W6gjU4T+Kso77vgPDM+OUOCO1u++1K4Uwa/iV5e75/qoIzNibpuGYlL6126fPx1G3soTCFSXPHHiMxWi80yzOGMdDX2jKZTRRCG/p+mWLduJtaeAPYG0tdpleukRt3HZgDIm/M0lzDhFhbf9Pl9eFAMuPoX5p1QCQUqosyGJ6UnXlFYWvTZos1mxMJHckFx2OI9COsxjJv5S3UO7zR8pp3Qoxce71aB6MsLpDF7/gNNmSD8cUJdj6eFJOkX8mC4jnoVZEEEVsUktjJrc3WJ0vR92JDysb3kBmlWX0h1wEf56gbmqK1FMQTvTB8SUAFDgn+djpl8FGzvlo6YKA8ImxKKy6WH6iEaLb/0ytVuMybalhamPXs4qo3oAcjgZk2ON/tBKtKLLfDXS0cSk/LnLSxTlnqLFzInj/GXYADOSlvWVRS51fUqKQYW5uxyyA3DYMEKbLDny6AY+gZ/2rR05xoyLgDtUMpHdMdmTQgUZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jul 27, 2024 at 08:08:39AM GMT, David Laight wrote: > ... > > and it will spit out > > > > Longest line is drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:1136 (2346kB) > > ' ((((((pkt_size) + __builtin_choose_expr((sizeof(int) == > > sizeof(*(8 ? ((void *)((long)((__builtin_...' > > > > to tell me that we have that insane 2.2 *megabyte* line due to the > > MVPP2_SKB_HEADROOM thing, and I should apply this patch: > > > > -#define MVPP2_SKB_HEADROOM min(max(XDP_PACKET_HEADROOM, NET_SKB_PAD), 224) > > +#define MVPP2_SKB_HEADROOM > > MIN_T(int,MAX_T(int,XDP_PACKET_HEADROOM, NET_SKB_PAD), 224) > > > > to fix it. Yeah sorry just saw you had already addresed this Linus... I just went with a clamp()_t in my patch. > > Or (if I've got is right): > #define MVPP2_SKB_HEADROOM clamp(XDP_PACKET_HEADROOM, NET_SKB_PAD, 224) > I'm pretty sure you can clamp_t(int, ...) here safely based on usage. Part of the expansion is because of NET_SKB_PAD as you mention below... > Hmmm... > I've found: > #define XDP_PACKET_HEADROOM 256 > #define NET_SKB_PAD max(32, L1_CACHE_BYTES) > I'd bet that some architecture even has a non-constant L1_CACHE_BYTES. I checked and unless I missed something, nope. You'll see in my proposed patch that I jut replace this with a dumb #if as a result. > > But the 256 means the headroom is always 224 (whatever that limit is related to). > > It is definitely worth freeing up MIN() and MAX() for: > #define MIN(x, y) ( \ > BUILD_BUG_ON_ZERO(__is_constexpr((x) + (y)) + ((x) < (y) ? (x) : (y))) > which is then usable for static initialisers. > Just assuming that no one is silly enough to get a negative constant > compared to an unsigned value. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales)