From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC6DC433F5 for ; Fri, 14 Jan 2022 18:18:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 090A16B0071; Fri, 14 Jan 2022 13:18:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 018A06B0073; Fri, 14 Jan 2022 13:17:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFB836B0074; Fri, 14 Jan 2022 13:17:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0184.hostedemail.com [216.40.44.184]) by kanga.kvack.org (Postfix) with ESMTP id C9E456B0071 for ; Fri, 14 Jan 2022 13:17:59 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8F6CA18210EAD for ; Fri, 14 Jan 2022 18:17:59 +0000 (UTC) X-FDA: 79029701478.21.7092C3B Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf22.hostedemail.com (Postfix) with ESMTP id 87C45C000B for ; Fri, 14 Jan 2022 18:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642184278; x=1673720278; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=ESS4JLWQLJTooACDgnGQbyKtubRvAZlerSf3Jz3ope4=; b=IKtDvJRKe6iHKXew/Zfnzl3FgD8EHY71x4R+JboMcek4KGxxKiyl96h+ OvC1EoQ2pkKd6AR3CqpEk0BmttxkU+kB3ZU2tYjJlUJTpDmrpt/4eqzRo 6JZRLZB+Qzbh9lAoG5z6gmVk+9XVCZ01uqjjZ4VPTRfjiOIBfftxCoLOf arvb0AjbVd1M2MWnBD0rXglvF9UtpCh2XiN+ICYiKsVAykzZGbXE3aQ7T kQqnGlKqx+J1nTJt4CniA9OVPjykl5qdwlxIk7Gm9+BshXdNqX7QrKUmy zaLXuacd8evLscsvg4QhRB8r2JZMXDSMbuMe6Gy5/RLE0scSBHSrB4Krv A==; X-IronPort-AV: E=McAfee;i="6200,9189,10227"; a="244502769" X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="244502769" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2022 10:17:57 -0800 X-IronPort-AV: E=Sophos;i="5.88,289,1635231600"; d="scan'208";a="491602157" Received: from richasha-mobl.amr.corp.intel.com (HELO [10.251.12.158]) ([10.251.12.158]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2022 10:17:56 -0800 Subject: Re: [PATCH v5 3/5] x86/e820: Tag e820_entry with crypto capabilities To: Martin Fernandez , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-mm@kvack.org Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, ardb@kernel.org, dvhart@infradead.org, andy@infradead.org, gregkh@linuxfoundation.org, rafael@kernel.org, rppt@kernel.org, akpm@linux-foundation.org, daniel.gutson@eclypsium.com, hughsient@gmail.com, alex.bazhaniuk@eclypsium.com, alison.schofield@intel.com References: <20220113213027.457282-1-martin.fernandez@eclypsium.com> <20220113213027.457282-4-martin.fernandez@eclypsium.com> From: Dave Hansen Message-ID: Date: Fri, 14 Jan 2022 10:17:55 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20220113213027.457282-4-martin.fernandez@eclypsium.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Stat-Signature: bqxpjxesuiq76i78mmy3z46xo71zr1ot Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IKtDvJRK; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf22.hostedemail.com: domain of dave.hansen@intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=dave.hansen@intel.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 87C45C000B X-HE-Tag: 1642184278-568470 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/13/22 1:30 PM, Martin Fernandez wrote: > +/* > + * Update crypto capabilities in a range > + */ > +static u64 __init __e820__range_update_crypto(struct e820_table *table, > + u64 start, u64 size, > + enum e820_crypto_capabilities crypto_capable) This looks like an almost pure copy-and-paste of a 70-line function. That's not the end of the world, but it does seem like a place where refactoring is in order. The rest of this series looks pretty straightforward, but this part in particular is the most worrying.