From: Dave Hansen <dave.hansen@intel.com>
To: Martin Fernandez <martin.fernandez@eclypsium.com>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-mm@kvack.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
ardb@kernel.org, dvhart@infradead.org, andy@infradead.org,
gregkh@linuxfoundation.org, rafael@kernel.org, rppt@kernel.org,
akpm@linux-foundation.org, daniel.gutson@eclypsium.com,
hughsient@gmail.com, alex.bazhaniuk@eclypsium.com,
alison.schofield@intel.com
Subject: Re: [PATCH v5 3/5] x86/e820: Tag e820_entry with crypto capabilities
Date: Fri, 14 Jan 2022 10:17:55 -0800 [thread overview]
Message-ID: <eea2c529-b874-58e6-f0b2-1483cc7e30a6@intel.com> (raw)
In-Reply-To: <20220113213027.457282-4-martin.fernandez@eclypsium.com>
On 1/13/22 1:30 PM, Martin Fernandez wrote:
> +/*
> + * Update crypto capabilities in a range
> + */
> +static u64 __init __e820__range_update_crypto(struct e820_table *table,
> + u64 start, u64 size,
> + enum e820_crypto_capabilities crypto_capable)
This looks like an almost pure copy-and-paste of a 70-line function.
That's not the end of the world, but it does seem like a place where
refactoring is in order.
The rest of this series looks pretty straightforward, but this part in
particular is the most worrying.
next prev parent reply other threads:[~2022-01-14 18:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220113213027.457282-1-martin.fernandez@eclypsium.com>
[not found] ` <20220113213027.457282-2-martin.fernandez@eclypsium.com>
2022-01-14 9:50 ` [PATCH v5 1/5] mm/memblock: Tag memblocks " Mike Rapoport
2022-01-14 12:20 ` Martin Fernandez
[not found] ` <20220113213027.457282-4-martin.fernandez@eclypsium.com>
2022-01-14 18:17 ` Dave Hansen [this message]
2022-01-17 12:42 ` [PATCH v5 3/5] x86/e820: Tag e820_entry " Martin Fernandez
2022-01-26 14:03 ` Martin Fernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eea2c529-b874-58e6-f0b2-1483cc7e30a6@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.bazhaniuk@eclypsium.com \
--cc=alison.schofield@intel.com \
--cc=andy@infradead.org \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=daniel.gutson@eclypsium.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=hughsient@gmail.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin.fernandez@eclypsium.com \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox