From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D979ECAAA1 for ; Fri, 9 Sep 2022 08:15:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB7148000C; Fri, 9 Sep 2022 04:15:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E682980007; Fri, 9 Sep 2022 04:15:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2ECA8000C; Fri, 9 Sep 2022 04:15:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C37F180007 for ; Fri, 9 Sep 2022 04:15:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9EB60160314 for ; Fri, 9 Sep 2022 08:15:08 +0000 (UTC) X-FDA: 79891836696.13.FAC1263 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf29.hostedemail.com (Postfix) with ESMTP id 03BEA1200B9 for ; Fri, 9 Sep 2022 08:15:07 +0000 (UTC) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MP7z83tTQzHngR; Fri, 9 Sep 2022 16:13:08 +0800 (CST) Received: from dggpemm100009.china.huawei.com (7.185.36.113) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 9 Sep 2022 16:15:05 +0800 Received: from [10.174.179.24] (10.174.179.24) by dggpemm100009.china.huawei.com (7.185.36.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 9 Sep 2022 16:15:04 +0800 Subject: Re: [PATCH] mm/memcontrol: use kstrtobool for swapaccount param parsing To: Michal Hocko , Andrew Morton References: <20220908083452.2844125-1-liushixin2@huawei.com> <20220908150248.85fff32bf275844f0927a856@linux-foundation.org> CC: Jonathan Corbet , Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , , , , , Kefeng Wang From: Liu Shixin Message-ID: Date: Fri, 9 Sep 2022 16:15:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.24] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm100009.china.huawei.com (7.185.36.113) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=liushixin2@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662711308; a=rsa-sha256; cv=none; b=geD4bYTEGotgnUgPvFcY/DaxFn5rytSxfwF82o9G+625QswdlMh9bliZYGfX6qdtdB8b7i OB/4zM1Bi9243EPyPNOTIFay+VkOYtG2YfmMZQKZcQhEpcu8/jMoMY0RMR+BGVrLvcu1Wv 1SEA57Hdh+eatup6y0XxqTmg1m/eeVc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662711308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QumEMNpJ4lQtIUEUoPYm6XdEYJHbo7yQ8eYCyoAYWJs=; b=uduULGb1tfIxNH7jMpfx/JmrLQUx5dDwBPjGB5MgDYgKWTudC356KGV56t5vK/F1YwwuQM EezN2v3ANW75y555UonnQkFl+2SWu8vW3vsYzd9UtXlYEZewgzgmbq9jJGeUvH19M4hl3C aEUxegQJerEw5s+YRY6tIfFF2vXNTHs= Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of liushixin2@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=liushixin2@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Stat-Signature: 6yydz3h4w7ota73hrrqje9npnr8m3a9m X-Rspamd-Queue-Id: 03BEA1200B9 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1662711307-807066 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/9 15:37, Michal Hocko wrote: > On Thu 08-09-22 15:02:48, Andrew Morton wrote: >> On Thu, 8 Sep 2022 16:34:52 +0800 Liu Shixin wrote: >> >>> --- a/mm/swap_cgroup.c >>> +++ b/mm/swap_cgroup.c >>> @@ -194,7 +194,7 @@ int swap_cgroup_swapon(int type, unsigned long max_pages) >>> return 0; >>> nomem: >>> pr_info("couldn't allocate enough memory for swap_cgroup\n"); >>> - pr_info("swap_cgroup can be disabled by swapaccount=0 boot option\n"); >>> + pr_info("swap_cgroup can be disabled by swapaccount=[oO][Ff]/N/n/0 boot option\n"); >> I'm not sure this really needed changing. "=0" was OK and the message >> now looks rather silly. > Agreed. While swapaccount=0 is clear the extended form, even if correct, > might just confuse some admins. Thanks, the previous info is more appropriate, I will update the patch.