From: John Garry <john.g.garry@oracle.com>
To: Robin Murphy <robin.murphy@arm.com>, joro@8bytes.org
Cc: will@kernel.org, pasha.tatashin@soleen.com,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, rientjes@google.com, yosryahmed@google.com
Subject: Re: [PATCH v3 2/3] iommu/iova: Reorganise some code
Date: Tue, 6 Feb 2024 11:05:59 +0000 [thread overview]
Message-ID: <ee6ec5a8-e2e3-4811-94f1-d6c25b981a38@oracle.com> (raw)
In-Reply-To: <d4753562f4faa0e6b3aeebcbf88fdb60cc22d715.1707144953.git.robin.murphy@arm.com>
On 05/02/2024 15:32, Robin Murphy wrote:
> The iova_cache_{get,put}() calls really represent top-level lifecycle
> management for the whole IOVA library, so it's long been rather
> confusing to have them buried right in the middle of the allocator
> implementation details. Move them to a more expected position at the end
> of the file, where it will then also be easier to expand them. With
> this, we can also move the rcache hotplug handler (plus another stray
> function) into the rcache portion of the file.
>
> Signed-off-by: Robin Murphy<robin.murphy@arm.com>
> ---
FWIW:
Reviewed-by: John Garry <john.g.garry@oracle.com>
next prev parent reply other threads:[~2024-02-06 11:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 15:32 [PATCH v3 0/3] iommu/iova: use named kmem_cache for iova magazines Robin Murphy
2024-02-05 15:32 ` [PATCH v3 1/3] iommu/iova: Tidy up iova_cache_get() failure Robin Murphy
2024-02-05 18:15 ` David Rientjes
2024-02-05 18:51 ` Pasha Tatashin
2024-02-06 11:01 ` John Garry
2024-02-06 11:25 ` Robin Murphy
2024-02-07 16:38 ` Jerry Snitselaar
2024-02-05 15:32 ` [PATCH v3 2/3] iommu/iova: Reorganise some code Robin Murphy
2024-02-05 18:17 ` David Rientjes
2024-02-05 18:51 ` Pasha Tatashin
2024-02-06 11:05 ` John Garry [this message]
2024-02-07 16:41 ` Jerry Snitselaar
2024-02-05 15:32 ` [PATCH v3 3/3] iommu/iova: use named kmem_cache for iova magazines Robin Murphy
2024-02-06 11:24 ` John Garry
2024-02-06 11:32 ` Robin Murphy
2024-02-07 16:43 ` Jerry Snitselaar
2024-02-09 10:46 ` [PATCH v3 0/3] " Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee6ec5a8-e2e3-4811-94f1-d6c25b981a38@oracle.com \
--to=john.g.garry@oracle.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@soleen.com \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox