From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8DD1C352A1 for ; Wed, 30 Nov 2022 10:11:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B4B36B0072; Wed, 30 Nov 2022 05:11:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 564F76B0073; Wed, 30 Nov 2022 05:11:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42CF56B0074; Wed, 30 Nov 2022 05:11:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 34ADF6B0072 for ; Wed, 30 Nov 2022 05:11:32 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F1B1EAB7AC for ; Wed, 30 Nov 2022 10:11:31 +0000 (UTC) X-FDA: 80189691582.09.99D5649 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id DBD17100007 for ; Wed, 30 Nov 2022 10:11:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669803089; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SH27Slsouj00dLidJeYoe+PORUNdekUcaagS5Y6tfm4=; b=RNuUyPXDYBvntlno589geOtiHUn8YYsAMMr7UH5YanOToJFy1dF+8b3TOw/RESMXXUMCrW FiYQP1mgNG2G1wBAMT5+MzL3RVeXcAjxiK+XzmQwmGH87tKDrEiu+GzbOGk/yJPrFiki1n 4C0IMZVU2Ps28m9oezfWA4CbLmT5LH0= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-470-MRqoVj99NL6B56iPVV0wjA-1; Wed, 30 Nov 2022 05:11:26 -0500 X-MC-Unique: MRqoVj99NL6B56iPVV0wjA-1 Received: by mail-wr1-f70.google.com with SMTP id e19-20020adfa453000000b0024209415034so2651777wra.18 for ; Wed, 30 Nov 2022 02:11:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SH27Slsouj00dLidJeYoe+PORUNdekUcaagS5Y6tfm4=; b=J78Rrl263p7sK17eQsMUn/9SsIIaVjLMYXHRld3R7FZ1BO4tkuyN5KKdGFmeMvmkuA OMROjgENaR7ac6i7/17ZPtlUdhSY1XQtxmrllIhn+bGajoyh47tlGSJ6pgkl810n/qMi kDnsdezW2w6y8a6pszpg9zkSfWuNWnEGD8Q6gUp1HdRIkUmKhK2UpJOsJa0GvOCoyXU0 FZr/NkwWUEkxOouhN6RbOqfj3a9K/hDnjW5bfqiEmf3tE9hgjN3DrX015+tTI3U8g7vQ PjpH80bXvwKBRM+JGq/zsqfcwszK7U+2exLM3nZJ18P/R0oVv87+Ub8Ui94OJAE7BiwC ckpw== X-Gm-Message-State: ANoB5pmp2OkDenv6lgZP2JcUDU5m9DEc4jtJJaXpj7rZludE849sdUnn Fg7WRjvJ5D1l7OmMv5hUC6fRCxNULDajGJtVO3H7PAI9lKqaW9viYVT4dC3vSK0Pi4thwIJrIvE mctfL6s13wp0= X-Received: by 2002:a5d:52cb:0:b0:236:4a87:2c25 with SMTP id r11-20020a5d52cb000000b002364a872c25mr36267348wrv.19.1669803084714; Wed, 30 Nov 2022 02:11:24 -0800 (PST) X-Google-Smtp-Source: AA0mqf5+KpD1E7gNGYpwXrZp+0JqgVnfC8gVUoc+Iv0/fDTkcFi2v2R4M7bL0kmdvamjefN52ZEAkg== X-Received: by 2002:a5d:52cb:0:b0:236:4a87:2c25 with SMTP id r11-20020a5d52cb000000b002364a872c25mr36267337wrv.19.1669803084433; Wed, 30 Nov 2022 02:11:24 -0800 (PST) Received: from [192.168.3.108] (p5b0c6655.dip0.t-ipconnect.de. [91.12.102.85]) by smtp.gmail.com with ESMTPSA id n5-20020adff085000000b00236c1f2cecesm1313464wro.81.2022.11.30.02.11.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 02:11:23 -0800 (PST) Message-ID: Date: Wed, 30 Nov 2022 11:11:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 To: Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: James Houghton , Jann Horn , Andrew Morton , Andrea Arcangeli , Rik van Riel , Nadav Amit , Miaohe Lin , Muchun Song , Mike Kravetz References: <20221129193526.3588187-1-peterx@redhat.com> <20221129193526.3588187-2-peterx@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH 01/10] mm/hugetlb: Let vma_offset_start() to return start In-Reply-To: <20221129193526.3588187-2-peterx@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669803091; a=rsa-sha256; cv=none; b=VHOM4NOLNdkxDR/1Pb8cgJVBPUE45ksnqzO8BG4u4i2bQoYADh/+AZrba18Shkg4RE/sjK 6tcMrBLoeujxqfoFez93Y/yytYP+tZEMRtcorWkYronWtRT5MI4eDiZYKQt1XDY0aQSuO2 OjcsxKb076g+8ba7J9SDKIgZx5KYgaY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RNuUyPXD; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669803091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SH27Slsouj00dLidJeYoe+PORUNdekUcaagS5Y6tfm4=; b=Al1KDMXwsrhjkrpo6W8nprr7YLOgEwBEBSi6WHxijk2iBpP02nf2/wwKaRPMcvcsfH3v1t oz1xctsdvyC//hWYYh6zqzfdf2oQHoacsPomm81eyqwF89mpYvLc0G1Mf/XeZ3JZk5UL0G sDvciZeXYKbTCCS6PHYQh2qU91G4hZo= X-Stat-Signature: 861qcuqg7dseg96wifww664rjubr3z46 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RNuUyPXD; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DBD17100007 X-Rspam-User: X-HE-Tag: 1669803089-805233 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.11.22 20:35, Peter Xu wrote: > Even though vma_offset_start() is named like that, it's not returning "the > start address of the range" but rather the offset we should use to offset > the vma->vm_start address. > > Make it return the real value of the start vaddr, and it also helps for all > the callers because whenever the retval is used, it'll be ultimately added > into the vma->vm_start anyway, so it's better. ... the function name is a bit unfortunate ("offset" what?, "start" what?). But it now matches the semantics of vma_offset_end() and the actual "v_start" variables. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb