From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53D7BC4332F for ; Tue, 14 Nov 2023 16:15:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC85E6B02D7; Tue, 14 Nov 2023 11:15:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B78EA6B02D9; Tue, 14 Nov 2023 11:15:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F3C26B02DB; Tue, 14 Nov 2023 11:15:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8C2E86B02D7 for ; Tue, 14 Nov 2023 11:15:08 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 60DEDB5BB3 for ; Tue, 14 Nov 2023 16:15:08 +0000 (UTC) X-FDA: 81457059096.17.DF2FD5C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 06BD3180020 for ; Tue, 14 Nov 2023 16:15:05 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i+tkSRcl; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699978506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qQqdDU6BkTtdEZPEXawtARsEiRxQp/2umHj4Nbx11vQ=; b=YoFzZDs/Rhlc81iNzJDZ+Kde2SBqtYH9W972z1Uwrbs2xGaSHsRC3Gz4p+IFQB0CXZ7t1X /EDBRHedHpAAzdwSaNEP0S+bM2xlh5bRfO7dCqtyst2p0InUIFRI5khN1tPvMzelOitIVb TFZb3BqcOYvqPcyZ/cfUMaAf0YhGgdU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699978506; a=rsa-sha256; cv=none; b=y9liftMJBzzrveioUWnKZmE4uS4ukWxPqKOL1u0W8FrDINupfM0bf8P4M9VplUMVXscNIH 5MRTXtRKDG2UKqfupHcC0bthnKrVNkjMCA7N4OBLHsIgDndQgPuj9kXIE2cEV/kTZ4P74A YWLN95FkDi8wmlwgZf/PFW5lM/nNEQg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i+tkSRcl; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699978505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qQqdDU6BkTtdEZPEXawtARsEiRxQp/2umHj4Nbx11vQ=; b=i+tkSRclIqVefZuSUtgqz5/gl/to923gUldq3LvmcyJcwPa5lCui7k+KFVoKLDI/ukgqMG KQATJJg4qVNlWJxCUB/c872KuHK83aQgXCE4ZdW6fKkyL2SBWTF+9XiO2A1Muh/1Vwu8Fh ZpyS+1R7fwiP3mQZDID0T6LhaWWDCRI= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-82-PW7vCxB4Nhu5S49ozSB9Rw-1; Tue, 14 Nov 2023 11:15:03 -0500 X-MC-Unique: PW7vCxB4Nhu5S49ozSB9Rw-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-32f8cb825c5so2781062f8f.2 for ; Tue, 14 Nov 2023 08:15:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699978502; x=1700583302; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qQqdDU6BkTtdEZPEXawtARsEiRxQp/2umHj4Nbx11vQ=; b=kykmDpU+vxUhJAobivy5Pd63dw//dWKIr/phGvJzGx/IHUsrHOmbVq7SMJQ5P0mI+5 p0C+9icjL4Poh3zCbnJA7VWni39cNNesB4hYjM9/uwYR5xCmg8z8cvRANiDS5mPweDc/ iV6IVvg/MOiIGISRewm3CkRMMZEUjo/+Iktxa1VNTNN++2aonp/KLk2WWygk4kXolkYn q6kB6c60BziHfiInFxuzziDy47DC5HqUgDVVup2nVL9RgTN+3LZ3WlNTzF2N32zZ3JIH x/Tp4hURwhNCFpm2MCkP8Od5lTBvf1TmCB2Cg8MgZoCWq4c2fh5MZk9eyPBhpCe6OgK2 Bw1w== X-Gm-Message-State: AOJu0Yzsgr7FnknCm1GnebGuicSoO4HtlidsIKMdS8Mz/b3nqwxOF52L nhX4KhIDmhkmA2xUsFiauktpbz3H0ErQq7MAo228/wj4IsqXijNko25oQlVcRY8FM+TjZec7DkF MzhJxKrc2GF4= X-Received: by 2002:a05:600c:1986:b0:407:8e85:89ad with SMTP id t6-20020a05600c198600b004078e8589admr8467804wmq.14.1699978502000; Tue, 14 Nov 2023 08:15:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IFjgLMBVuteRAgWkzkndIX3pveFJIEqk4P2Litcso3U6qfsh4sX6A4EQnMXE2pAdfBdnoZd2g== X-Received: by 2002:a05:600c:1986:b0:407:8e85:89ad with SMTP id t6-20020a05600c198600b004078e8589admr8467782wmq.14.1699978501516; Tue, 14 Nov 2023 08:15:01 -0800 (PST) Received: from ?IPV6:2003:cb:c73e:8900:2d8:c9f0:f3fb:d4fd? (p200300cbc73e890002d8c9f0f3fbd4fd.dip0.t-ipconnect.de. [2003:cb:c73e:8900:2d8:c9f0:f3fb:d4fd]) by smtp.gmail.com with ESMTPSA id j21-20020a05600c1c1500b003fee567235bsm14439647wms.1.2023.11.14.08.15.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Nov 2023 08:15:01 -0800 (PST) Message-ID: Date: Tue, 14 Nov 2023 17:14:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 0/2] Introduce a way to expose the interpreted file with binfmt_misc To: "Eric W. Biederman" Cc: "Guilherme G. Piccoli" , Kees Cook , sonicadvance1@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, kernel-dev@igalia.com, kernel@gpiccoli.net, oleg@redhat.com, yzaikin@google.com, mcgrof@kernel.org, akpm@linux-foundation.org, brauner@kernel.org, viro@zeniv.linux.org.uk, willy@infradead.org, dave@stgolabs.net, joshua@froggi.es References: <20230907204256.3700336-1-gpiccoli@igalia.com> <202310091034.4F58841@keescook> <8dc5069f-5642-cc5b-60e0-0ed3789c780b@igalia.com> <871qctwlpx.fsf@email.froward.int.ebiederm.org> <9f83d97e-b7a1-4142-8316-088b3854c30d@redhat.com> <87ttpouxgc.fsf@email.froward.int.ebiederm.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <87ttpouxgc.fsf@email.froward.int.ebiederm.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 06BD3180020 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ag5h3yahcsk9qchryxmgwzg43a4unp3z X-HE-Tag: 1699978505-294021 X-HE-Meta: U2FsdGVkX1/p/FJMsMJzBmOz3/Ue/z9GAixMV4KKUNOKX9SBhde2G23mYZn2XZr/CjiOUDQQ7P/pMzHuSwr4ZyMosC646OIX4zTXLKFJ9ITmS4ndVKtzMDchXDc5dO76lqLNj4dmHAFV50meMy/qslY4D9XWuFAjjo3KINDxI3Ynr5viQD9UHc0nYVf8OgpZODRl+Q/4fXu490GL/5MFjtvmyuDU7yZGdf7cvvDrrf9WOxYN3/JYOcZt/ofG0hRnv8HS5oF4ATPIYPXFbUUOvhMWjAka01fZO98AJy5KjN87R1BzHGKHtXc7EUVc6Z9X28nQCGW6nAkhFeeQkKBlEoFpzg/WjZnkrCjft0gmIub5CmS+A7Vv3BJCh4cZ4I5VtxH89HW9p/i4jbQkGnGuQhvpCZtR5TVAEIZmmQvew9SPUbbgQ60PBKmj1Up7pqwl9Rfcz46u0inpJNW4qjnm/hzEggAgdxhDZSRWYqn8jZlpuBM4tAxNN7mnqlhNJ+bC5GRx+vv1AWP7hbYgZHe4jWE75P5KhHrqnzoDxiIDqvC1kT7baGzkb2ZqLgY2svee6ZJkf6CIg1UBGrOYXqo6OyGW429p8oiYJNsISJQPd82ZGyCuP3NOiKQ4rNeG7zjRSS5o3JKqLK0V/8hdUj4q1xsSdZA9Y2kQA/2uMfP6Ca06KhaVLPE7c2rPnoUJ+vmg5EbVRPr9BllGR3FdTBYYlFetwQa54is5/Z8Pu23TAr3CCPBPdi9D9aXCNhP+gT7KQ8vQjzf/rDPtUEHG6/rqutEBxbKILDKOz/DR+sQk+Lm3Wt+oy9VE78NRRIxwIBqSGjD5QuDsvmpOXXePAYfckiVNSCPBTQmHS0NfVeBHjLGoESbvDPefhW5/M7eqQ6mZ7S1BOTIMg9fbwAIJAoypqIW4eswY38oYR+nqGs9XaTo+c4MswXxM9rvc1p7hNnPZ9MRuwqi4JF3RL99Exyy gDbrWmLK 9Hh9KD3Hyk0lZOgmhe0EJKOtbwOxHjwAfASDNuLtzwpLgtSqwuZ+7sGAs24GxuEdzjw0XPq9DTyDo0Zp8d4/Cpi/BXaQJXJNJKQDiJMdJZAXzSpJ43qiQt8FQuIofLrQBcIp1gK0ch/TBjreAdePME3jRKxUZUow7Wmilp4W8nvLfPLpvauUR4/KECHBxpZ6+/h96VudO0WwDbqv/G1R0Yspp1rZwWr9t7w5b13B9b6pQYNZI/boPpUNMhs/2iEG/dYixlNfom2Y0Ve3w+t9cDC1VMoRGhom9gBHCeuVNliw9YjEY0N8cMN0K2pkjUTextTBUzLJYhXLkPWXpYUnSZmuGKLPqZ+tt9jjhAog+A6C0GYJaSGbzorFZN2fVA2GdcK1LTTcMTAxDbR18P91mzeFt+rsl5dE9O+rFxWaVtCV/CenbOlowSFsaj0gcpNyEeVmo8dXmLQ9lzSCj9xhUrbRWsA9N3perbpvASNvaD1Bl331xGG09J7yaWT3JxnlR95aDI8Yh+KgsCeDqStPsH4fJbbVoAmQqdY2nQetJ704mpwkld4zjqdoWpGvb+zzBCJUL0g0XxCo/3zm90EbRQ8qTpkKQtKV8hNLD6JZiOQHTx7Bfkt739EyqeA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.11.23 17:11, Eric W. Biederman wrote: > David Hildenbrand writes: > >> On 13.11.23 19:29, Eric W. Biederman wrote: >>> "Guilherme G. Piccoli" writes: >>> >>>> On 09/10/2023 14:37, Kees Cook wrote: >>>>> On Fri, Oct 06, 2023 at 02:07:16PM +0200, David Hildenbrand wrote: >>>>>> On 07.09.23 22:24, Guilherme G. Piccoli wrote: >>>>>>> Currently the kernel provides a symlink to the executable binary, in the >>>>>>> form of procfs file exe_file (/proc/self/exe_file for example). But what >>>>>>> happens in interpreted scenarios (like binfmt_misc) is that such link >>>>>>> always points to the *interpreter*. For cases of Linux binary emulators, >>>>>>> like FEX [0] for example, it's then necessary to somehow mask that and >>>>>>> emulate the true binary path. >>>>>> >>>>>> I'm absolutely no expert on that, but I'm wondering if, instead of modifying >>>>>> exe_file and adding an interpreter file, you'd want to leave exe_file alone >>>>>> and instead provide an easier way to obtain the interpreted file. >>>>>> >>>>>> Can you maybe describe why modifying exe_file is desired (about which >>>>>> consumers are we worrying? ) and what exactly FEX does to handle that (how >>>>>> does it mask that?). >>>>>> >>>>>> So a bit more background on the challenges without this change would be >>>>>> appreciated. >>>>> >>>>> Yeah, it sounds like you're dealing with a process that examines >>>>> /proc/self/exe_file for itself only to find the binfmt_misc interpreter >>>>> when it was run via binfmt_misc? >>>>> >>>>> What actually breaks? Or rather, why does the process to examine >>>>> exe_file? I'm just trying to see if there are other solutions here that >>>>> would avoid creating an ambiguous interface... >>>>> >>>> >>>> Thanks Kees and David! Did Ryan's thorough comment addressed your >>>> questions? Do you have any take on the TODOs? >>>> >>>> I can maybe rebase against 6.7-rc1 and resubmit , if that makes sense! >>>> But would be better having the TODOs addressed, I guess. >>> Currently there is a mechanism in the kernel for changing >>> /proc/self/exe. Would that be reasonable to use in this case? >>> It came from the checkpoint/restart work, but given that it is >>> already >>> implemented it seems like the path of least resistance to get your >>> binfmt_misc that wants to look like binfmt_elf to use that mechanism. >> >> I had that in mind as well, but >> prctl_set_mm_exe_file()->replace_mm_exe_file() fails if the executable >> is still mmaped (due to denywrite handling); that should be the case >> for the emulator I strongly assume. > > Bah yes. The sanity check that that the old executable is no longer > mapped does make it so that we can't trivially change the /proc/self/exe > using prctl(PR_SET_MM_EXE_FILE). I was wondering if we should have a new file (yet have to come up witha fitting name) that defaults to /proc/self/exe as long as that new file doesn't explicitly get set via a prctl. So /proc/self/exe would indeed always show the emulator (executable), but the new file could be adjusted to something that is being executed by the emulator. Just a thought ... I'd rather leave /proc/self/exe alone. -- Cheers, David / dhildenb