From: Waiman Long <longman@redhat.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Shuah Khan <shuah@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftest: memcg: Skp memcg_sock test if address family not supported
Date: Tue, 10 Mar 2026 10:09:04 -0400 [thread overview]
Message-ID: <ee563439-9ba2-4f0e-8309-fcabc527ec58@redhat.com> (raw)
In-Reply-To: <38c7a9a2-a8f1-4ae2-9070-73d0ebb42f53@redhat.com>
On 3/9/26 8:04 PM, Waiman Long wrote:
> On 3/9/26 2:07 PM, Michal Koutný wrote:
>> On Mon, Mar 09, 2026 at 12:02:05PM -0400, Waiman Long
>> <longman@redhat.com> wrote:
>>> On systems where IPv6 isn't enabled or not configured to support
>>> SOCK_STREAM, the test_memcg_sock test always fails.
>> I think IPv6 is not substantial for the check...
> I mentioned it because the current code is using AF_INET6 family.
>>
>>> The purpose of the test_memcg_sock test is to verify that
>>> memory.stat.sock and memory.current values are close.
>> ... so this should work with IPv4 too.
> Probably, I will try that out.
On my test system, creating a socket with IPv4 does work. However, with
IPv4, the memcg_sock test becomes unstable and it fails half of the
times as the memory values aren't close enough. It is possible that the
assumption that memory values should be close aren't quite true with
IPv4. As I am not familiar with the networking code at all, I will let
others who have more experience with the networking side to try that out.
Cheers,
Longman
prev parent reply other threads:[~2026-03-10 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 16:02 Waiman Long
2026-03-09 18:07 ` Michal Koutný
2026-03-10 0:04 ` Waiman Long
2026-03-10 14:09 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee563439-9ba2-4f0e-8309-fcabc527ec58@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox