From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6807CC001E0 for ; Wed, 2 Aug 2023 12:43:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E226A280171; Wed, 2 Aug 2023 08:43:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD2FD280143; Wed, 2 Aug 2023 08:43:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC27E280171; Wed, 2 Aug 2023 08:43:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BA1B0280143 for ; Wed, 2 Aug 2023 08:43:54 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 755371A0DC5 for ; Wed, 2 Aug 2023 12:43:54 +0000 (UTC) X-FDA: 81079131588.25.27F87D3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 4867A8001D for ; Wed, 2 Aug 2023 12:43:52 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Zh0ReP6V; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690980232; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UOzUrt7muFZfH5D+b0L7Q8SCbDEFvQqhKmACrqvdGts=; b=U6X5jjtRPIH4pKKD0RIb0q95/UsVdnfKDma2YEEMuF/IFpJYzpYq+n3J3i8NH4J5FdRWEJ +FfhwN136uhRZ07Z7NJK75w3GY75WYzvex5pMzOyRbjQSEg2TQWWCdWUbZe31O4XqFBEN9 1iQjMvdqEn5QZxOK2BpEoFOeX8CanRE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690980232; a=rsa-sha256; cv=none; b=1OAlG1qMxt9yPnFw2/elxnaXrha0mh3Yhu6PlZOxLgvHk1wWoBwt21wND9QcjcmFFEidoJ MmNLbk5g2WxVqZYPurktjjJr2lpzDQV196OJ7yhy3CTyUmbNm1EqyDb8SO06LcSNv7bdBE tOPKAOvuA1wliVQtriQXJMO/dV7Zfmg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Zh0ReP6V; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690980231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UOzUrt7muFZfH5D+b0L7Q8SCbDEFvQqhKmACrqvdGts=; b=Zh0ReP6Vux7O9jKxJ+j1Hkt7KAc56paAHpPqDea5uhzcXkJiLeyMwHkAHmiL/u8RklB/U/ y/T0D/qaH4BCTb6FKzKEw3QvassirA+kkeOMVSpLuXoua0CzabhKzorb/T1u6ZnjrD9bI8 HZPAOuOdRcYLEUejB9rhQkGCTs9tk+k= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-IXEvCcfVMuusBkf040GVSw-1; Wed, 02 Aug 2023 08:43:50 -0400 X-MC-Unique: IXEvCcfVMuusBkf040GVSw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3175b757bbfso4127631f8f.2 for ; Wed, 02 Aug 2023 05:43:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690980229; x=1691585029; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UOzUrt7muFZfH5D+b0L7Q8SCbDEFvQqhKmACrqvdGts=; b=MMRf6PAEZjr+/iTLu/jttKnfit+PE4XvJgcKKwTDL/EnNT02UvFdw7Iq5PDjQRsfVM FBfpoqUz7qrULAITnENZagPfm9aa0oLvDDuX73ct0jPKdv00ImtwAZrw7AhKLfiFPYiW xqst2USkfYVenRZo/t8TDD3w5WtGoZhLMMS4BUYcnAkpIr1GW72CrSB9BGE1OoNn5cvu Wyvqv9VvAjwk2RRGrTDvv5UFIl/30KFim1u4yVECb2D1s4zL+E2ON/scEhEoYbefeLEj KsF1vcWn3PWhZbe/kL2THxYOBJL8iZlFlcglSYoblD5v23ugP9s7pV7niSPGA5jvQY4B EUAQ== X-Gm-Message-State: ABy/qLYXDxfYil7G9uz3MmdeMdICL8e3xElXhbBe0Wqlv7ZwdeImZ/I5 lO3S4j3FTQZvqgOmtfOQxRiofWAEdl4av4oLCkLxqbSDJoMhwfAjUc+1yVZ0awUwzi9KT3IUnRE aTUJN+uBzOUQ= X-Received: by 2002:a7b:c04d:0:b0:3fd:129d:b721 with SMTP id u13-20020a7bc04d000000b003fd129db721mr4607745wmc.16.1690980229241; Wed, 02 Aug 2023 05:43:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlGzcgncVNOJgDZsqA1DBdhJGe9Z4qiLmCg4fj5jktc5aWfKR91E0F0weNz2j8tDecBGhdGORA== X-Received: by 2002:a7b:c04d:0:b0:3fd:129d:b721 with SMTP id u13-20020a7bc04d000000b003fd129db721mr4607725wmc.16.1690980228865; Wed, 02 Aug 2023 05:43:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:e00:b8a4:8613:1529:1caf? (p200300cbc70b0e00b8a4861315291caf.dip0.t-ipconnect.de. [2003:cb:c70b:e00:b8a4:8613:1529:1caf]) by smtp.gmail.com with ESMTPSA id l7-20020a7bc347000000b003fe215e4492sm1643900wmj.4.2023.08.02.05.43.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Aug 2023 05:43:48 -0700 (PDT) Message-ID: Date: Wed, 2 Aug 2023 14:43:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 0/2] don't use mapcount() to check large folio sharing To: Ryan Roberts , "Yin, Fengwei" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, vishal.moola@gmail.com, wangkefeng.wang@huawei.com, minchan@kernel.org, yuzhao@google.com, shy828301@gmail.com References: <20230728161356.1784568-1-fengwei.yin@intel.com> <3bbfde16-ced1-dca8-6a3f-da893e045bc5@arm.com> <56c8f4f9-b54b-b0bb-250c-ec8643accfc7@intel.com> <3541d2de-5cf8-2f84-8153-277e2bfc0101@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <3541d2de-5cf8-2f84-8153-277e2bfc0101@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4867A8001D X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 7fsn68137iq487pkxcae8auio4u11jos X-HE-Tag: 1690980232-75517 X-HE-Meta: U2FsdGVkX1+mRUh0f9+OM7mV7kNz1bqgmxXdZfEfIBLfqMCWc9WrWa000T943LLmFHqt7HcBacwWFOOi9rdbAxJ+ca37NzakZ0Bil94/9DfoMtH65PRO8ghk+hpvFxAYYJuXItomNHsaZdeuQWaNZN6SQA0s/Ynusb38ThjA7chfhmEb8L/gAUmCwUKFwQ/07a8ig0C+GNKHXc+cEYKwYLS4ZeDgoRcnawJge5evQfLpFykVgNwRCFoK8qd3E3rFJN2JG1ij3B129uE3cy5tl17ipOwWvcltTAIZMfuKM7xDwl/heaA3lX/ZzOKJZfnT+VmHI4NphZVpyccPJYvnOJLi1YQZMLQC4zPDC90RKUFo8sElGEO0ttcsLZaUcO+erweTQOp0NsDv1fqsxTt0v+D3LDvNxNAtViNSObFd+GV7S9Vw2P1Q2tBxYIqeRAanoLDLUyPDfXYeXe/em/5YUFi1hZbxOeyraDLL4hSh9Uo3EFiYN7MJrt7b5iTIFBmcYzy+U+sue3klj6LX8Aknyn2XYaIkbwTVpmAbkfM+7e4SwP2TUiqlCX5COIxycqCUpZBcswVVr82A67i8OnOBfnVw73qzTk30zcM0Qx4HQJTExLLBjEZ+XtkB7KYqnZqVn58K3L8DT8IZ4KpIo4vD5Z8WYBH1dgqHPrsmCEEyF9CxlFFLEM9dZCWvvBPo77AJSxVrUnmW4O/Kf0V1t9EWn/HuEI2mtc1nyDmkLRhcTc/9/lUWMcicp9NQRH/XSGxUbcBEZWPcIJS0NOcCQR4qkRHJa9eihLZybHWtaO2mlNdP52kamZu94ON6T7yhZQXFHaoOJ1/UD8E1lF8fc3EWNwloElOj/ZrunJfRxXH8PMHOIXc2+aCCwnk3acvES6+RjZRuS2k03jD5me1vToyGQzYLWTgm8UdevVyeZsslLaQGMMj+lXFSjWd1LCxcd/45kT+eENTejNVyWlUdlIy 2BjcYKIh bfVER8O2ZIDSzJKYV+8khutpjOlh98s0K32dEaRuzsvcfM1+CK7zlHCeBSvR9i98NCz9UncKI0JzyFRG8EBYNuqrBs3tkTlpYcnDQT4PMhR5F/OPL1JUYa3sJONeSBNYympU1B/DvqetNNW/R9innl3Jf4siZcpBl2KkK1CxViaJPcNzqNkcnPok7WbqGJ6Z4d7LP6zOgfGN7UbkPsiT2HfFc+SfIPq4YsGSLRf03wlbpEvD/U58n50AfNZ719kjJIAab/3QJGVZuzb6O6xkVQ2FbwXDwYpxW2gtYkrZPPKMKdj2WVvhwN9OJkXsGoNEEYNMuPKa+DpN6qcDprTDLyDwVVM+f2nRky/BedPb2WmK4ZfFmwft6Vx6HMqFsKhFdHjSfABhhT08n1vLk9RJULQzjdPBEG+gc+1rKFzSWbMHqXUU9qPyiUxxJ5iFtLsy8R8SgBSQ6nGmcQvI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.08.23 14:40, Ryan Roberts wrote: > On 02/08/2023 13:35, Yin, Fengwei wrote: >> >> >> On 8/2/2023 6:27 PM, Ryan Roberts wrote: >>> On 28/07/2023 17:13, Yin Fengwei wrote: >>>> In madvise_cold_or_pageout_pte_range() and madvise_free_pte_range(), >>>> folio_mapcount() is used to check whether the folio is shared. But it's >>>> not correct as folio_mapcount() returns total mapcount of large folio. >>>> >>>> Use folio_estimated_sharers() here as the estimated number is enough. >>>> >>>> Yin Fengwei (2): >>>> madvise: don't use mapcount() against large folio for sharing check >>>> madvise: don't use mapcount() against large folio for sharing check >>>> >>>> mm/huge_memory.c | 2 +- >>>> mm/madvise.c | 6 +++--- >>>> 2 files changed, 4 insertions(+), 4 deletions(-) >>>> >>> >>> As a set of fixes, I agree this is definitely an improvement, so: >>> >>> Reviewed-By: Ryan Roberts >> Thanks. >> >>> >>> >>> But I have a couple of comments around further improvements; >>> >>> Once we have the scheme that David is working on to be able to provide precise >>> exclusive vs shared info, we will probably want to move to that. Although that >>> scheme will need access to the mm_struct of a process known to be mapping the >>> folio. We have that info, but its not passed to folio_estimated_sharers() so we >>> can't just reimplement folio_estimated_sharers() - we will need to rework these >>> call sites again. >> Yes. This could be extra work. Maybe should delay till David's work is done. > > What you have is definitely an improvement over what was there before. And is > probably the best we can do without David's scheme. So I wouldn't delay this. > Just pointing out that we will be able to make it even better later on (if > David's stuff goes in). Agreed, we just should be careful and clearly spell out the implications and that this is eventually also not what we 100% want. That MADV_PAGEOUT now fails on a PTE-mapped THP -- as can be seen when executing the cow selftest where MADV_PAGEOUT will essentially fail -- is certainly undesired and should be fixed IMHO. -- Cheers, David / dhildenb