From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D125CC02192 for ; Wed, 5 Feb 2025 05:24:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 40A11280004; Wed, 5 Feb 2025 00:24:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3BA80280003; Wed, 5 Feb 2025 00:24:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A93F280004; Wed, 5 Feb 2025 00:24:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0DC47280003 for ; Wed, 5 Feb 2025 00:24:16 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A929614052F for ; Wed, 5 Feb 2025 05:24:15 +0000 (UTC) X-FDA: 83084750070.09.F8D2A60 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf06.hostedemail.com (Postfix) with ESMTP id F3068180007 for ; Wed, 5 Feb 2025 05:24:13 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf06.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738733054; a=rsa-sha256; cv=none; b=y8f/1Jpfcv5kfDKX7a4ir90l0128j4cZspLRXBc1KJTk/o+rCxka3QuFqPjycTSV7MRRvV yOsW3mxNwt87LxrGiazdX1kRF8/dwb403Oa8leqQM/5IcNr714waN5nm5CslZhULORuKO4 LYsLc7KuTTtaYq2wEkefOuUi08KE5GA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf06.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738733054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0X8UQOyunVirYg6zMnsBIANS4jLb9XW4T6D+KwmQfzI=; b=q1liMLCqAzaxuxjgTQYeWGjdaa1clHUILBPtKp76l2QLQpACWZ49nPgCeSvOKyiLogY3oW 3zi1wDBjWavAJ4T9K3Y3aZDyFIadLhmNvtwJ8+314WHtDk6PwTKrpsTS+B2+Qmx8JuEKoD +0prRPIJaRg5EEUOmbUi8j9BVRxvCgo= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E680311FB; Tue, 4 Feb 2025 21:24:36 -0800 (PST) Received: from [10.162.41.15] (K4MQJ0H1H2.blr.arm.com [10.162.41.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D8E853F63F; Tue, 4 Feb 2025 21:24:10 -0800 (PST) Message-ID: Date: Wed, 5 Feb 2025 10:54:07 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Fix thuge-gen test name uniqueness To: Mark Brown , Andrew Morton , Shuah Khan , Muhammad Usama Anjum Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250204-kselftest-mm-fix-dups-v1-1-6afe417ef4bb@kernel.org> Content-Language: en-US From: Dev Jain In-Reply-To: <20250204-kselftest-mm-fix-dups-v1-1-6afe417ef4bb@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F3068180007 X-Stat-Signature: 694wuubowa3hwxu5h571uokkonpyf8kk X-Rspam-User: X-HE-Tag: 1738733053-403401 X-HE-Meta: U2FsdGVkX1+lt/aNtPugLACbkhPpRl4r3/F84wFXVsGRNB3sLGKAXZQ20jcadu7gMq5Hes2aBVdmMQN5hPol8fpi12b10JOD6ltPy4l9B17cJVvV5whqAonr+NjUUVnXjVMEgSeCbRJJIhz6FZJS6330G01HdFUlotXFawTao/SmX6mFerhSxOAMqkn6ymoDAtoB2jJqx/Yxb9eGlb1671mMLJ9W6w3mz6JzQRZIpNeTUGpnYeRM1HcEUEITbBXcS0RuH4KqgcsTdOPlSzuosTJG0DT66a7aPvmCfbnD1blU2XXqUL6OqErmkMvx+vFvxIrc4poUwUYXaM5cOr1L0ee0wzqBJJMqP1d4AxqfhLwIA6aYZ8TbPCZpsc4vtQ9BuGav/LQuHQPR9ltWuJZsvgaCwL9mq/qJriNMeVRZTrJZJsAkoO0OCe+9EO7d8O9J02rsjdQ1PQiGzkwLUe1C7eYi/tWKMCIV3xdPQKy0SDbY+ZIKFqa/ywDNkQ/MzcuW3gcAZCycDnOSqoEgLWNWP6Rt6Gz4hJ+M3h4tsacZTXsbGtJqj06RYIkuVOk6hlAdUo/DBf76acm2Z+DxQ3C+S2dRDfkpw+9HLhZ7QIX2bb5Zn/Ew5F1dlM/aluDFRvdk8PPn0PUwovnDn3rFvfLVCjTUvkv0Dgf1bTOy9DGPPxQY0GvZkQCA+B3hljZk3wnXjh7//IR7NfMOK0pYuv2Bsqk0RSp9G64tbLGPgnvGyu+thOAME8ZrQ4/RrV/iPXyeXr0GruLba6uTxNT+iv5oQ/SOhDJx6fe2XYkaMGSeKcoxkOlp5hwno7ljcR78tibQnZay7KADCxOpHZjtq057ZQZDzprfA7qgD5RO4wk1TFSvJFdIyHDVC6hd4L5GXdfyrGhqn+5lUTC7KhE0kz6rc69Bs9Lgi/8WvVkMfzHRQS7AOG21eCRosWjCRa/A/ikJGwtOukn2wLF4Ldege4b GLLgBCj/ Sd2WJ26sb3v3iXZ8CCZVK+mNb20QXITzxyRw45Iywbrn5kmGVgUUhhzbrpxlNlBB+fPK1L73bImeZzIempB1h0LuZqpyDqxZFQa5aNl8IvqU6bQbCJxZOyi10nOfqE1Vx5XeW4PQEMx2tiqI8xd6T/IMeqZdFht97G2JwCjUpSRViJQ8Y1vj4lRidb4FBo4h4vatU6HTxPN/PgpargMVECNW937oP7QlvnAL5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05/02/25 4:23 am, Mark Brown wrote: > The thuge-gen test_mmap() and test_shmget() tests are repeatedly run for a > variety of sizes but always report the result of their test with the same > name, meaning that automated sysetms running the tests are unable to > distinguish between the various tests. Add the supplied sizes to the logged > test names to distinguish between runs. > > Fixes: b38bd9b2c448 ("selftests/mm: thuge-gen: conform to TAP format output") > Signed-off-by: Mark Brown > --- > tools/testing/selftests/mm/thuge-gen.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/thuge-gen.c b/tools/testing/selftests/mm/thuge-gen.c > index e4370b79b62ffb133056eb843cdd1eaeba6503df..cd5174d735be405220d99ae796a3768f53df6ea4 100644 > --- a/tools/testing/selftests/mm/thuge-gen.c > +++ b/tools/testing/selftests/mm/thuge-gen.c > @@ -127,7 +127,7 @@ void test_mmap(unsigned long size, unsigned flags) > > show(size); > ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES, > - "%s mmap\n", __func__); > + "%s mmap %lu\n", __func__, size); > > if (munmap(map, size * NUM_PAGES)) > ksft_exit_fail_msg("%s: unmap %s\n", __func__, strerror(errno)); > @@ -165,7 +165,7 @@ void test_shmget(unsigned long size, unsigned flags) > > show(size); > ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES, > - "%s: mmap\n", __func__); > + "%s: mmap %lu\n", __func__, size); > if (shmdt(map)) > ksft_exit_fail_msg("%s: shmdt: %s\n", __func__, strerror(errno)); > } Suggest converting size to MB before printing. This will print the size in bytes which is confusing. Otherwise: Reviewed-by: Dev Jain