From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5FBBC5475B for ; Fri, 8 Mar 2024 08:48:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 566E76B034F; Fri, 8 Mar 2024 03:48:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C7946B0351; Fri, 8 Mar 2024 03:48:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3675D6B0353; Fri, 8 Mar 2024 03:48:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 235E06B034F for ; Fri, 8 Mar 2024 03:48:42 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F0576810E6 for ; Fri, 8 Mar 2024 08:48:41 +0000 (UTC) X-FDA: 81873246042.23.7B91DE3 Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by imf23.hostedemail.com (Postfix) with ESMTP id 05ED3140006 for ; Fri, 8 Mar 2024 08:48:38 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709887720; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KM+M7w7p1L9kepneBN2OoHXivaqMaHUpQVIXP7SMovM=; b=I+WH9T8Gm1/AQa+QiGNM/Hz/U7f22IP5BfgjCYvKumTKTnbBtjH5Onou6weP9DPUw8h+vs pfhLRyunCtH74wxkYYSPANdH+h/E4WM6FuMV1tuFPoPDY7eo1ELUMfc94RRsInNxBkfuqr L6g0/wnnalijZ7Ms1LkypJbtTtnOYKw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.32 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709887720; a=rsa-sha256; cv=none; b=YkbyLMWNe6kuCbmD8YQRa76TiyeO09WMaJedKfDY3HUeiOYRmsbc8psYNF0icuvJMK9Lfd SRQw7Dkm3r7gTle5BPrBUWaihiUyF3/aCqwh+D5Bz1iNzAzjYwA4TvAImWST7+qmRUHkXD +DiChSSyifTjijBJA7EhpD6TbBvdm6s= Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4TrfvD6N6zz1vwFk; Fri, 8 Mar 2024 16:47:52 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id ED4A11A0172; Fri, 8 Mar 2024 16:48:33 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 8 Mar 2024 16:48:33 +0800 Subject: Re: [PATCH 6/8] mm/memory-failure: Convert memory_failure() to use a folio To: "Matthew Wilcox (Oracle)" CC: , Naoya Horiguchi , Andrew Morton References: <20240229212036.2160900-1-willy@infradead.org> <20240229212036.2160900-7-willy@infradead.org> From: Miaohe Lin Message-ID: Date: Fri, 8 Mar 2024 16:48:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240229212036.2160900-7-willy@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 05ED3140006 X-Stat-Signature: tsaz993j1ohjghesbo94otg8kejskgak X-Rspam-User: X-HE-Tag: 1709887718-731035 X-HE-Meta: U2FsdGVkX1/JQmANEeOgEGF9sKF9j821h4in26A/dyF9wTf6y/eXMtMLICEvLI3/GibSzHjGvou3w8RTS8rsADKaiVz7y1wsA/H9cwFz3aYpvnYKeTYLEyJ9VfbJ9aKqFHh8YnS//YwbXKvBEzk52gwlsp/8RD3QSUuQx895RraAKLjz5K1s/H8k7L5v8pJEufQvrpoc7hDPeCCR2SbDlqfg83w/iZXLFBoJVkdKs41fyh5Je9jRBEDrnFwUr/oj6L0NfrzUbQLVxW/l366bQCudkfUoAPxbVqzZN7C6fJFxs04puXCiUcexo3BpPVwJfhP/U1KoPknvg0zUhT5PUqMLrXfoZUHUdsEpqEMiqRRyHfRirFMZjw3cyI5nMwMVvhd7Rl3Vhc+zT5njBii3qKX0wR5h1fejMwjW76aPo9vLz/M+YnH8ONJZBPFgJWL9scpayS1434VBELyY70ryKmZmnTYWwIfPLg0g88tQemsgdwKf73kce7k3ipsmifZZKiefBFVFlFBkeEHFH0l/rJ5KooODBqkT9vprYXqfsd8vlnbwwqBYhrV3FnuI0gKi4bbmFcmDAF0DaakbPn99CsRe6sYDuTg0i14MPTeDIBnfy+exzhrDb5EKfBhNvYM9hVMtQb2YUnhzWG/ODCsPKCAce28hfof16gmeS1/ZQ+XFIUOztQjxvLX9wLfTHVbsWy9WRfDIbsVU0TKd2FzCKQbD+pocbc9JXeEfV8Ne6nWIZtLqDMF29QjmYN+mKb+h21LDPO1VvR6dSKQOt1/OpSJ7sDMz/k9M+oTEUMai1rOelTLQLirIsi/eK2S/slKeN6nWw0DH9cxwIuUp0rBR/thYHQ7gjF/0vnVeUGrRvcsjwCJ+A+q8ldTQIe6CuCiEBS2C8WO8WW14ZABzK6h1Zj1qMG3zpJuYraDHZxkVZeRU18AOKbeA5ysZ1M8woBLkBkvaHE8GN8mjwI4//O0 +Zu5JDme XQYlDDDSJSo2l8srU9X816PHn1uhiCaXFTWbAz9dZPSx6YVM2n6KuMLH0u9tO8sIkRlZ44u/F/m4TDtURPXENE/9i98oojingq+tqAWvxviXq5DFsAtbQhr3ykA1xWhsEUYMuqanAIeXOzyH8+gcTyVTrl72adM+cvkQKOVbs/wIJIubL6aVqHnbi6dPz7d+dy4FVMAsBa/cLdRKUEziIIaJo3aINjNfEaGFmja8XByO7Ui/gWFygxQrk9RWHvwV7r5sbqXWoldU4bqJjJ7ZEHQcQKQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/1 5:20, Matthew Wilcox (Oracle) wrote: > Saves dozens of calls to compound_head(). > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/memory-failure.c | 40 +++++++++++++++++++++------------------- > 1 file changed, 21 insertions(+), 19 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index fe4959e994d0..74e87a0a792c 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2189,7 +2189,7 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags, > int memory_failure(unsigned long pfn, int flags) > { > struct page *p; > - struct page *hpage; > + struct folio *folio; > struct dev_pagemap *pgmap; > int res = 0; > unsigned long page_flags; > @@ -2277,8 +2277,8 @@ int memory_failure(unsigned long pfn, int flags) > } > } > > - hpage = compound_head(p); > - if (PageTransHuge(hpage)) { > + folio = page_folio(p); > + if (folio_test_large(folio)) { > /* > * The flag must be set after the refcount is bumped > * otherwise it may race with THP split. > @@ -2292,12 +2292,13 @@ int memory_failure(unsigned long pfn, int flags) > * or unhandlable page. The refcount is bumped iff the > * page is a valid handlable page. > */ > - SetPageHasHWPoisoned(hpage); > + folio_set_has_hwpoisoned(folio); > if (try_to_split_thp_page(p) < 0) { > res = action_result(pfn, MF_MSG_UNSPLIT_THP, MF_IGNORED); > goto unlock_mutex; > } > VM_BUG_ON_PAGE(!page_count(p), p); > + folio = page_folio(p); > } > > /* > @@ -2308,9 +2309,9 @@ int memory_failure(unsigned long pfn, int flags) > * The check (unnecessarily) ignores LRU pages being isolated and > * walked by the page reclaim code, however that's not a big loss. > */ > - shake_page(p); > + shake_folio(folio); > > - lock_page(p); > + folio_lock(folio); > > /* > * We're only intended to deal with the non-Compound page here. > @@ -2318,11 +2319,11 @@ int memory_failure(unsigned long pfn, int flags) > * race window. If this happens, we could try again to hopefully > * handle the page next round. > */ > - if (PageCompound(p)) { > + if (folio_test_large(folio)) { folio_test_large() only checks whether PG_head is set but PageCompound() also checks PageTail(). So folio_test_large() and PageCompound() are not equivalent? Thanks.