From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60B43C4332F for ; Mon, 11 Oct 2021 05:53:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CCAF960EE7 for ; Mon, 11 Oct 2021 05:53:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CCAF960EE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 44AFC900002; Mon, 11 Oct 2021 01:53:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FB1D6B0071; Mon, 11 Oct 2021 01:53:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C2AE900002; Mon, 11 Oct 2021 01:53:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 1A3216B006C for ; Mon, 11 Oct 2021 01:53:52 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 960011802F4BF for ; Mon, 11 Oct 2021 05:53:51 +0000 (UTC) X-FDA: 78683090262.01.BE6A862 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf25.hostedemail.com (Postfix) with ESMTP id 886EDB002EC4 for ; Mon, 11 Oct 2021 05:53:50 +0000 (UTC) Received: by mail-pj1-f47.google.com with SMTP id ls18so12423828pjb.3 for ; Sun, 10 Oct 2021 22:53:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lIJ+XUhJ1TElhpQKwEpT4S7aJfZEXFOVkhMK+5OK5f0=; b=6miTw5RyDiGgFTqcgZc9O/crZqOnsIBUmL1Z3jTD0pryaBSQwoLKTNuZNK8vNMwTZV AcmpU2OhCwW9KiHPVdfN0ksHb0n5xruvtUsySXK4cCACzKaYH2fCSf+lIXpfdyDCcRzL fEZTNtkjdjJBaJ1kCWreLLx6SrBXtrmz56Mdwg4QbzTJ9eR9aU5Bd0RU9HMAw1hh4i2n UhTzCfYiqYL98qu7Z3IIp6dVR3px5z3B90zV0ZCevpDCvSWLRPttuyWSpixxeWzsmL5e caXg+VZwi03RfGI5Y5Zob9gDx+imPPNrOhj1yNEPy/EfwNzuVQ9WTylL9cALjeRQTZXn AHMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lIJ+XUhJ1TElhpQKwEpT4S7aJfZEXFOVkhMK+5OK5f0=; b=AemsBja8BefMGikPrO67oqepE3f9DBkHb5Ttu5KsvBZIDXf+crY/+irhp0Ca4IQtEp FhxbMqeHMXPKGR6UPC1A9JtxIURIeXD7oUFAfBp4/wlsQr+8jw0opwDPk5oDj5NikwHm DOdSU3wHdpkiDcdvqb9r5I/5tU1WJG//u/81jbHc1oPvKEsb/zNyk/I0AJ3Vt86Sv47h SSbgka1k/WNWBUm1fcwxegGJrgX9aGcvGIW1z9tEY+5tdQVN2HZPwonU+/zkALoDI7b9 vu2EqGNDyhaEDKfw/aifK+N4svsIePQx0bkL2sUYtzmGTm59ZCXZhDGz6dwfVwqpdzCV vAOA== X-Gm-Message-State: AOAM532sPEIFZMigLLkOh/RJ/ErgagCCDiLsnSUQBh/NvxFhXvkmObXu ByLpvg9voQpAQQoDhMy7YjFk5GAD9Hipmg== X-Google-Smtp-Source: ABdhPJyjZhIpdAYislrqj9WHCdSxqDDq0v/MEp12Ve3Sq2oDChg3vlUpJ7wmnE4v/TtrnmZjlv5NFQ== X-Received: by 2002:a17:90a:4681:: with SMTP id z1mr28842601pjf.113.1633931628873; Sun, 10 Oct 2021 22:53:48 -0700 (PDT) Received: from [10.254.148.242] ([139.177.225.246]) by smtp.gmail.com with ESMTPSA id l14sm1180705pgt.17.2021.10.10.22.53.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Oct 2021 22:53:47 -0700 (PDT) Subject: Re: [PATCH v3] mm: mmap_lock: remove "\n" in TP_printk and use DECLARE_EVENT_CLASS To: rostedt@goodmis.org Cc: mingo@redhat.com, akpm@linux-foundation.org, vbabka@suse.cz, axelrasmussen@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20211011021124.86248-1-ligang.bdlg@bytedance.com> From: Gang Li Message-ID: Date: Mon, 11 Oct 2021 13:53:43 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211011021124.86248-1-ligang.bdlg@bytedance.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 886EDB002EC4 X-Stat-Signature: o6ubkf7ndmnnka3uhs7a8qpshjyj9mjr Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=6miTw5Ry; spf=pass (imf25.hostedemail.com: domain of ligang.bdlg@bytedance.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=ligang.bdlg@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-HE-Tag: 1633931630-266311 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/11/21 10:59 AM, Steven Rostedt wrote: > Why did you send this? It should be two patches, not one. The rule is, > every commit does one thing. Now you made this patch do two. > > Andrew already pulled in the other two patches. I don't think this one > is appropriate, and should be discarded. > > -- Steve My fault. Obviously you are talking about events, not patches. I misunderstood your previous email. > Thanks for doing this. Looking at the events, they can certainly be > merged into one. This patch v3 should be discarded.