From: Gang Li <ligang.bdlg@bytedance.com>
To: rostedt@goodmis.org
Cc: mingo@redhat.com, akpm@linux-foundation.org, vbabka@suse.cz,
axelrasmussen@google.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v3] mm: mmap_lock: remove "\n" in TP_printk and use DECLARE_EVENT_CLASS
Date: Mon, 11 Oct 2021 13:53:43 +0800 [thread overview]
Message-ID: <ee3540d5-6790-7cdd-b8a6-3a478e4184f0@bytedance.com> (raw)
In-Reply-To: <20211011021124.86248-1-ligang.bdlg@bytedance.com>
On 10/11/21 10:59 AM, Steven Rostedt wrote:
> Why did you send this? It should be two patches, not one. The rule is,
> every commit does one thing. Now you made this patch do two.
>
> Andrew already pulled in the other two patches. I don't think this one
> is appropriate, and should be discarded.
>
> -- Steve
My fault. Obviously you are talking about events, not patches. I
misunderstood your previous email.
> Thanks for doing this. Looking at the events, they can certainly be
> merged into one.
This patch v3 should be discarded.
prev parent reply other threads:[~2021-10-11 5:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 2:11 Gang Li
2021-10-11 2:59 ` Steven Rostedt
2021-10-11 5:53 ` Gang Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee3540d5-6790-7cdd-b8a6-3a478e4184f0@bytedance.com \
--to=ligang.bdlg@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox