From: Vlastimil Babka <vbabka@suse.cz>
To: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>,
Michal Hocko <mhocko@kernel.org>
Cc: Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: kernel BUG at mm/swap_state.c:170!
Date: Mon, 17 Jun 2019 14:17:24 +0200 [thread overview]
Message-ID: <ee245af2-a0ae-5c13-6f1f-2418f43d1812@suse.cz> (raw)
In-Reply-To: <CABXGCsMjDn0VT0DmP6qeuiytce9cNBx8PywpqejiFNVhwd0UGg@mail.gmail.com>
On 6/16/19 12:12 PM, Mikhail Gavrilov wrote:
> Hi,
> I finished today bisecting kernel.
> And first bad commit for me was cd736d8b67fb22a85a68c1ee8020eb0d660615ec
That's commit "tcp: fix retrans timestamp on passive Fast Open" which is
almost certainly not the culprit.
> Can you look into this?
>
>
> $ git bisect log
> git bisect start
> # good: [a188339ca5a396acc588e5851ed7e19f66b0ebd9] Linux 5.2-rc1
> git bisect good a188339ca5a396acc588e5851ed7e19f66b0ebd9
> # good: [a188339ca5a396acc588e5851ed7e19f66b0ebd9] Linux 5.2-rc1
> git bisect good a188339ca5a396acc588e5851ed7e19f66b0ebd9
You told bisect that 5.2-rc1 is good, but it probably isn't.
What you probably need to do is:
git bisect good v5.1
git bisect bad v5.2-rc2
The presence of the other ext4 bug complicates the bisect, however.
According to tytso in the thread you linked, it should be fixed by
commit 0a944e8a6c66, while the bug was introduced by commit
345c0dbf3a30. So in each step of bisect, before building the kernel, you
should cherry-pick the fix if the bug is there:
git merge-base --is-ancestor 345c0dbf3a30 HEAD && git cherry-pick 0a944e8a6c66
Also in case you see a completely different problem in some bisect step, try
'git bisect skip' instead of guessing if it's good or bad.
Hopefully that will lead to a better result.
next prev parent reply other threads:[~2019-06-17 12:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 4:05 Mikhail Gavrilov
2019-05-29 17:32 ` Mikhail Gavrilov
2019-05-29 18:09 ` Michal Hocko
2019-05-29 19:28 ` Mikhail Gavrilov
2019-06-05 20:07 ` Mikhail Gavrilov
2019-06-11 3:59 ` Mikhail Gavrilov
2019-06-16 10:12 ` Mikhail Gavrilov
2019-06-17 12:17 ` Vlastimil Babka [this message]
2019-06-17 20:09 ` Mikhail Gavrilov
2019-06-30 21:15 ` Mikhail Gavrilov
2019-07-05 15:19 ` Mikhail Gavrilov
2019-07-05 23:03 ` Jan Kara
2019-07-06 2:39 ` Linus Torvalds
2019-06-17 12:47 ` Vlastimil Babka
2019-07-22 1:37 ` huang ying
2019-07-22 7:31 ` Mikhail Gavrilov
2019-07-22 7:52 ` Huang, Ying
2019-07-22 7:56 ` Mikhail Gavrilov
2019-07-23 5:08 ` Huang, Ying
2019-07-25 6:17 ` Mikhail Gavrilov
2019-07-25 7:14 ` Huang, Ying
2019-07-25 11:44 ` Matthew Wilcox
2019-07-26 3:20 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee245af2-a0ae-5c13-6f1f-2418f43d1812@suse.cz \
--to=vbabka@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mikhail.v.gavrilov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox