From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B57BBCF9C6D for ; Sun, 22 Sep 2024 22:31:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9600E6B0082; Sun, 22 Sep 2024 18:31:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90FF96B0083; Sun, 22 Sep 2024 18:31:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7AFA16B0085; Sun, 22 Sep 2024 18:31:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5C1DA6B0082 for ; Sun, 22 Sep 2024 18:31:45 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A97F1C0FE7 for ; Sun, 22 Sep 2024 22:31:44 +0000 (UTC) X-FDA: 82593822528.20.B3EF503 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf04.hostedemail.com (Postfix) with ESMTP id BF24940004 for ; Sun, 22 Sep 2024 22:31:42 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Lo0FfJn6; dmarc=none; spf=pass (imf04.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727044289; a=rsa-sha256; cv=none; b=g/QDx00RTMiLzKskcP1IkoIV9gzDunUZwe1LkWCFLn6V/6W33CJHblAgkTt0zB5tfu+QCm rJDCVy/QAwATRb8a3yEnDzyN/zfLbryYNoorBK+8j31XMlCKFhpucknIzZL8revBFr8wKf eTO5z2S1EqfPSqESX6x4Tvx8oyUwfpU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Lo0FfJn6; dmarc=none; spf=pass (imf04.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727044289; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iosSBOxdVVQ4mK6DB/zc+u9Plvd1a40t5nm6TmD7C8w=; b=wGHI1QzQ8Y1Pvev7txWTPaYHY4B2M6IRmvaaDgdl5ZKiBwQ0ygmvs5/IdVX1Ot7aoUErRz pzuydJEt2c3t5vw/cv5mOdVrP78fTWMOC67lQclXLA/KTOT+8BJFAesM2zN62PI0h+8l2N e01lSWvBXLskd991xhOPrCEeeoylTzo= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2053a0bd0a6so36631035ad.3 for ; Sun, 22 Sep 2024 15:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727044301; x=1727649101; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=iosSBOxdVVQ4mK6DB/zc+u9Plvd1a40t5nm6TmD7C8w=; b=Lo0FfJn6WfK183hRDKPlIjMsv7suWYXQdHePe5QyHviwYHkZK9ADWyR1WJgk4uxwFa aV2gxjN9cyx1k0nK5jNQAiuzzjvNE/cdVVTRMmijdpkUye7JybLKFrY0EAhOGkMxE7oH JKLuiDn1EGhahhhqOq+nSXD349RSL3SA5MUPAhIWTdx80QVHRu4u3SjhKBw3jzDoNrzV ahZbZjvpsjCbSFwDmAD5htsv+NziAEXdBAPS7yXevhouNKRKxzlVrnocEWojfJk6PDP4 kLrNq5O1efmlnXmm/LHAhNTG54mrESOC5ytApQ1JVRHFQX5HmoltJhtkOOdnCJ44ed47 sJvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727044301; x=1727649101; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iosSBOxdVVQ4mK6DB/zc+u9Plvd1a40t5nm6TmD7C8w=; b=WlF9wGg2sTg/0VqGDeY4QX8u1QYZlFaCTRIoUVI/42a6xPWi/b2LtsFH78JUw7lJLU KnpHcWDUsW3X8TY7gAbFSOlTTSoR11DFnmw1B8EtFGn/js5DfM22LBEwxPDk+Q+GG9or XoF0UFikl/vHWGR9r4QzW7TQFw8h+X9VIW/t1Sgzs8G5quIHzNbMi9f/o4xC8BK53puy +JRimmOeejVDyuQ9we2Hp/TXdzRLfNnv07JIETfJVZ60tJ2bU9aD9tJAxEeyQKKfLT/O UnUhutSWelgyFmEitkSeiL94reuJ4+Q0IEFha6BtANXcmzp1MCo3vaDOgO8HceDwhFp6 Ap2A== X-Forwarded-Encrypted: i=1; AJvYcCWDaQ42AWsqjecsabkeH2h3Bj9FKN7M1yWlmSpE+sQyqPZST5ADJNkHtyDSbwBxnOHhW1qX8QIJqQ==@kvack.org X-Gm-Message-State: AOJu0YxZqHYz+E0Wz91//Jz/PcPKlO2PPAAHSr3Yt24Gs0YACMXFJg9H HO04PoBe58BLvcB8DjuHYAZJlq4JsLdaVZAatyQV+jll0Cd6PkMP X-Google-Smtp-Source: AGHT+IH6y3pmDxDlvdRxDXRbteGA5cKCIeqeUHlworuXmyj3UJaAJfjTnnzkGbIT5+sFvcoYWePXZg== X-Received: by 2002:a17:902:e844:b0:205:7574:3b79 with SMTP id d9443c01a7336-208d838449emr159710575ad.25.1727044301336; Sun, 22 Sep 2024 15:31:41 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20794601017sm123102435ad.85.2024.09.22.15.31.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Sep 2024 15:31:40 -0700 (PDT) Date: Sun, 22 Sep 2024 15:31:38 -0700 From: Guenter Roeck To: Thomas Gleixner Cc: Alistair Popple , x86@kernel.org, Dan Williams , dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, max8rr8@gmail.com, linux-kernel@vger.kernel.org, jhubbard@nvidia.com, Kees Cook , Andrew Morton , David Hildenbrand , Oscar Salvador , linux-mm@kvack.org Subject: Re: x86/kaslr: Expose and use the end of the physical memory address space Message-ID: References: <87seve4e37.fsf@nvdebian.thelocal> <66b59314b3d4_c1448294d3@dwillia2-xfh.jf.intel.com.notmuch> <87zfpks23v.ffs@tglx> <87o75y428z.fsf@nvdebian.thelocal> <87ikw6rrau.ffs@tglx> <87frr9swmw.ffs@tglx> <87bk1x42vk.fsf@nvdebian.thelocal> <87sev8rfyx.ffs@tglx> <87le10p3ak.ffs@tglx> <87ed6soy3z.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ed6soy3z.ffs@tglx> X-Rspam-User: X-Stat-Signature: 66pddca5oroboxpisw78s31xb4j1f7yu X-Rspamd-Queue-Id: BF24940004 X-Rspamd-Server: rspam02 X-HE-Tag: 1727044302-517020 X-HE-Meta: U2FsdGVkX18sR+mKsiS+W+suIQx5+cz/ry/juYnIZEaaV5wBMQQcn6e+IcMSGjfGj5dgtR5eF6yyJyTr/m02QoJpFyqrvahUGEnrywxhmmGccHBBIt6ItZYxj579taiPeVjmzHgerrM7B0REaDUTGKaZJcJGN+NZVqjI3C2e6CuSukva/AsTOtJUUvTq0iUM6ce+z/cupBGgcPJzzmixtRBPUjJrfyWyzg8f1afp3TkRiHcFLwJSSe5fyhKVx2p0uiq8rGjnSMsRe3sJurcFewp/oiUpB/sCoSF+B5rcd5lYV2u4sRLB2t+XrSjJE1cl58nZXMPFjjeHfkl+AkUUOunf2sN7RR5oZ1TuGKT7LjaC57IcK59Hq2ZfM4A+CsyyVIc5FaAHN28HFbAABSnJAadSrRENlrenfvuwiuVSW6I/blFr6oEOtpQvm5EYb33l4JZFPWXj2lkw+74r5e3+RUgm8bpyADlcdHJJ02yRr/hicRIUyuIcg2pph2QmwcK3la2SL4SX00O+JiG1RdNWsea10KidvfzSrq8SQsMR2g9G52rBnuOGTc6Rl9N3GYzAqMldruF/eWETKPB782R5hZZ05eQ5IJpVssTnyHX77z6m7I7a1u8WEU1SJ0uZGDX6poARNvPEBTrOCYRBSi2NPRPqLxK5X165C/8xt5XSmziv4y1dE3RB91hK0xaN6CYna3rRxfbhihVDQ81fw1AIYZdAuveuLkQkJEa/3Rce++mUsInmjIiqeNTyueKQpy9p06S73htXrTMo/8WklDIswcGD6varGF66C8FD9+fJhV3TWirINdmD3CepCroxtlX2xxj2N2u12nvw6f6YU2j5xhaeEZkmcv+TEuI0Gk6Z9Ipwky1ThZ21r9OM1h5F+tKpC0DZe7J0vXX+4qdQLTG8NhVOuUvoPcvmbnYLZEbo4FYu7O2J80+hWfm7jlPnPEJMCezguaoYNQno0uHLnqg eVV6WP1d Gmc8ACkIseHUTmCtP+LlmKoEzo8pszg6qiBRyFh0UnG6PVme1bT5kcLWVAq3IaX8S87N6TlCkjPXkNufxF4Vmu1Kz2mANMvVBxH2u7g1iTFIvBLJjnjQhNfGg5GdJ9FmZty6DJ6jwmRL9SWvAU618VjvpJQkK2DewxHU+kBXYduXtH5KzLnGa8LcFandgCveSS1OSlhLskn7BKHFlaIST9Q17Pn5LX61yEhgMadIIsLWFwWZ1JzL9GPgMhrT/lpbjEgj1bhzdpaL7Rtb+uJLvkM57UMniYPxAf2afqCTSiRs2qqfefokSycHTex+bybVJYSn3wC1XhatnmmUynVWPmPU/m1tXMEFIU7Dimp1A75CXCYLUB6OwvBV9A9D1Qu9aYO+u+KeSiAvFHWBn0GHsujD2vWquTniqpaxgDSj4Fz8NtLCn8SOdmS8PRXj3wyA5wypQfen5r4agVEmOpVCF8H9iWnqMMKQkgSCBah98flws78KWCk8qXEEWmfamLzhle3+2yZEj4eVd//ge3bNGpjf2Dq8aJqN5PD3S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 12:29:36AM +0200, Thomas Gleixner wrote: > iounmap() on x86 occasionally fails to unmap because the provided valid > ioremap address is not below high_memory. It turned out that this > happens due to KASLR. > [ ... ] > > --- a/kernel/resource.c > +++ b/kernel/resource.c > @@ -1826,8 +1826,7 @@ static resource_size_t gfr_start(struct > if (flags & GFR_DESCENDING) { > resource_size_t end; > > - end = min_t(resource_size_t, base->end, > - (1ULL << MAX_PHYSMEM_BITS) - 1); > + end = min_t(resource_size_t, base->end, PHYSMEM_END); > return end - size + 1; > } When trying to build arm:allmodconfig or mips:allmodconfig (and probably others): Building arm:allmodconfig ... failed -------------- Error log: In file included from include/linux/ioport.h:15, from kernel/resource.c:15: kernel/resource.c: In function 'gfr_start': include/linux/minmax.h:93:37: error: conversion from 'long long unsigned int' to 'resource_size_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Werror=overflow] 93 | ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); }) | ^ include/linux/minmax.h:96:9: note: in expansion of macro '__cmp_once_unique' 96 | __cmp_once_unique(op, type, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_)) | ^~~~~~~~~~~~~~~~~ include/linux/minmax.h:213:27: note: in expansion of macro '__cmp_once' 213 | #define min_t(type, x, y) __cmp_once(min, type, x, y) | ^~~~~~~~~~ kernel/resource.c:1874:23: note: in expansion of macro 'min_t' 1874 | end = min_t(resource_size_t, base->end, PHYSMEM_END); | ^~~~~ kernel/resource.c: In function 'gfr_continue': include/linux/minmax.h:93:37: error: conversion from 'long long unsigned int' to 'resource_size_t' {aka 'unsigned int'} changes value from '18446744073709551615' to '4294967295' [-Werror=overflow] 93 | ({ type ux = (x); type uy = (y); __cmp(op, ux, uy); }) | ^ include/linux/minmax.h:96:9: note: in expansion of macro '__cmp_once_unique' 96 | __cmp_once_unique(op, type, x, y, __UNIQUE_ID(x_), __UNIQUE_ID(y_)) | ^~~~~~~~~~~~~~~~~ include/linux/minmax.h:213:27: note: in expansion of macro '__cmp_once' 213 | #define min_t(type, x, y) __cmp_once(min, type, x, y) | ^~~~~~~~~~ kernel/resource.c:1891:24: note: in expansion of macro 'min_t' 1891 | addr <= min_t(resource_size_t, base->end, PHYSMEM_END); | ^~~~~ Guenter