From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35E74C05023 for ; Mon, 15 Apr 2024 15:01:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F15A6B0088; Mon, 15 Apr 2024 11:01:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 979C56B0089; Mon, 15 Apr 2024 11:01:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CD0B6B008A; Mon, 15 Apr 2024 11:01:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5BB526B0088 for ; Mon, 15 Apr 2024 11:01:58 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E43021A06BC for ; Mon, 15 Apr 2024 15:01:57 +0000 (UTC) X-FDA: 82012081074.06.14DF49C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 8021D1A0029 for ; Mon, 15 Apr 2024 15:01:55 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="YQdhbD/t"; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713193315; a=rsa-sha256; cv=none; b=iTFSMd2lSlcLZnUaiKhj7RPNjC1QweJasJ9XOFjV3AamR802swAOIHYCRD+J/EM+W/EOU6 eBiDeS7shKoJ/URhlWos1ruRmeG6KWus2sGkzN9sBM19V8MI6tTfJkerJSTgB42fdZ9KNf PN0yCq+g0cSfkk4CMqe9rdA/6+K2UOA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="YQdhbD/t"; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713193315; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zwjBbQo6C7j6xP7+cDacBB/+QuPqifcUdRYibqKmYA0=; b=QSWFRwl7bzGacM6b26CHSI30wjJ7fuGRN7hj3nliFt1ElbjSDmVpqejJ4+oTC+RUVYNphX VzPpLmjmsNeaennKDwkUhegf2pf3e9G5RkQ8BX1cz/JDH86XfzoDV7I5apQNimI+llEYFD WvUQ/T2Tnzs08s5G7UAr/9fqCJv4c4o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713193314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zwjBbQo6C7j6xP7+cDacBB/+QuPqifcUdRYibqKmYA0=; b=YQdhbD/tZ81WW++r0UKV8VhExKoYPl3v75OiM5e40PYEhVponcapaZHEGyFgo3ro5VswbO AKx/O1bemHIGrTa2FBeEEq0JDmUgQZeAOCTTUO2Y5N6AXPONAx+6n0J1jPvI7drgIYfg2+ 9n+qQeqG6KA9cwlCYT+Dsnlq9JpkyRA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-454-zAjWXOe9OlutLpvF9vuiAQ-1; Mon, 15 Apr 2024 11:01:53 -0400 X-MC-Unique: zAjWXOe9OlutLpvF9vuiAQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-343bc1e4ecdso1059083f8f.3 for ; Mon, 15 Apr 2024 08:01:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713193312; x=1713798112; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zwjBbQo6C7j6xP7+cDacBB/+QuPqifcUdRYibqKmYA0=; b=D9RiBY5pS201gKsG+QL6hk5N3x/rcSOzn7BR4zInfTWAbyN+eVg1IqzrOvgnAkACBZ 58EILx1gZUn0NuNdm+Fdu52ry3kVh1zNjoyDXcveXjvIkeSsw0RTiaggGXbcR28Vudi7 U1q9N+tt+Ol1RN9viflkYIcJctwIGn/S3us9/+noLXeRXBexPMb7BQcAG1qOI1TxBFlS ejrn+ME8ObgtLPtqgorVs8qR48rfZrdXfCVxzzUaNIgbtsCmbF3oQhMnkv6ILEOED5sc +nXTNTgsbPIFIS7DIfaTkpYOV3D5XjmW16d+a9qHROBR98Qi/Vj9+I74KEdPNKj8LS6j /BOA== X-Forwarded-Encrypted: i=1; AJvYcCXcr9U5ZcSEgMA/J1dRq1QN3cDC4oQmq3D5trkh5pxeeLmey2ETgpO+Fhj7O0ZCvUcphAR4DVQbjkB8tKuOm1n3A1w= X-Gm-Message-State: AOJu0YwjXpxUhLTcFHhqrGAEoiK538PaUEKGuGyWkP7VxL1IIa0vcSXB +eKAc09DTpKojrw15WcE6gCTB/kWFxQ40S74P6lZV/435Fi09B3DgK4YYV4TJJhFiJhrYj1o5Cc zf59FjfoILrIKP1zG7JBJYQgEjRAeEh+W3qvwLsT5o7V70FJ/ X-Received: by 2002:a5d:6749:0:b0:346:bb52:25a1 with SMTP id l9-20020a5d6749000000b00346bb5225a1mr7167268wrw.33.1713193311924; Mon, 15 Apr 2024 08:01:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IESay4aKO0ZgPPO7ryxLsiEvDZn+lExNAZU8G+nuJuuajPSqAAIfF3Ob1/AhUDMhrDyLw/M9A== X-Received: by 2002:a5d:6749:0:b0:346:bb52:25a1 with SMTP id l9-20020a5d6749000000b00346bb5225a1mr7167243wrw.33.1713193311544; Mon, 15 Apr 2024 08:01:51 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:d800:568a:6ea7:5272:797c? (p200300cbc706d800568a6ea75272797c.dip0.t-ipconnect.de. [2003:cb:c706:d800:568a:6ea7:5272:797c]) by smtp.gmail.com with ESMTPSA id b13-20020a5d4d8d000000b003432d61d6b7sm12232617wru.51.2024.04.15.08.01.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Apr 2024 08:01:51 -0700 (PDT) Message-ID: Date: Mon, 15 Apr 2024 17:01:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 0/3] Improve memory statistics for virtio balloon To: zhenwei pi , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux.dev Cc: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, akpm@linux-foundation.org References: <20240415084113.1203428-1-pizhenwei@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240415084113.1203428-1-pizhenwei@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8021D1A0029 X-Stat-Signature: 493ynpi4bkbixuwm81pry6aic1oc7wh9 X-Rspam-User: X-HE-Tag: 1713193315-463090 X-HE-Meta: U2FsdGVkX19FaicF9V0/EJgMNXR2je+sLJut4JfI4EC07QTEliyydwgvAGUoLivhaJsDdZLuUduFZ/ffSXr9PjQvCaY55z8IdRSDLpB7S/4Vvud9Xg1iUMZqHsEOGseYTYmQ9CyDex0qipzsbn2VZ/TytcchE/gnvB5fLQaHTUi4hDjGp0I/oKpair4oig2HVjwzPnAoQYXw4ZRcz/u/qJOCgtxf7LCVHwaTXqCFivx6fPZCXciJVvNNc5RiVonWSnuPWAy/lF7VMYxErbauqmn22cefCPrq6l5Ki0PLXYEB4tf35OcaCHtk+d5j4VVI8bPGSOQDPDOpsF1wgQv7+7VNihm5Ca8RV7Hkb3JpKOgmYqNoo8KEjj+uVZMyxMkRzU7WwfooR6iWdNa0Nb9mzeHdZY0Nr8tBXeUvC3t5hjyKSfeRLA4vFutM+XgoiNXLqR/qBXnu1Eu+RZenpAO4WefOZmr2GXX34ZGOe0ZoxaEeYep55pbMxiWOLYKU6zVoxiVaaVq9V4FrIN/WWInKw2+fzuF/sWxUFJjiWhyOsdaA1TJHw5f3Ci6E/GRU3FsVLCcWJyYDYjV1DzDPLm9gY6lt8fhXEs3UyuFLI5IbDPtAJVz+u3wHgNQsENUXScF3fmoESAhp953fi0lnEqt3b+lqqhBFJbI/8mSlp6FsHXP/jCaln2oAX7TjC/D/ukQfFCtSmlyB3LeEW86e9X1VAvcq4OYszPxIRsiLjLwejJoCg0FmGdqZm2nnIhT9VnHX6DBPxcRmsZ3Eh9CoaHxSaM1avnZGh2ECMX4c76OgjvU1KIRJbaTl6QYDKfrMB/inO/snWqKjn6Omevmyma4RPpoyc325HtiEtGGdj+7Z8Bxxr7TDLpG5fMSouWjGxUnESonccluFqBeGpe5oQOhB5X35C3reo7tChB/BuouIFKgeZcU3iv1A4XcwcVf3zMvKIeWf2jbC+gy1pC5/5Ih QcLObPa2 MjHShE4Ck6bUl1wFa1owjRZcxnUXLGBPR98eKsY2T39KcNG3Hs1GSlmr+wRUodeNDXgtB8L6dH58/2h1Ncy7rfoi2GP1Gqm3pxHC1ykhnjP39641QfiuYAJki8KlTC1Y6jMe9dZ2ywiMPTgyxWi88nnvCUpi31pdznqCaX1Y691LLtJZBg1ESnyxz1gMW/0qtPvw41CnexYSlpN6yx6QeXAJ4APXwWfP2RDqw2AVxSmjmtKtLUteaBY7tazVq9qic1hmN1UJpJJ4TDhgwLuRFc6EqlXIonzKuGVDeL+KQ+9Gx+GKmiQJFQNxy4hWn4UXdI/RFP4saEEdpBq9oW64sqA8QrmifTqO2Obmo1pzxE4FReHGAw1Q+74AsXhnazvYZBeNscvedQ4ShC5O4oYYRLgswJYGOj0gSVNPv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.04.24 10:41, zhenwei pi wrote: > Hi, > > When the guest runs under critial memory pressure, the guest becomss > too slow, even sshd turns D state(uninterruptible) on memory > allocation. We can't login this VM to do any work on trouble shooting. > > Guest kernel log via virtual TTY(on host side) only provides a few > necessary log after OOM. More detail memory statistics are required, > then we can know explicit memory events and estimate the pressure. > > I'm going to introduce several VM counters for virtio balloon: > - oom-kill > - alloc-stall > - scan-async > - scan-direct > - reclaim-async > - reclaim-direct IIUC, we're only exposing events that are already getting provided via all_vm_events(), correct? In that case, I don't really see a major issue. Some considerations: (1) These new events are fairly Linux specific. PSWPIN and friends are fairly generic, but HGTLB is also already fairly Linux specific already. OOM-kills don't really exist on Windows, for example. We'll have to be careful of properly describing what the semantics are. (2) How should we handle if Linux ever stops supporting a certain event (e.g., major reclaim rework). I assume, simply return nothing like we currently would for VIRTIO_BALLOON_S_HTLB_PGALLOC without CONFIG_HUGETLB_PAGE. -- Cheers, David / dhildenb