From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B617C83F1A for ; Mon, 14 Jul 2025 14:18:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D44806B0098; Mon, 14 Jul 2025 10:18:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF5586B009F; Mon, 14 Jul 2025 10:18:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BBD516B00A2; Mon, 14 Jul 2025 10:18:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A78FF6B0098 for ; Mon, 14 Jul 2025 10:18:22 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2A45CB6EB7 for ; Mon, 14 Jul 2025 14:18:22 +0000 (UTC) X-FDA: 83663075244.13.D3E66E7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id C5866120007 for ; Mon, 14 Jul 2025 14:18:19 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DrSLAt8o; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752502699; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eAJ3iCVhDdz6z6h3YYRgguFqsc8zl+o4S274gAq3QzQ=; b=dhaJZaVASVZWbijadiA8WfxcMqlF9WAK1DO9vuhq2n+KN5XtkPEOVACQcLnGGhH001FJGu PHnZaBnLcphrDpLRvNo+yKo8sXIE+QfFLOTZsebd4PDXqlg/aPkq1vgm6LqHtZMp7gGvWg 6z+wHkX8jdi8gV6mtxFFSJccBOEvL/8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DrSLAt8o; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752502699; a=rsa-sha256; cv=none; b=nhUsizGeRtqx5nOilZ/YJ/QabgB7li+Vydehgx7ssTSznWWgYLPypEUO9c+QlqASqT+fRt j8gKFdGwd1NpwSbL27QIoBCtciWJeETQY3kN4JjfxwUUe0hO8Ra/WBP9LzM+1sFW3bx6Ri v8VaCQklAsW7CnBGyRD30HBvW/s7jtk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752502699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eAJ3iCVhDdz6z6h3YYRgguFqsc8zl+o4S274gAq3QzQ=; b=DrSLAt8odfUyitC9Ihjmm9Nf2beqQT8KPvqglg/m5Op6t0aYejHY5sXBEkq6jRtfqNBM3v 4t6nywHqmRDd9zFSyVqK3fQGEzlgYzkjqatekaHHglGnNpoTXica246QDU8TIHkdBcfKW0 +hfQmxN2K5OF03xmSSooCx1Gt45jDzw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-zz0IVEknPzyLUwVvtTEvCg-1; Mon, 14 Jul 2025 10:18:18 -0400 X-MC-Unique: zz0IVEknPzyLUwVvtTEvCg-1 X-Mimecast-MFC-AGG-ID: zz0IVEknPzyLUwVvtTEvCg_1752502697 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-451ac1b43c4so24135375e9.0 for ; Mon, 14 Jul 2025 07:18:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752502697; x=1753107497; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=eAJ3iCVhDdz6z6h3YYRgguFqsc8zl+o4S274gAq3QzQ=; b=f/ALZmBkJpcq5Rl9N0f+JCrEov7qKalwefA0WY1tr+G6GzkGQFv5KFJVA3wp5oZPLN eUMBEGDqtU//kV/nI3Q1ggAdr5UDws18vtjY0u75InOeq+0Ell6aOPPvBEIwdXal2Yy1 liv7bqNbfJbGTe5Aq2YpfFmwWgecM4EMqrHYcFpxAZ9FHV+X8eWVYJbOk9wP0edzRD4I OTSJqKRB3DncTCuaReizQA8H1SPztezPwCJ7L0tMhox9HYps9UMsz2Tk3qWgfoVw7i7j MRg0a/J6RfHzwvoJ//IgOZzHLWwo2cKFvUxIZg/HGgxMM94KqDZr21tj33s2/O3zaNB2 Df0Q== X-Forwarded-Encrypted: i=1; AJvYcCWy0mDJiQPRKUeRhtdRMR80vCpGXhV9HcPHLmXj22Q9RuidQ32dllDzX9MplwUBzHuGyeG/waExXA==@kvack.org X-Gm-Message-State: AOJu0YxrKE18BSX+IiyYx6oFMSFQTHyisJaHoU39QzP/u09NZ8GrNXpx N5lwt5DcVd0n88aecKG4eao1QyQ2s9f8eBzektts6n7vvgBQOubJql4ZH005Y4pqL5+31IyvIBf pmzlN60mcnmNOjJrGPNegqtUZ/Za4elZAsUYry4aHnJLmFDva569L X-Gm-Gg: ASbGnctuQB/ui3eFx3VJOpk6tRyDlTP6bnb6TYRsAlSo8rVrHpFZd22J7YIeQtEaKr4 6agXDZRfXZsFCCoCGet8JO8sVBBi9V7CI94yRolajOvHC5x/iOJCvHZdLzf4xTmMAULUuf8o9T9 T5QOdtwRWnFFdDz3jyn3z4eut6dns5dLnhAy/0qOaapCs/Wt/9tFn1MPEkz17wG4wpOLvpS3PxX ZdWKDeSZWPIF7f182vcDuqLvkj1UH+pz1mHpXuUBylyD67B7WUdO2FojsR+jyoFo0RmXsNURd1t Mwj47/DYFxgHRZ8NCGIyppM1JQL++dGcamqZXghPUtnT4VH3BXJQyF6B7aeDVTeWpg6xPKaKC0M vIqMlpZ6LdXX5jDN0DVA09E1QhtCYYtbo0Z1pvTA9HrTMEy4LfWX4UZTbk15xU7bk X-Received: by 2002:a05:600c:a08c:b0:456:22f0:d9ca with SMTP id 5b1f17b1804b1-45622f0de79mr13353575e9.26.1752502696737; Mon, 14 Jul 2025 07:18:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbT9ZPIoGGCqiO8MFBsH9vqN4nFX90UcX2di/BtWtN0bS6sk4srxVganZc03A1dsYc4N/AGw== X-Received: by 2002:a05:600c:a08c:b0:456:22f0:d9ca with SMTP id 5b1f17b1804b1-45622f0de79mr13353295e9.26.1752502696314; Mon, 14 Jul 2025 07:18:16 -0700 (PDT) Received: from ?IPV6:2003:d8:2f38:ca00:ca3a:83da:653e:234? (p200300d82f38ca00ca3a83da653e0234.dip0.t-ipconnect.de. [2003:d8:2f38:ca00:ca3a:83da:653e:234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-456114a417csm55711175e9.25.2025.07.14.07.18.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jul 2025 07:18:14 -0700 (PDT) Message-ID: Date: Mon, 14 Jul 2025 16:18:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vma: refactor vma_modify_flags_name() to vma_modify_name() To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250714135839.178032-1-lorenzo.stoakes@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250714135839.178032-1-lorenzo.stoakes@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: U5rtazQUGOZl_K6cTkuwLRmS1ryC0GsCCVeoKDTP4hk_1752502697 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: C5866120007 X-Rspamd-Server: rspam06 X-Stat-Signature: p78j9ajkq3p9cikj4pqqcyw1zspj4po1 X-HE-Tag: 1752502699-575235 X-HE-Meta: U2FsdGVkX19Ac2hQtyVIOU2GD1CflX7NFmA7h3g42j1pqa57NfxBhWeDwQ2beuMyJ0Zbf+aYOSOVuwKBl+9AHZYI8FQsumREbhXm3zZ1lVf5TDKYtyM3Sl0YT5dvIxrGWxdP/rY+Pe+xEVm0RmMaNemyvKhuOZlEJpObgeTPGSAb1354+r/9sH0i7p2T7WhVDDVRKmPqeCildnjiigGjxFOEGDa1Xf4nnihY9PFNFZXT9UUZAueECeFhNj+r8MApS2Ep0iZDTzXZm1WGxzgvn7xALgF5TsSbu5Aa0XxW5ClZKNXTTU0yKXaZYZvKvY4xR/UZJX9Hh86uVJ5yujzyhiLHkMlYYaUzNv7FH3RHszOwxBlxHfnqO6Zu4SgaKp6A8t6nBp4aOWMMjoiStzxIQotMzbf4WRrTv9nDB1oMcDVpAlisrX72GS3MEt67JvLmr2erGsZKV1Pel+KOYr0Uf5GfD75wsiOwNbSwPcXaz66yEYA92uGD05zxuzj9wp6JRAcMB3VZkyxeFcqEy2HM8rdNqaBew/dxKrCoHRmsNCqchOvM/eZvM7g4sjkYVZVMjLpOC5PuwvebBe0uaUuOAN6RovX1Ywst+RN8RgnoTOf0AJ+vQcp0WhzqUm3yyPyWf4IX26fCT5DRgVuuFMcfAxJiYQq1qv7FJH6HVnhiTCV9NbIF0vvnxJoipZ51EDvPH9uBhuGzQjXIcRyj5XSeyBoM3Qk9Kokoz6yGEw1lJ8qeFo38DGXoUdNiIpOgSkJl1rivjUbfp+NmOvfOklMbY4OQnnN1mwGKazg0dR3jJrwR4SbVcaoLwat77GeQzFdfoi0VW4FNcYX8YKvEXGq1kxJx45IeFXQt5OWLLMgi64VcjMaoBk+uT8AQt8KihVegDL/yV/NTvxtKT2l4tlckr0++dXm9ijjX2PTNikkjZdhgWShwRqY6bGMXbpBikCORjoj1g/tKFvi4he69pqx Gltk/ArD 7TfTukzWsPK1QT6NnluQAQM2rFWcTrnFGr/W+1r26HnzWBnMVgFzEI2evOAnJBck+9MEoAjW/ENwF6XJYZ09SQtlodhGLzy1no+//ol8x3ogjacyri2NY+Z5Q867CjH2F2A8SXsjaRgLRN1yPMFxja1ADACs7cQM2XDshDapYKnGAXX43g3TJmkpdn5T1g+Pk3Mdlqfs78zmIEY7jIvbyrrHjtqhZL8v1H5isqAygBIvJWvDvWUGigpHW169cZPzk0yop/pMn+JYsgJwHd/nINA5g28IIL07Y1KMfN3nLxzjHOnLwKyqvMWGAnArhkeH6CbAqSUqUT22XaF6vKAWW82X7Um8EPu72HCcNKtLGMAhZAWyWoiu3c9BxJhx55sCX43CktGpJCcWPmqVU0BBQ4LdzLrVX8GQ14PdfRVfwyOd7chkuF0RE1QxnfYrRJdzcn8e83ISLAqHqjY/NGZ3Or4Ym/18oKvYpSFYgUm0hJRBVO9e9Ux1Wl5d6VvkH6Y9x1tLvhMm2RVlxKX9hZHZxpmJW4OGyk5iMYiDmLkD84dUU/ANMrSZd/wwqFFZcfay0aPQw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.07.25 15:58, Lorenzo Stoakes wrote: > The single instance in which we use this function doesn't actually need to > change VMA flags, so remove this parameter and update the caller > accordingly. > > Signed-off-by: Lorenzo Stoakes > --- > mm/madvise.c | 4 ++-- > mm/vma.c | 4 +--- > mm/vma.h | 15 +++++++-------- > 3 files changed, 10 insertions(+), 13 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 9de9b7c797c6..afa9e4db2adb 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -162,8 +162,8 @@ static int madvise_update_vma(vm_flags_t new_flags, > return 0; > > if (set_new_anon_name) > - vma = vma_modify_flags_name(&vmi, madv_behavior->prev, vma, > - range->start, range->end, new_flags, anon_name); > + vma = vma_modify_name(&vmi, madv_behavior->prev, vma, > + range->start, range->end, anon_name); > else The doc of madvise_update_vma() is a bit misleading: "Update the vm_flags and/or anon_name" I assume it's xor? Do we want to sanity check that this will hold true? In general, LGTM. -- Cheers, David / dhildenb