From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C365C3DA7F for ; Thu, 15 Aug 2024 16:34:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04B1E6B016C; Thu, 15 Aug 2024 12:34:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3D206B016D; Thu, 15 Aug 2024 12:34:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB6276B016E; Thu, 15 Aug 2024 12:34:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BF8956B016C for ; Thu, 15 Aug 2024 12:34:09 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 35208141700 for ; Thu, 15 Aug 2024 16:34:01 +0000 (UTC) X-FDA: 82455026682.14.AA06179 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id CC66018001D for ; Thu, 15 Aug 2024 16:33:58 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W01Jn5sB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723739625; a=rsa-sha256; cv=none; b=lHwe+7lAFRIRQpNDvTlZTbAJrvJ2DoXrtQerUB8bJPXDKtFbmXlW3Ej1/7nuY3HTRdQsO8 hr1SbR7LOac8YpU75enGAfjlZZO4VG5fzs5q9r2OsTPDMMEncuJwyUXrqyuv4I+eyuN/wS wBfYgc1t/eNXfRF52p84kMHmp2FUA2k= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=W01Jn5sB; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723739625; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XmYDkvG//zntOyTnKna7R//x2Uja+cBArQdmeYe4uiM=; b=1K8N/45334YHrU0G5MYxMruX9PwPcAHXFZ1h7Br0ulEVnG5DBfyWTlooQQZEZEs6FOB7Dd pxsE+D3wEo9YPRVOeD4Jk+YXq0QqNRy+7JsW6wZ5HRVrnCkKelJAK2Z7lIEX+eO0KFU2Wm jlWEukBWcOYS7ZALLId+vKmP1LcQXcs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723739638; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XmYDkvG//zntOyTnKna7R//x2Uja+cBArQdmeYe4uiM=; b=W01Jn5sB+/eWmzyEncAOPtsBxji+qYVDM0Qki/WwE1TlMzAaqTwq9j3Y/BAdhANkXco3OQ Qlfz2rUBBeJmZ0qlKsOXVTyhIsFmNy8hmj87uALUiddhvbUzTErlNzJw/g4+5+pBu2q5yH itB5fp0TUK9bsGBoPi7Tam1hHfjPZWg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-RzNqzBCTP4mgQWCqyegcEA-1; Thu, 15 Aug 2024 12:33:53 -0400 X-MC-Unique: RzNqzBCTP4mgQWCqyegcEA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-36873a449dfso1270947f8f.0 for ; Thu, 15 Aug 2024 09:33:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723739633; x=1724344433; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=XmYDkvG//zntOyTnKna7R//x2Uja+cBArQdmeYe4uiM=; b=hm6SBwVwmAm2Ny6iWNjysPPnQPIxBHt+iO2AaOaHlsjMmkzwW/7QSDZW8BA9+aGK1q r1NeEqgYdN5NclKs2m0sCMQJoUpd4RsRRxAZcMP2NvAzR+Tj7mgiNySNXTSKGcfs8Pro FnRHSnVCHFRdVY5lzhPl8ja7Pw0ROR3qUe1b0V4dHwHybvMJNi/NDtvc08+XnLGLLYOP PC0VXe5b5ZzYfDBfo89M8ibg+jG0N6RVgdv1876zzHsp07LTVJYulmDI7D8jzgpIlfy0 QSViiId3I43HxEVjl3beIj8jPffsqTvljbtqV57yrJEWvwWXwVbaEqpZ1KQclCP1qQmB +cuA== X-Forwarded-Encrypted: i=1; AJvYcCUKrTqPMntZWq/PUimjBy8mSCMNFkS32ZAYDf9J63UxsO91AjFNJiWwQTv6jzUs65MXBSopb/95N+e65mCTtpDgJeI= X-Gm-Message-State: AOJu0YwdoH76TtzpH7I0HMbkBZmEH3vgtCKIbmUBjR+uzWiIzAwXXhnV 7iP3uKLRkn5HqC0SWpgFuLPBUmoU4GIt2bBhEToIDKCkdJ9p923RZQ2ZDfSohk/p11Ht0Wn+zua DLkJnFnYgZE6z4BF8FshQZSe/K3GSA+6hTxbiuWZ18De+85vN X-Received: by 2002:adf:f64f:0:b0:368:3562:7c76 with SMTP id ffacd0b85a97d-37186b8625bmr2602368f8f.3.1723739632703; Thu, 15 Aug 2024 09:33:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFt8iv0fpgohYyegONj9vovgeYN0JZYqYviF5kfSBjY/6Gtx9cGxaC54ARjSLhrzq/90x6UIA== X-Received: by 2002:adf:f64f:0:b0:368:3562:7c76 with SMTP id ffacd0b85a97d-37186b8625bmr2602336f8f.3.1723739632176; Thu, 15 Aug 2024 09:33:52 -0700 (PDT) Received: from ?IPV6:2003:cb:c717:6d00:aebb:127d:2c1a:7f3a? (p200300cbc7176d00aebb127d2c1a7f3a.dip0.t-ipconnect.de. [2003:cb:c717:6d00:aebb:127d:2c1a:7f3a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37189896df5sm1902097f8f.69.2024.08.15.09.33.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Aug 2024 09:33:51 -0700 (PDT) Message-ID: Date: Thu, 15 Aug 2024 18:33:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/6] mm: Introduce a pageflag for partially mapped folios To: Usama Arif , akpm@linux-foundation.org, linux-mm@kvack.org Cc: hannes@cmpxchg.org, riel@surriel.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, yuzhao@google.com, baohua@kernel.org, ryan.roberts@arm.com, rppt@kernel.org, willy@infradead.org, cerasuolodomenico@gmail.com, corbet@lwn.net, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@meta.com References: <20240813120328.1275952-1-usamaarif642@gmail.com> <20240813120328.1275952-5-usamaarif642@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240813120328.1275952-5-usamaarif642@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: CC66018001D X-Rspamd-Server: rspam01 X-Stat-Signature: ftnd7xpyfzdhuu4b1bk8j9od1fsp4jwr X-HE-Tag: 1723739638-616132 X-HE-Meta: U2FsdGVkX1/jf3VLxmZcGKac4AVcR8d0o1A68SELO9zvdBpdf57/AiZC2cuqwrcCCROmPoUOaPYZpmZhlzbIut/twd3XtRuzKk+Be9xfbPf3Edu18HfuMp1LWKD+dBE759QNU9BZqpYdVHQAJDxjxdkstYBmnJy73QvoarSgGL/LElvuIU+h9xr8yFIfzYPLmo3yqAVYdv/WxCpZjThecNNOPbMIW8ouM1eqaa2ZTJ+R/Nxn4mVPG5S9jEJipVeYYVrUXlYLUhldr77tO0M4guMOlcoKpUjMd8h+PvVBWl8t95kDVAzJovYBJe/CJXHAJ7V04o0lCG+hsZNVpWRHW0TqSHoto8C5iz+69dtf/KWpFUhC5dGoV0z0KHlSv/6plpHQY2lkOd2Ww01q0+rBjcX3nu6Bt1gsufwQjDybKtN7ESuNWIETnav5hwHf7gu3JVtxJfa7/QTe0Tix0VLX8hC8CYNzlJKW6dqDylbZj3LM8+NTxzn3UEh7UgfrrxeS/LzGtZ0mIKNfNT6q2xDuHljNQIiKjlhzqLLBhPK4TeqTfW6etBZuh1y+9QJsvfJARZyt4w6ZnGT+j8AQHl48jEs/JPwbujArvVtB4qBN/hkqtEMS+EgKgjly8VeZzqX7pE7mz62Y+goen9/3Xu+LKttcMJHyBojUh70imZnNKBxe68QRS162KlAoR7TKKo2fGEHVgrKDp4yN+ewIYwmIvcYUIiHkgvcUO8EiUM6Poa8mnRaNbd/jBgLDSGU5NVrHIz3+h5VmSCAwg304ncNCXv4DSc38QFtqFg7YI0jfmgQPsDak3SeJcfUhmj80lhI6flINP7oTn10k2rTuPUEnXk79druUft+6Wub1gHGSAPJgX6V9Ug0nMR7ODC1ILOCTExmdTIyM8FBfCQWUg++/t3x/m877hsKBNQGOAX7Y/eMziQ9I26xZaYx0UGGZ+5y1RHL42DgUndaJ038bxO3 ULjmOWI2 C7FqAiUs1TyjR2zyzwqNcl+qwFWL7b68HpEDcdeY9ZXRFZMvbAR6Yl+N3uDLiUv/sJD0BXEXlYeQx8nf7Qp2PC9DAOiBlVwLx8vvo1ZqrydYCiRV0OP2gZPK2wr0vVe+SptWAgIjg0NiXH3rtDGu27ZlIQ+fNDD0UNkZTrpKAuuNMj8oiOtTP/Wc9I3xsmnKgzLNkqwSglAQPeh3C1M329NwwGymVxtt/6W0nJnORneYe+raq4GMDUfsgske3uKqoHfrKx/UbWA8YkU61Bn7PUJa1uoIGrrIpEghi7nIgKVTuKQmivnnHA01UwPyhZ9M2oQKAti3cEfAhoOpNb5L6bkUSosHA9Y7fUnWFI5AAwu+jfRiwmy6QTWhRwfi0JYOGssacvSZ2XCOMHPU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.08.24 14:02, Usama Arif wrote: > Currently folio->_deferred_list is used to keep track of > partially_mapped folios that are going to be split under memory > pressure. In the next patch, all THPs that are faulted in and collapsed > by khugepaged are also going to be tracked using _deferred_list. > > This patch introduces a pageflag to be able to distinguish between > partially mapped folios and others in the deferred_list at split time in > deferred_split_scan. Its needed as __folio_remove_rmap decrements > _mapcount, _large_mapcount and _entire_mapcount, hence it won't be > possible to distinguish between partially mapped folios and others in > deferred_split_scan. > > Eventhough it introduces an extra flag to track if the folio is > partially mapped, there is no functional change intended with this > patch and the flag is not useful in this patch itself, it will > become useful in the next patch when _deferred_list has non partially > mapped folios. > > Signed-off-by: Usama Arif > --- > include/linux/huge_mm.h | 4 ++-- > include/linux/page-flags.h | 3 +++ > mm/huge_memory.c | 21 +++++++++++++-------- > mm/hugetlb.c | 1 + > mm/internal.h | 4 +++- > mm/memcontrol.c | 3 ++- > mm/migrate.c | 3 ++- > mm/page_alloc.c | 5 +++-- > mm/rmap.c | 3 ++- > mm/vmscan.c | 3 ++- > 10 files changed, 33 insertions(+), 17 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 4c32058cacfe..969f11f360d2 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -321,7 +321,7 @@ static inline int split_huge_page(struct page *page) > { > return split_huge_page_to_list_to_order(page, NULL, 0); > } > -void deferred_split_folio(struct folio *folio); > +void deferred_split_folio(struct folio *folio, bool partially_mapped); > > void __split_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd, > unsigned long address, bool freeze, struct folio *folio); > @@ -495,7 +495,7 @@ static inline int split_huge_page(struct page *page) > { > return 0; > } > -static inline void deferred_split_folio(struct folio *folio) {} > +static inline void deferred_split_folio(struct folio *folio, bool partially_mapped) {} > #define split_huge_pmd(__vma, __pmd, __address) \ > do { } while (0) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index a0a29bd092f8..cecc1bad7910 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -182,6 +182,7 @@ enum pageflags { > /* At least one page in this folio has the hwpoison flag set */ > PG_has_hwpoisoned = PG_active, > PG_large_rmappable = PG_workingset, /* anon or file-backed */ > + PG_partially_mapped, /* was identified to be partially mapped */ > }; > > #define PAGEFLAGS_MASK ((1UL << NR_PAGEFLAGS) - 1) > @@ -861,8 +862,10 @@ static inline void ClearPageCompound(struct page *page) > ClearPageHead(page); > } > FOLIO_FLAG(large_rmappable, FOLIO_SECOND_PAGE) > +FOLIO_FLAG(partially_mapped, FOLIO_SECOND_PAGE) > #else > FOLIO_FLAG_FALSE(large_rmappable) > +FOLIO_FLAG_FALSE(partially_mapped) > #endif > > #define PG_head_mask ((1UL << PG_head)) > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 6df0e9f4f56c..c024ab0f745c 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -3397,6 +3397,7 @@ int split_huge_page_to_list_to_order(struct page *page, struct list_head *list, > * page_deferred_list. > */ > list_del_init(&folio->_deferred_list); > + folio_clear_partially_mapped(folio); > } > spin_unlock(&ds_queue->split_queue_lock); > if (mapping) { > @@ -3453,11 +3454,12 @@ void __folio_undo_large_rmappable(struct folio *folio) > if (!list_empty(&folio->_deferred_list)) { > ds_queue->split_queue_len--; > list_del_init(&folio->_deferred_list); > + folio_clear_partially_mapped(folio); > } > spin_unlock_irqrestore(&ds_queue->split_queue_lock, flags); > } > > -void deferred_split_folio(struct folio *folio) > +void deferred_split_folio(struct folio *folio, bool partially_mapped) > { /* We lost race with folio_put() */> list_del_init(&folio->_deferred_list); > + folio_clear_partially_mapped(folio); > ds_queue->split_queue_len--; > } > if (!--sc->nr_to_scan) > @@ -3558,7 +3564,6 @@ static unsigned long deferred_split_scan(struct shrinker *shrink, > next: > folio_put(folio); > } > - > spin_lock_irqsave(&ds_queue->split_queue_lock, flags); > list_splice_tail(&list, &ds_queue->split_queue); > spin_unlock_irqrestore(&ds_queue->split_queue_lock, flags); > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 1fdd9eab240c..2ae2d9a18e40 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1758,6 +1758,7 @@ static void __update_and_free_hugetlb_folio(struct hstate *h, > free_gigantic_folio(folio, huge_page_order(h)); > } else { > INIT_LIST_HEAD(&folio->_deferred_list); > + folio_clear_partially_mapped(folio); > folio_put(folio); > } > } > diff --git a/mm/internal.h b/mm/internal.h > index 52f7fc4e8ac3..d64546b8d377 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -662,8 +662,10 @@ static inline void prep_compound_head(struct page *page, unsigned int order) > atomic_set(&folio->_entire_mapcount, -1); > atomic_set(&folio->_nr_pages_mapped, 0); > atomic_set(&folio->_pincount, 0); > - if (order > 1) > + if (order > 1) { > INIT_LIST_HEAD(&folio->_deferred_list); > + folio_clear_partially_mapped(folio); Can we use the non-atomic version here? -- Cheers, David / dhildenb