From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3151C8303D for ; Fri, 4 Jul 2025 17:45:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E8976B02BB; Fri, 4 Jul 2025 13:45:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 599366B02BD; Fri, 4 Jul 2025 13:45:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AF026B02BE; Fri, 4 Jul 2025 13:45:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 384FF6B02BB for ; Fri, 4 Jul 2025 13:45:36 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D25B3801DA for ; Fri, 4 Jul 2025 17:45:35 +0000 (UTC) X-FDA: 83627309430.19.3CB41F0 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) by imf09.hostedemail.com (Postfix) with ESMTP id 3BF8F140011 for ; Fri, 4 Jul 2025 17:45:34 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=IZC9S11P; spf=pass (imf09.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751651134; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MaDn6SelIXcOlzjJrgBEMydXIUt+Gwx/T0S+5DVJELc=; b=XrwE4gCA6gXU8+Yk48vs7aBkXpFmQTmHeYkyfflzgk806dX9aytti9DPSLYzjkPBRhO75s bi8Yk7GMBS6jy1hIDck75+l8gG19X9gfrktecnlS8ARMuoWDIp6O2MwlnJwi2FtZSGHelV PX7lF0P1GHD7M80KVufi5Ir0YmfRB4c= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=IZC9S11P; spf=pass (imf09.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751651134; a=rsa-sha256; cv=none; b=QVlqrWob9/jw4ohp2o6h9Q/N5lEmM/2GvKhyuBp3aOddq4O4sP3yIFkB55KnOn6LuQHqHX JyT52NcyGvf2tXkvriDDbejxV5+7Yjh/RjGkWDUaX10RKeHKkrUcqx4CuB5fEEB+8cjWSv yrnkQdZlIGgCs0UglB7IWPf/0hHu98Y= Date: Fri, 4 Jul 2025 10:45:25 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1751651132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MaDn6SelIXcOlzjJrgBEMydXIUt+Gwx/T0S+5DVJELc=; b=IZC9S11P2XdARLncSFnnb/REFrgQMKWLolXvqM87bpMZzsUPgw7lPqRk16eQsCHXnwwNb8 I//dmFRKUx0PDAEUtxMbeL6rY+gHadt3bQK7G3UKLkyOdaTHnxPlNF+SirVNPYYvuyPyxp k8qoqDz/Z82+B+dz7tr+XKApM+0gkqg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: "Paul E. McKenney" Cc: Tejun Heo , Andrew Morton , JP Kobryn , Johannes Weiner , Ying Huang , Vlastimil Babka , Alexei Starovoitov , Sebastian Andrzej Siewior , Michal =?utf-8?Q?Koutn=C3=BD?= , bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH 2/2] cgroup: explain the race between updater and flusher Message-ID: References: <20250703200012.3734798-1-shakeel.butt@linux.dev> <20250703200012.3734798-2-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: fxumkn36bqpgjyrn6q5s8uju13dytokz X-Rspamd-Queue-Id: 3BF8F140011 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1751651134-103185 X-HE-Meta: U2FsdGVkX1/RIsS2XOAxoEwOZqnThm8lJN8yAVAfMvwqmQPqYAUvy00z/UE4/zChCOZrcL1an3Hw4b8XuxjORjkZ//8esh3yZqzjuZRxglVkR1kHKzW6cznaAb6ZO025+TCldIOJplTaE2Ked0wLEPmfLmFdq301hUzE29DhD3d6fFC7H8ebW+3z/UZfVb8boiNRfnnh7dZKxOx7+Cgcx73Xwiz5PdPEGbQ1xOAilWv97AYwZJt0bTlg7dWP7W7KU/tgT26sQsF1EbFMNPvMwh8+jX4InNyK8fgZXlQeHMJW7IWJhsw4v/Cy4Bdu1ZENfVLCmdLn4uH2Qs1cY6dsCsejfHcM0G5luaGzt0bo17HWlwopPzipeec9WN42FYtYL5WgjsO4WK4ITW9sVUMwcDOecOa5V3fU8rMTQJH3rV/3Xhq1CxV3HlQBBt/+I+F55LKIGy1Y9ctZH0hmlR3jXM6dMR+YehLMe87UYYPfQ4r5FNhmp02fytfUSAURcLuyeVA1hf/qGiOD8ovYBmMGBN3NHx5vru69CM8d5K/BDYtwEIEYIBD41mE/eYMhvRsJJYjd5ZMe9wX18B8l0yG+v3I0VqPiE4Nf0Z8RhmGfJEfJkWV2Iruv61OkkHQLYJh6OPCHwtWhEYhPgHc+Cx6M6zR6aHDY/aLGjqqDmm0qHrTE0iHvew8ibGYOHRegCkaVfpfiQlsauavlsxKS+Ntta7+GIUbU9af9SoOrdC7z6SUuxXnzdpJgiQBGNJC4kuD4ufzxqyBJBJYJWoMoNvJVL7DbBWwmEfrsa5YPTb1/RoUSQ/CHKYm1a7ZlS0yBTWInpKJ1Zhy802iuagXeIxsJOKtVNn/15cHCnCAZ6g5aMlhPPC7zGZWck/8KDt4kKqp/DYfTHqcnThBN7FNVfPCKMh9gLC9KoJgq9B5wR7ykXf42D8hd4MWp0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 03, 2025 at 09:44:58PM -0700, Paul E. McKenney wrote: [...] > > > > Thanks a lot Paul for the awesome explanation. Do you think keeping > > data_race() here would be harmful in a sense that it might cause > > confusion in future? > > Yes, plus it might incorrectly suppress a KCSAN warning for a very > real bug. So I strongly recommend removing the data_race() in this case. > I will remove data_race() tags but keep the comments and squash into the first one. I will keep your reviewed-by tag unless you disagree. thanks, Shakeel