From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DAC8C10F1A for ; Fri, 10 May 2024 02:59:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A92806B0099; Thu, 9 May 2024 22:59:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A19C96B009B; Thu, 9 May 2024 22:59:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 893446B009C; Thu, 9 May 2024 22:59:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 684A86B0099 for ; Thu, 9 May 2024 22:59:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1569F1403DB for ; Fri, 10 May 2024 02:59:24 +0000 (UTC) X-FDA: 82100980248.30.B6A9BF9 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf10.hostedemail.com (Postfix) with ESMTP id 5218BC000A for ; Fri, 10 May 2024 02:59:22 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=oxlqLDO3; spf=pass (imf10.hostedemail.com: domain of rientjes@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715309962; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9YAvN15jkkQy4bLNa73Wwd2uC52sgt5QgcX7n+MN8qs=; b=5lL935dQY0jeUlEcS1DdoB3SPBOFKeZ/BdGQ1qjW972NPdZ3brn7tmKvSt++d9LpqqbmT1 Y/+vS2jY2CmE3h1TLHHji+XUwXqJAWHv4nrnHNOBI/8T/+b62wBE410QphPwTW9QXfW1m7 1GXyDEpHbJVk5v9ookxDm/DGmzJuWlg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=oxlqLDO3; spf=pass (imf10.hostedemail.com: domain of rientjes@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715309962; a=rsa-sha256; cv=none; b=6mTU3sV91B/xy0hJRZXF9zrrdmrXlwxWO7OVxtL9IdYeHSl62nXZ48fxe8G2xffiy5D0BK C4vKRudB6ItuU14qCPLkBZdw3/jXR/qfazv/QK61xHRWZLv57ozMHqey/1DXN64Zt8/xfl w9hpSU5qlRtgG4OSrefen4ZzbM0UzZU= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1eed90a926fso83855ad.0 for ; Thu, 09 May 2024 19:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715309961; x=1715914761; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=9YAvN15jkkQy4bLNa73Wwd2uC52sgt5QgcX7n+MN8qs=; b=oxlqLDO3mNBPltMXc3wP+WT91WULJXpB18LodEXLK87Fc/7RXi4XFm/u4RmVigC0Xb gPEErCib79O+ObL20g3UZF6l4Fa2+zJ44Cc+USwdMPL5rTRE5KQPftVObvAFs63vp0sF LPeiaSBKhVRYv0aWpNQf4Hh72b565g9T/N+8rCIQRRaz4iuv47qbQR7FKpnHailodll8 PzqJDevoxltvQ2G41ZRq/GxQYkJyMImbhbGbmfvu6Sse8x3wEInarxros0eJZ4jzsZcN 6RPTsPhRdYAG9+Bdk/NNXiR+ijhjabxViP7/MnflfbZ6mdHL6VhgnhBRP8Qex15/n9nc mGBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715309961; x=1715914761; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9YAvN15jkkQy4bLNa73Wwd2uC52sgt5QgcX7n+MN8qs=; b=FX7zFe5jjKmQIEGevpSh57Z4wY78THywThXW1enCejxhUn8umTpzkhuLQ379Tnlcx7 2S6pBN1M2B+UpZ7gBG9+/PxTtMnTQp1HLv7g/YsfvMh3XtUBofn6HGTUzplF+Owl9iCL DJlPgu6qh/EgahaXrtwJ/vghN+knGozPgMi2ZRddOkxXsEZmNeR9tAQARw5sOR7GiYS+ xPIkbHYNXe5nga1dDRGD2yMtOr149VFXRqh+WDEyyoW+oN8+Qj2weeUPPplW+ab/SLaL oWLsLCWEi+v2RqMmuiecDR6KbU5m2GJ9Wdp3ilTRAD/VS3weL8TackXkHP/hh96EgVML hoQA== X-Forwarded-Encrypted: i=1; AJvYcCX3ToV3sJTfdx4kcmhD/XWLmXBL51Nn7++NjJ2MwyvZYo+YRjYD3hbbAoXC6DSlVk1eQyk+cxVxbArgH10MfM3taVY= X-Gm-Message-State: AOJu0YxNcCAOpIJanMXKCmGW3sGv1FbE3hmVdTSp4wAq4Lvii3u4IiGW TxUOag1wKh/dIouR2qowm3ty3+t1+U6C4IX/4dPpH7jxgNeYz6Y8SKSJw/zMhg== X-Google-Smtp-Source: AGHT+IGaHJ+wZn5VmufMdAwkzCDF3q/3AUjQoHy7CLQdXnVDg+CcsdVfafdasXLMZwLKfSl4MaPkpg== X-Received: by 2002:a17:903:40d2:b0:1e4:33a6:b0d4 with SMTP id d9443c01a7336-1ef5e8d77d5mr720365ad.9.1715309960592; Thu, 09 May 2024 19:59:20 -0700 (PDT) Received: from [2620:0:1008:15:3671:ce3b:3311:fcd2] ([2620:0:1008:15:3671:ce3b:3311:fcd2]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0c039f29sm21969055ad.219.2024.05.09.19.59.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 19:59:19 -0700 (PDT) Date: Thu, 9 May 2024 19:59:19 -0700 (PDT) From: David Rientjes To: Shakeel Butt cc: Roman Gushchin , Andrew Morton , Muchun Song , Johannes Weiner , Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org, gthelen@google.coma, Chris Li Subject: Re: [PATCH rfc 0/9] mm: memcg: separate legacy cgroup v1 code and put under config option In-Reply-To: Message-ID: References: <20240509034138.2207186-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 5218BC000A X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: zcmmesieoeq5n7xdzyfccqwwnqt74rp4 X-HE-Tag: 1715309962-149577 X-HE-Meta: U2FsdGVkX19i5jQ94ERU4w7o6qxx5iNVUXlAQGXNZSHZkG28yBwIAVI/5qXS/pL5qFL94CPiW+H44zEHex6/cbstYB554D1LHzUa/RVBE4ggP4oNX313mFPio0K/3/Au4VcUK1FWmEh5QCsN37IevlKFZfj8ltqNL05F84Tz8dHON2UngrWob+UqeWe4+yC4RGdIEDj7StkTiDucV+v3cy5Xuan2xlYCEJYVwUX/h+TyTMj841HSfYwXS9iEi68FXANZhQZz0zTLVcj+Ku6xHSRh13Ytvn+nwbLlq5xmebqxDjjdh0KzdrXHKWlL2WpbUuRvvvD6xY+fQ3xpyx26mVF/mM/w+nbwvE218tYJTYzTXceTTJ8wbCjEZf5QrmiaghUX0+HwZ2WGY7HhHWTEbzYyXbs6xHs63JF/fMqs8g6CxEApW8PLF+9qDKN2UJ5tFnXF5RGQH+kq9ZvNF2XsZSPyae6JT2DaEH2LwZ/K8PzomXX3Iq6lZI4E+DE8UiXOb6FUjugdhpteAwH4gEe3p04p7SDZQFsiH74kum1BP7ANg6WBFGQFTk9KkHHMBM2VtmG0vPZS2AbMsUki1OEO/DQbxr/VPjQWIBSOqu/OQT7wfY5XuxnsQG/ORAkvR7qxBDcCOK+dZhg/9aS4Z/Ewz2KOPIzPZ/aFsTBaY9yEcq4aVaJ+EY+iGAwtPgp68LeEnyU6vWKY+NLYVQOAUrISBaP3pxNiLrYtEng8DEhHBwcVpFA0RnxtrS/6r6Nb5NLx5i7WeLfgf5dDbGRaTpNWPpJ9GRVzQ1DXAgkUAd7BZO1Pekh+yzCaVflsq8dvj1BcE9oCtGNHQwYCBX97DJKikUBqhmrkhO26NFkUy+Mqnge0a0y9Y6gUo9/KBHaqom2gd5xZFQG++jkdIPmZMpSl35iRgZjE9pzJcdMribIORvYE8d0DudgI+Phbzh7y5W3804KJs7LidgyKfES+opO zBDNI7+L TA+pmgU4+0giNIvCpwO/z0l5yIZgeZE1evyIQ4ZWJ/hzir37DduC3/rwBphxrU4mfCJpvCVxj8w2i0Kga7mOfRp5+KkSZsR3sZCBTSBtn9lYpOKae4+ICuJP9kf9HfFaGdA5H7KULl3Gefm/UtqftLLPOeTDO082v92gzL2lb6fJPO/bIqvPqAbs3bE5cobw9MLgI5wUoysM/8JVciKICe+xVpWCasAGHy7yJymwb5CJJb5OyZTFDsRuXd2uaIkRj69KfPmp2DA8FSHzP4u38PDpZYSdNndFjMrS5F3vvMqSUm11kV6Gyd1Ggi6B0mm76Zn/MIYiMHXPH4sC/LHiZO6TU7RkdBJ+tfDHfD7rgod/l0IYzOoTtiHYcxHS1EZMLK+GCQ0IibcHOKOBn0j0uv/wioFXXj0tfZLsDNxt3u0jQgeqNT2Bek5knYoCc+Oxyf6vM3ZIdMb/U1y76YBkvhMJuXw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 8 May 2024, Shakeel Butt wrote: > Hi Roman, > > A very timely and important topic and we should definitely talk about it > during LSFMM as well. I have been thinking about this problem for quite > sometime and I am getting more and more convinced that we should aim to > completely deprecate memcg-v1. > I think this would be a very worthwhile discussion at LSF/MM, I'm not sure if it would be too late for someone to make a formal proposal for it to be included in the schedule. Michal would know if there is a opportunity. I say that in light of https://lore.kernel.org/bpf/ZjL5b-zipMrV2JSg@archie.me/T/#mb6c21b09543c434dd85e718a8ecf5ca6485e6d07 as well for the whole cgroup v1 -> v2 transition. Chris, now cc'd, would know best about all of the dependencies that Google has for memcg specifically. > More specifically: > > 1. What are the memcg-v1 features which have no alternative in memcg-v2 > and are blocker for memcg-v1 users? (setting aside the cgroup v2 > structual restrictions) > > 2. What are unused memcg-v1 features which we should start deprecating? > > IMO we should systematically start deprecating memcg-v1 features and > start unblocking the users stuck on memcg-v1. > > Now regarding the proposal in this series, I think it can be a first > step but should not give an impression that we are done. The only > concern I have is the potential of "out of sight, out of mind" situation > with this change but if we keep the momentum of deprecation of memcg-v1 > it should be fine. > > I have CCed Greg and David from Google to get their opinion on what > memcg-v1 features are blocker for their memcg-v2 migration and if they > have concern in deprecation of memcg-v1 features. > > Anyone else still on memcg-v1, please do provide your input. > > thanks, > Shakeel >